graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY A new virtual method is added to Platform: startInteractiveWindowSelection The interactive window selection enters a mode where the user can select a window through the pointer or keyboard device. The cursor is turned into a crosshair cursor, unless another cursor name is provided (e.g. pirate for kill window). Once a window is selected the provided callback method is invoked with the selected Toplevel as argument. In case the user cancelled the selection a nullptr argument is passed in. Currently it's only implemented by the X11 standalone platform using the logic from KillWindow. Just instead of killing the window the callback is invoked. KillWindow loses the X11 implementation and interacts with the new functionality in Platform by providing a lambda function for the killing. TEST PLAN Killing of X11 windows is still possible REPOSITORY rKWIN KWin BRANCH interactive-window-selection REVISION DETAIL https://phabricator.kde.org/D3363 AFFECTED FILES killwindow.cpp killwindow.h platform.cpp platform.h plugins/platforms/x11/standalone/CMakeLists.txt plugins/platforms/x11/standalone/windowselector.cpp plugins/platforms/x11/standalone/windowselector.h plugins/platforms/x11/standalone/x11_platform.cpp plugins/platforms/x11/standalone/x11_platform.h utils.h EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas