D10042: feat: parse EDID on the backend side

romangg accepted this revision. romangg added a comment. This revision is now accepted and ready to land. In D10042#629261 , @dvratil wrote: > Agreed. deviceId is not actually used (it's stored in KDED config files, but the value doesn't seem to

D10042: feat: parse EDID on the backend side

dvratil added a comment. Agreed. deviceId is not actually used (it's stored in KDED config files, but the value doesn't seem to be used anywhere). I'll fix it in a separate commit (since it also needs adjusting a bunch of unit-tests in libkscreen and kscreen). REPOSITORY R110 KScreen

D10042: feat: parse EDID on the backend side

romangg added a comment. Thanks, so I'm talking about this line: [15:31:16.521] kscreen-console(422251:422251) unknown: Device ID: "xrandr-Eizo Nanao Corporation-DP-7-EV2736W/96211045" There it says xrandr, which should likely be not there. REPOSITORY R110 KScreen Library

D10042: feat: parse EDID on the backend side

dvratil added a comment. Here's kscreen-console output for one of my monitors under Wayland with this patch applied: [15:31:16.520] kscreen-console(422251:422251) unknown: Id: 3 [15:31:16.520] kscreen-console(422251:422251) unknown: Name: "Eizo Nanao Corporation

D10042: feat: parse EDID on the backend side

dvratil updated this revision to Diff 77825. dvratil edited the summary of this revision. dvratil added a comment. - Rebase on current master - Move Edid construction to WaylandOutput::edid REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE

D10042: feat: parse EDID on the backend side

dvratil marked an inline comment as done. dvratil added inline comments. INLINE COMMENTS > romangg wrote in waylandbackend.cpp:81 > Let the backend populate the Private here is unusual, or is it not? On the > other side it makes sense. Let the consumer only access the public interface > and

D10042: feat: parse EDID on the backend side

romangg added a comment. The idea to parse on the backend side is sound. Can you paste the output you get in a Wayland session? For me it shows the XWayland EDID of the outputs. INLINE COMMENTS > waylandbackend.cpp:81 > +auto device = output->outputDevice(); > +auto edid = new