mlaurent added a comment.
Ping ?
REPOSITORY
R106 KSysguard
REVISION DETAIL
https://phabricator.kde.org/D10151
To: carlavilla, mlaurent, ngraham
Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
mlaurent added a comment.
For patch it seems ok.
But Nathaniel is right. Describe how you tested it, add BUG: etc.
Otherwise it's a good start :)
Thanks.
REPOSITORY
R106 KSysguard
REVISION DETAIL
https://phabricator.kde.org/D10151
To: carlavilla, mlaurent, ngraham
Cc:
ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.
Thanks for the patch! In general, it's best to title your Phabricator
revision with a short description of the change or fix itself, and mention the
bug in the Summary section.
carlavilla created this revision.
carlavilla added a reviewer: mlaurent.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
carlavilla requested review of this revision.
REVISION SUMMARY
Solved the bug with the & in the tabs
REPOSITORY
