D10463: [WIP/RFC] Consistently use a Toolbar for headers

2018-02-12 Thread Nathaniel Graham
ngraham abandoned this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10463 To: ngraham, #discover_software_store, abetts, apol Cc: mmustac, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10463: [WIP/RFC] Consistently use a Toolbar for headers

2018-02-12 Thread Nathaniel Graham
ngraham added a comment. Abandoning in favor of D10471: Use Kirgami.ToolBarApplicationHeader instead of the view headers , which is a saner and more sustainable way to do the same thing, and will also yield benefits for other Kirigami consumers because

D10463: [WIP/RFC] Consistently use a Toolbar for headers

2018-02-12 Thread Marijo Mustac
mmustac added a comment. Definitely a step into the right direction. Thumbs up. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10463 To: ngraham, #discover_software_store, abetts, apol Cc: mmustac, plasma-devel, ZrenBot, progwolff, lesliezhai,

D10463: [WIP/RFC] Consistently use a Toolbar for headers

2018-02-12 Thread Aleix Pol Gonzalez
apol added a comment. See https://phabricator.kde.org/D10471 REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10463 To: ngraham, #discover_software_store, abetts, apol Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D10463: [WIP/RFC] Consistently use a Toolbar for headers

2018-02-12 Thread Nathaniel Graham
ngraham added a comment. As long as it looks good on the desktop too (or we can make it look good on the desktop too), I'm okay with that. Does it look and behave acceptably right now? REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10463 To:

D10463: [WIP/RFC] Consistently use a Toolbar for headers

2018-02-12 Thread Aleix Pol Gonzalez
apol added a comment. If we're to do this, I'd very much prefer to use kirigami's native header. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10463 To: ngraham, #discover_software_store, abetts, apol Cc: plasma-devel, ZrenBot, progwolff,

D10463: [WIP/RFC] Consistently use a Toolbar for headers

2018-02-12 Thread Nathaniel Graham
ngraham retitled this revision from "Consistently use a Toolbar for headers" to "[WIP/RFC] Consistently use a Toolbar for headers". ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL