This revision was automatically updated to reflect the committed changes.
Closed by commit R108:6d6576f81932: [kcmkwin/rules] Disable detect button on
Wayland (authored by graesslin).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10642?vs=27555=28561
REVISION
graesslin updated this revision to Diff 27555.
graesslin added a comment.
Restricted Application edited projects, added KWin; removed Plasma.
Hide buttons intead of disabling them
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10642?vs=27484=27555
BRANCH
mart added a comment.
Restricted Application edited projects, added Plasma; removed KWin.
i also wonder if wouldn't be better to hide it as that button could never
ever be enabled at all in wayland (at least.. i guess?)
REPOSITORY
R108 KWin
BRANCH
detect-button-disabled-5.12
REVISION
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
Restricted Application edited projects, added KWin; removed Plasma.
REPOSITORY
R108 KWin
BRANCH
detect-button-disabled-5.12
REVISION DETAIL
https://phabricator.kde.org/D10642
To: graesslin, #kwin,
graesslin added a comment.
Restricted Application edited projects, added Plasma; removed KWin.
Tooltip is not possible, we are in string freeze. I can of course hide the
button, but then users might be wondering where it has gone. Given that I doubt
it makes much difference.
REPOSITORY
ngraham added a comment.
Restricted Application edited projects, added KWin; removed Plasma.
Maybe we should just remove it instead of disabling it? Otherwise people will
wonder why it's disabled and sitting there, taunting them. Alternatively, an
informative tooltip explaining the issue
graesslin created this revision.
graesslin added reviewers: KWin, Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
graesslin requested review of this revision.
Restricted Application edited projects, added Plasma; removed KWin.
