This revision was automatically updated to reflect the committed changes.
Closed by commit R134:af5058de7f9a: Provide the source selection as a
contextual action (authored by apol).
REPOSITORY
R134 Discover Software Store
CHANGES SINCE LAST UPDATE
cfeck added a comment.
Was this committed?
REPOSITORY
R134 Discover Software Store
BRANCH
sourcesUI
REVISION DETAIL
https://phabricator.kde.org/D10753
To: apol, ngraham
Cc: cfeck, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.
OK then!
REPOSITORY
R134 Discover Software Store
BRANCH
sourcesUI
REVISION DETAIL
https://phabricator.kde.org/D10753
To: apol, ngraham
Cc: ngraham, plasma-devel, ZrenBot,
apol added a comment.
This is an issue in qqc2-desktop-style, not something to solve from Discover.
REPOSITORY
R134 Discover Software Store
REVISION DETAIL
https://phabricator.kde.org/D10753
To: apol, ngraham
Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,
ngraham requested changes to this revision.
This revision now requires changes to proceed.
REPOSITORY
R134 Discover Software Store
REVISION DETAIL
https://phabricator.kde.org/D10753
To: apol, ngraham
Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,
abetts,
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.
Turning the checkboxes into radio buttons is tracked with
https://bugs.kde.org/show_bug.cgi?id=391144.
One more visual papercut: The menu is not wide enough to accommodate all the
ngraham added a comment.
Got it working. I think it's better than what we have now, at least. However,
the use of checkboxes in the menu is inappropriate: since the entries are
mutually exclusive, we should use radio buttons instead (Same with the sort
menu; see
apol added a comment.
> I see what you're going for here, but the "Sources" menu you're trying to
add still doesn't actually work, same as the Sort menu. Is there an open
Kirigami patch that this depends upon?
No, please look into how it's possible that it's not working for you. I'll be
apol updated this revision to Diff 27842.
apol added a comment.
Remove the description part of origin switching
REPOSITORY
R134 Discover Software Store
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10753?vs=27816=27842
BRANCH
sourcesUI
REVISION DETAIL
ngraham added a comment.
OK, the i18n error is gone now. But do we really need that "also available in
" text at the end of the Description, anyway? Apparently nobody reads it.
Maybe we should focus on polishing the main source chooser UI and get rid of
that little vestigial one.
ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.
I see what you're going for here, but the "Sources" menu you're trying to add
still doesn't actually work, same as the Sort menu. Is there an open Kirigami
patch that this
apol updated this revision to Diff 27816.
apol added a comment.
Polish
REPOSITORY
R134 Discover Software Store
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10753?vs=27814=27816
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D10753
AFFECTED FILES
apol created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
apol requested review of this revision.
REVISION SUMMARY
Instead of the dreaded link button.
BUG: 390464
REPOSITORY
R134 Discover Software Store
BRANCH
13 matches
Mail list logo