hein closed this revision.
hein added a comment.
Committed as d6818eac6fbe495facf558b41cd570604bb7cbcb.
REVISION DETAIL
https://phabricator.kde.org/D10837
To: painlessroaster, #plasma, hein
Cc: Pitel, cfeck, anemeth, ngraham, plasma-devel, hein, davidedmundson,
ZrenBot, lesliezhai, ali-moh
Pitel added a comment.
@painlessroaster is not me. What gave you impression he is?
REVISION DETAIL
https://phabricator.kde.org/D10837
To: painlessroaster, #plasma, hein
Cc: Pitel, cfeck, anemeth, ngraham, plasma-devel, hein, davidedmundson,
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,
ngraham added a subscriber: Pitel.
ngraham added a comment.
Looks like the patch no longer applies. Radek, can you re-base this on
master? You can do this with `git pull --rebase origin master`
Also, are you @pitel? If so, it's a bit confusing to have two accounts for
the same person; pl
ngraham added a comment.
Looks like no. I'll be happy to commit it shortly...
REVISION DETAIL
https://phabricator.kde.org/D10837
To: painlessroaster, #plasma, hein
Cc: cfeck, anemeth, ngraham, plasma-devel, hein, davidedmundson, ZrenBot,
lesliezhai, ali-mohamed, jensreuterberg, abetts, seb
cfeck added a comment.
Was this already committed?
REVISION DETAIL
https://phabricator.kde.org/D10837
To: painlessroaster, #plasma, hein
Cc: cfeck, anemeth, ngraham, plasma-devel, hein, davidedmundson, ZrenBot,
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
painlessroaster added a comment.
Radek Bucek
radek.bu...@voipmonitor.org
REVISION DETAIL
https://phabricator.kde.org/D10837
To: painlessroaster, #plasma, hein
Cc: anemeth, ngraham, plasma-devel, hein, davidedmundson, ZrenBot, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol,
hein added a comment.
Could you let me know which real name to use on the commit?
REVISION DETAIL
https://phabricator.kde.org/D10837
To: painlessroaster, #plasma, hein
Cc: anemeth, ngraham, plasma-devel, hein, davidedmundson, ZrenBot, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas,
painlessroaster added a comment.
I do not have a contributor account. Please commit this.
REVISION DETAIL
https://phabricator.kde.org/D10837
To: painlessroaster, #plasma, hein
Cc: anemeth, ngraham, plasma-devel, hein, davidedmundson, ZrenBot, lesliezhai,
ali-mohamed, jensreuterberg, abetts
hein accepted this revision.
hein added a comment.
This revision is now accepted and ready to land.
Thanks. Do you have a contributor account or should we commit this on your
behalf?
REVISION DETAIL
https://phabricator.kde.org/D10837
To: painlessroaster, #plasma, hein
Cc: anemeth, ngraham,
anemeth added a comment.
works great
REVISION DETAIL
https://phabricator.kde.org/D10837
To: painlessroaster, #plasma
Cc: anemeth, ngraham, plasma-devel, hein, davidedmundson, ZrenBot, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
painlessroaster added a comment.
new patch with correct rtl support
REVISION DETAIL
https://phabricator.kde.org/D10837
To: painlessroaster, #plasma
Cc: plasma-devel, hein, davidedmundson, ZrenBot, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
painlessroaster added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION DETAIL
https://phabricator.kde.org/D10837
To: painlessroaster, #plasma
Cc: plasma-devel, hein, davidedmundson, ZrenBot, lesliezhai, ali-moh
12 matches
Mail list logo