D11316: Components for Cards

mart updated this revision to Diff 29904. mart added a comment. - use kirigami namespace REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11316?vs=29626=29904 BRANCH mart/Card REVISION DETAIL https://phabricator.kde.org/D11316 AFFECTED FILES

D11316: Components for Cards

This revision was automatically updated to reflect the committed changes. Closed by commit R169:def2e9760909: Components for Cards (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D11316?vs=29904=29905#toc REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE

D11316: Components for Cards

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. +1 Probably worth porting some real world code before commiting the new API. Please commit with split the header changes, and Units change they seem very stand-alone.

D11316: Components for Cards

mart updated this revision to Diff 29626. mart added a comment. - better top padding REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11316?vs=29585=29626 BRANCH mart/Card REVISION DETAIL https://phabricator.kde.org/D11316 AFFECTED FILES

D11316: Components for Cards

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in CardsLayout.qml:35 > I can see you want it in a layout because you're setting the relevant > attached properties, but why explicitly Column? It's not mandatory but the one i think it makes more sense, so i want to put it as

D11316: Components for Cards

mart updated this revision to Diff 29585. mart marked 3 inline comments as done. mart added a comment. - fix elide for bannerimage REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11316?vs=29514=29585 BRANCH mart/Card REVISION DETAIL

D11316: Components for Cards

davidedmundson added inline comments. INLINE COMMENTS > CardsLayoutGallery.qml:83 > +Kirigami.AbstractCard { > +Layout.fillWidth: true > +showClickFeedback: true Why is it the responsiblility of the user of a CardLayout to set Layout.fillWidth: true

D11316: Components for Cards

mart added a comment. now it's on top of master and qmldir has all the public files REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D11316 To: mart, #kirigami, davidedmundson Cc: apol, ngraham, davidedmundson, progwolff, plasma-devel, mart, hein

D11316: Components for Cards

mart updated this revision to Diff 29514. mart added a comment. - add to qmldir - Merge branch 'master' into mart/Card - add more items to qmldir REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11316?vs=29502=29514 BRANCH mart/Card REVISION DETAIL

D11316: Components for Cards

mart added a comment. In D11316#225668 , @apol wrote: > Worked for me. Had to expose the components in the qmldir: > > diff --git a/src/qmldir b/src/qmldir > index f262452..2275600 100644 > --- a/src/qmldir > +++ b/src/qmldir

D11316: Components for Cards

apol added a comment. Worked for me. Had to expose the components in the qmldir: diff --git a/src/qmldir b/src/qmldir index f262452..2275600 100644 --- a/src/qmldir +++ b/src/qmldir @@ -36,4 +36,6 @@ AbstractApplicationHeader 2.0 AbstractApplicationHeader.qml

D11316: Components for Cards

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in AbstractCard.qml:69 > The following should behave the same and it keeps all the semantic meaning > and it means data flows in the right directions > > implicitHeight: mainLayout.implicitHeight + topPadding + bottomPadding

D11316: Components for Cards

mart added a comment. In D11316#225496 , @progwolff wrote: > There seems to be a problem with the overflow menu: > > F5753673: Screenshot_20180314_121900.png fixed in latest version REPOSITORY

D11316: Components for Cards

mart updated this revision to Diff 29502. mart added a comment. - fix last binging loop - update the qrc - up to date qmltypes - take layout spacing into account REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11316?vs=29486=29502 BRANCH mart/Card

D11316: Components for Cards

davidedmundson requested changes to this revision. davidedmundson added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > mart wrote in AbstractCard.qml:69 > no, when it's in a layout the size hints are based purely on the content. > > the different behavior is

D11316: Components for Cards

mart added inline comments. INLINE COMMENTS > mart wrote in AbstractCard.qml:69 > no, when it's in a layout the size hints are based purely on the content. > > the different behavior is when it's in a gridview or a listview, where its > sized is based respectively on the cell size or to be

D11316: Components for Cards

progwolff added a comment. There seems to be a problem with the overflow menu: F5753673: Screenshot_20180314_121900.png REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D11316 To: mart, #kirigami Cc: davidedmundson,

D11316: Components for Cards

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in AbstractCard.qml:69 > are you basing the implicit size from the size of the parent layout? no, when it's in a layout the size hints are based purely on the content. the different behavior is when it's in a gridview or a

D11316: Components for Cards

davidedmundson added inline comments. INLINE COMMENTS > AbstractCard.qml:69 > + > +implicitWidth: internal.completed > +? (internal.listView ? internal.listView.width - > internal.listView.spacing * 2 : are you basing the implicit size from the size of the parent layout?

D11316: Components for Cards

mart updated this revision to Diff 29486. mart added a comment. - fix typos REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11316?vs=29469=29486 BRANCH mart/Card REVISION DETAIL https://phabricator.kde.org/D11316 AFFECTED FILES

D11316: Components for Cards

progwolff added a comment. Marked some typos. Note that I am not a native speaker, so please re-check them. Besides that, looks good to me. INLINE COMMENTS > CardsGridViewGallery.qml:61 > +wrapMode: Text.WordWrap > +text: "The Kirigami types AbstractCard and

D11316: Components for Cards

mart created this revision. mart added a reviewer: Kirigami. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY Cards are divided in AbstractCard which is empty and Card, which has