D11661: Fix wrong X-DocPath in kcm_launchfeedback.desktop

[Burkhard Lück]

lueck added a comment.


  In D11661#233341 , @hein wrote:
  
  > I disagree with this patch - I renamed things for consistency for a reason 
and emailed i18n-doc, so I expect the docs to get renamed.
  
  
  Right you emailed i18n-doc, changed the X-DocPath to 
control/kcmlaunchfeedback/index.html, but not the install target in 
doc/kcontrol/kcmlaunch/CMakeLists.txt,
  therefore the englisch documentation is not found.
  
  The name of the docmessages catalog, the name of the translated docs and the 
install target for the translated docs are autogenerated by scripty.
  Rename the translated docs is therefore no real option, the dir 
doc/kcontrol/kcmlaunch/ has to be renamed, another level of consistency ;-)
  
  I will upload a new patch so fix this bug for the english and the language 
docs.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11661

To: lueck, #plasma, #localization, #documentation, davidedmundson, hein
Cc: aacid, hein, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11661: Fix wrong X-DocPath in kcm_launchfeedback.desktop

[Albert Astals Cid]

aacid added a comment.


  Your email said "master branch renamed kcmlaunch.pot to 
kcmlaunchfeedback.pot" you did never mention docs.
  
  Anyhow, are you asking Burkhard to change the patch to rename the folder? I 
guess that's also a fine solution.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11661

To: lueck, #plasma, #localization, #documentation, davidedmundson, hein
Cc: aacid, hein, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11661: Fix wrong X-DocPath in kcm_launchfeedback.desktop

[Eike Hein]

hein requested changes to this revision.
hein added a comment.
This revision now requires changes to proceed.


  I disagree with this patch - I renamed things for consistency for a reason 
and emailed i18n-doc, so I expect the docs to get renamed.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11661

To: lueck, #plasma, #localization, #documentation, davidedmundson, hein
Cc: hein, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D11661: Fix wrong X-DocPath in kcm_launchfeedback.desktop

[Burkhard Lück]

lueck created this revision.
lueck added reviewers: Plasma, Localization, Documentation.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
lueck requested review of this revision.

REVISION SUMMARY
  kcms/launch/kcm_launchfeedback.desktop
  X-DocPath=kcontrol/kcmlaunchfeedback/index.html
  
  doc/kcontrol/kcmlaunch/CMakeLists.txt
  kdoctools_create_handbook(index.docbook INSTALL_DESTINATION 
${KDE_INSTALL_DOCBUNDLEDIR}/en SUBDIR kcontrol/kcmlaunch)
  
  kcmlaunch != kcmlaunchfeedback therefore the en_US documentation is not found
  
  Scripty generates the install path from the dir name
  l10n-kf5/[lang]/docs/kde-workspace/kcontrol/kcmlaunch/CMakeLists.txt
  kdoctools_create_handbook(index.docbook INSTALL_DESTINATION 
${HTML_INSTALL_DIR}/${CURRENT_LANG}/ SUBDIR kcontrol/kcmlaunch )
  
  We need X-DocPath=kcontrol/kcmlaunch/index.html in the desktop file
  then khelpcenter finds the correct docbook for en_US and all language 
translations

TEST PLAN
  build and works

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11661

AFFECTED FILES
  kcms/launch/kcm_launchfeedback.desktop

To: lueck, #plasma, #localization, #documentation
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart