D11955: [Folder View] Set Refresh shortcut on Refresh/Reload

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:9a333b48ca1a: [Folder View] Set Refresh shortcut on 
Refresh/Reload (authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11955?vs=32995=33001

REVISION DETAIL
  https://phabricator.kde.org/D11955

AFFECTED FILES
  containments/desktop/plugins/folder/autotests/foldermodeltest.cpp
  containments/desktop/plugins/folder/foldermodel.cpp

To: broulik, #plasma, hein
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11955: [Folder View] Set Refresh shortcut on Refresh/Reload

[Kai Uwe Broulik]

broulik updated this revision to Diff 32995.
broulik edited the summary of this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  - Drop "reload" action

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11955?vs=31383=32995

REVISION DETAIL
  https://phabricator.kde.org/D11955

AFFECTED FILES
  containments/desktop/plugins/folder/autotests/foldermodeltest.cpp
  containments/desktop/plugins/folder/foldermodel.cpp

To: broulik, #plasma, hein
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11955: [Folder View] Set Refresh shortcut on Refresh/Reload

[Kai Uwe Broulik]

broulik planned changes to this revision.
broulik added a comment.


  I just noticed that `setUsedByContainment` actually renames the "reload" 
action to "Refresh desktop", so "refresh" is essentially useless.
  Will refactor this to get rid of the dedicated "Refresh" action and just use 
"Reload" everywhere (with appropriate name as is currently done in the code 
already)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11955

To: broulik, #plasma, hein
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11955: [Folder View] Set Refresh shortcut on Refresh/Reload

[Eike Hein]

hein accepted this revision.
hein added a comment.
This revision is now accepted and ready to land.


  Could you add a code comment about why this is not an issue, similar to the 
description? If two far-removed places of code depend on each other indirectly 
and by design it warrants a comment so future developers have a chance to keep 
it working.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11955

To: broulik, #plasma, hein
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11955: [Folder View] Set Refresh shortcut on Refresh/Reload

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, hein.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  While both actions are added to the collection, only one is shown at a time 
and the shortcut is managed by us anyway, so this is not an issue to assign it 
to both.
  
  CCBUG: 392730

TEST PLAN
  - Refresh or Reload now show F5  in the 
context menu
  - Verified that F5  still reloads the correct 
focused FolderView and that both Refresh (containment) and Reload (applet) work

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11955

AFFECTED FILES
  containments/desktop/plugins/folder/foldermodel.cpp

To: broulik, #plasma, hein
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart