D12497: Fully remove "Application Name" from details panel

[Scott Harvey]

sharvey added a comment.


  In D12497#253114 , @ngraham wrote:
  
  > No need to abandon this revision; you could pull down master, re-branch, do 
your changes there, and then issue `arc diff --update D12497`, and it will 
replace the diff here with what you have locally.
  
  
  Added to my "Phab/arc" notes for the future.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

REVISION DETAIL
  https://phabricator.kde.org/D12497

To: sharvey, bruns, ngraham, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12497: Fully remove "Application Name" from details panel

[Nathaniel Graham]

ngraham added a comment.


  No need to abandon this revision; you could pull down master, re-branch, do 
your changes there, and then issue `arc diff --update D12497`, and it will 
replace the diff here with what you have locally.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

REVISION DETAIL
  https://phabricator.kde.org/D12497

To: sharvey, bruns, ngraham, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12497: Fully remove "Application Name" from details panel

[Scott Harvey]

sharvey added a comment.


  In D12497#253108 , @ngraham wrote:
  
  > For a removal patch, I see a suspicious amount of green here...
  
  
  Forgot to pull a fresh master after you committed my previous change. 
Abandoning and reworking. Argh.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

REVISION DETAIL
  https://phabricator.kde.org/D12497

To: sharvey, bruns, ngraham, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12497: Fully remove "Application Name" from details panel

[Nathaniel Graham]

ngraham added a comment.


  For a removal patch, I see a suspicious amount of green here...

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

REVISION DETAIL
  https://phabricator.kde.org/D12497

To: sharvey, bruns, ngraham, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12497: Fully remove "Application Name" from details panel

[Scott Harvey]

sharvey updated this revision to Diff 32991.
sharvey added a comment.


  - Corrected `Not Applicable` to `Not Available`

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12497?vs=32990=32991

BRANCH
  remove-appname (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12497

AFFECTED FILES
  AuthDialog.cpp
  AuthDialog.h
  authdetails.ui

To: sharvey, bruns, ngraham, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12497: Fully remove "Application Name" from details panel

[Scott Harvey]

sharvey created this revision.
sharvey added reviewers: bruns, ngraham, davidedmundson.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
sharvey requested review of this revision.

REVISION SUMMARY
  Remove `Application Name` from details panel; backend code removed long ago

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  remove-appname (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12497

AFFECTED FILES
  AuthDialog.cpp
  AuthDialog.h
  authdetails.ui

To: sharvey, bruns, ngraham, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart