D12539: Klipper: Do not insert secret data into history

davidedmundson added a comment. I was kinda hoping to see your keepassx patch merged before we did this in case of any changes, but given we have 5.13 beta soon, I've merged as-is REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D12539 To: hoffmannrobert,

D12539: Klipper: Do not insert secret data into history

This revision was automatically updated to reflect the committed changes. Closed by commit R120:637cd0bf62e4: Klipper: Do not insert secret data into history (authored by hoffmannrobert, committed by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D12539?vs=33138=34277#toc

D12539: Klipper: Do not insert secret data into history

graesslin added a comment. In D12539#254330 , @broulik wrote: > > And it's probably something we also want to add to KWallet and maybe every password field we have. > > Since when can you Copy from password fields? I just locked my

D12539: Klipper: Do not insert secret data into history

hoffmannrobert added a comment. The keepassx pull request: https://github.com/keepassx/keepassx/pull/211 REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D12539 To: hoffmannrobert, davidedmundson Cc: broulik, graesslin, davidedmundson,

D12539: Klipper: Do not insert secret data into history

broulik added a comment. > And it's probably something we also want to add to KWallet and maybe every password field we have. Since when can you Copy from password fields? REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D12539 To:

D12539: Klipper: Do not insert secret data into history

graesslin added a comment. And it's probably something we also want to add to KWallet and maybe every password field we have. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D12539 To: hoffmannrobert, davidedmundson Cc: graesslin,

D12539: Klipper: Do not insert secret data into history

davidedmundson added a comment. Can you link to the relevant Keepassx patch when you make it so I can help follow up there. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D12539 To: hoffmannrobert, davidedmundson Cc: davidedmundson,

D12539: Klipper: Do not insert secret data into history

hoffmannrobert added a comment. No, I haven't. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D12539 To: hoffmannrobert, davidedmundson Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D12539: Klipper: Do not insert secret data into history

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Beautiful! Do you have commit access? REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D12539 To: hoffmannrobert,

D12539: Klipper: Do not insert secret data into history

hoffmannrobert created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. hoffmannrobert requested review of this revision. REVISION SUMMARY Password manager tools like Keepassx offer an option to clear the