D12685: Fix calendar view: hide unused start/end time labels in day events list

[Friedrich W. H. Kossebau]

kossebau abandoned this revision.
kossebau added a comment.


  Sadly lost track of this, and no plans to pick this up again in the 
foreseeable future given other stuff to do, so discarding now to clean up the 
todo stack.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D12685

To: kossebau, #vdg, #plasma, dvratil
Cc: abetts, mart, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, ahiemstra

D12685: Fix calendar view: hide unused start/end time labels in day events list

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> CalendarView.qml:193
> +readonly property bool hasEndTime: 
> !isNaN(modelData.endDateTime.getTime());
> +readonly property bool isAllDay: {
>  // Explicitly all-day event

being a very heavy binding, i wonder if would be worth moving the calculation 
of isallday in the model itself?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D12685

To: kossebau, #vdg, #plasma, dvratil
Cc: mart, abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol

D12685: Fix calendar view: hide unused start/end time labels in day events list

[Andres Betts]

abetts added a comment.


  I think this is a good idea. Maybe the execution is a bit rough but we can 
work in making the looks better. Can you take a look at this calendar list and 
see if there are some things we can use?
  
  
https://www.google.com/search?q=fantastical=lnms=isch=X=0ahUKEwi80L6p5PPaAhWriFQKHTMBBzcQ_AUICygC=1920=974#imgrc=LvZCtg07M9NTqM:
  
  For one, the double lines at the left to show start and finish for an event 
is a great idea, but it is taking a lot of real estate. Maybe we can rework it?
  
  Thank you,
  
  Andy

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D12685

To: kossebau, #vdg, #plasma, dvratil
Cc: abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D12685: Fix calendar view: hide unused start/end time labels in day events list

[Daniel Vrátil]

dvratil added a comment.


  I could imagine using something like  "14:00 →" to indicate that the event 
starts today at 2PM but does not end today, and "→ 16:00" to indicate that this 
is a multi-day event that didn't start today and ends today at 4PM.
  
  Not sure how to indicate a multi-day event that does not start or end today. 
Maybe just with the arrow without any time?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D12685

To: kossebau, #vdg, #plasma, dvratil
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12685: Fix calendar view: hide unused start/end time labels in day events list

[Friedrich W . H . Kossebau]

kossebau added a comment.


  Before:
  F5832339: CalendarBefore.png 
  
  After:
  F5832341: CalendarAfter.png 
  
  I see a small challenge here though how to denote if a date is the start or 
the end date, in case there is no respective end or start date. Currently the 
end date is "highlighted" by setting the Label to state disabled. Additionally 
the alignment in multi-line event descriptions gives a hint.
  For single-line event items that does not work that well. So possibly needs 
some other markup.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D12685

To: kossebau, #vdg, #plasma, dvratil
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12685: Fix calendar view: hide unused start/end time labels in day events list

[Friedrich W . H . Kossebau]

kossebau created this revision.
kossebau added reviewers: VDG, Plasma, dvratil.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  There can be events with no start or no end date. Yet currently the
  Label items for the dates, because of not being set invisible, still
  occupy screen real estate. To the effect that in case of an event
  description which just would take a single "text line" the date labels
  still take two "text lines", one for the invisible, one for the shown
  date, and also with the date text and the description text not being
  aligned.
  
  Setting the respective Label items to invisible if there is no start or
  no end date results in saved screen real estate and thus being able to
  show more events in case of single-line descriptions with either start or
  end date, as well as having their text (almost) aligned.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  supportstartendonlydates

REVISION DETAIL
  https://phabricator.kde.org/D12685

AFFECTED FILES
  applets/digital-clock/package/contents/ui/CalendarView.qml

To: kossebau, #vdg, #plasma, dvratil
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart