D12882: [Notifications] Move "Open With" items into the top group of the menu

2018-05-15 Thread Nathaniel Graham
ngraham closed this revision.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D12882

To: ngraham, broulik
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D12882: [Notifications] Move "Open With" items into the top group of the menu

2018-05-15 Thread Kai Uwe Broulik
broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  Thanks!

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12882

To: ngraham, broulik
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D12882: [Notifications] Move "Open With" items into the top group of the menu

2018-05-14 Thread Nathaniel Graham
ngraham created this revision.
ngraham added a reviewer: broulik.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Move the Open With items into the top group of the context menu for 
notifications with images or files that you can open and see in the filesystem.
  
  I didn't move them all the way to the top because my sense is that Open 
containing folder is the more common action and deserves to be the top item. 
Also, putting it below the Open With actions would result in an extra ugly 
separator.

TEST PLAN
  [image goes here]

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12882

AFFECTED FILES
  applets/notifications/plugin/thumbnailer.cpp

To: ngraham, broulik
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart