D13051: Fix Font KCM force font DPI checkbox

2018-05-23 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R119:b2694cfc64de: Fix Font KCM force font DPI checkbox (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D13051?vs=34679=34697#toc REPOSITORY R119 Plasma Desktop

D13051: Fix Font KCM force font DPI checkbox

2018-05-23 Thread David Edmundson
davidedmundson added inline comments. INLINE COMMENTS > broulik wrote in main.qml:222 > `when: dpiSpinbox.enabled`? I want to set it explicitly to 0 when we're not enabled. Two Bindings with two when statements would work, but that seems more complex. REPOSITORY R119 Plasma Desktop

D13051: Fix Font KCM force font DPI checkbox

2018-05-23 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > main.qml:222 > +property: "fontAASettings.dpi" > +value: dpiSpinBox.enabled ? dpiSpinBox.value : 0 > +} `when: dpiSpinbox.enabled`? REPOSITORY R119 Plasma Desktop REVISION DETAIL

D13051: Fix Font KCM force font DPI checkbox

2018-05-22 Thread David Edmundson
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY Fixes numerous issues: 1. the default