D13672: Mouse KCM Pointer Speed Slider Improvement

[Furkan Tokac]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:13b35bd8025a: Mouse KCM Pointer Speed Slider Improvement 
(authored by furkantokac).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13672?vs=36495=36714

REVISION DETAIL
  https://phabricator.kde.org/D13672

AFFECTED FILES
  kcms/mouse/kcm/libinput/main.qml
  kcms/mouse/kcm/libinput/main_deviceless.qml

To: furkantokac, ngraham, romangg, #plasma, mart
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13672: Mouse KCM Pointer Speed Slider Improvement

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> romangg wrote in main.qml:199
> The 0.1 was wrong before. Should be now some value in the range, probably `1`.

IMHO it should be the exact middle value (0 in terms of the libinput value, or 
position 6 on the slider).

Material for another patch, though.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13672

To: furkantokac, ngraham, romangg, #plasma, mart
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13672: Mouse KCM Pointer Speed Slider Improvement

[Roman Gilg]

romangg accepted this revision.
romangg added inline comments.

INLINE COMMENTS

> main.qml:199
>  if (!enabled) {
> -value = 0.1
> +value = 0.2
>  return

The 0.1 was wrong before. Should be now some value in the range, probably `1`.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13672

To: furkantokac, ngraham, romangg, #plasma, mart
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13672: Mouse KCM Pointer Speed Slider Improvement

[Nathaniel Graham]

ngraham added a comment.


  In D13672#282856 , @furkantokac 
wrote:
  
  > In D13672#281774 , @ngraham 
wrote:
  >
  > > `BUG: 395681` can't be a link, I don't think. It's gotta just be plain 
old dumb text. :)
  >
  >
  > This patch actually solves the problem specified on bug title, "libinput 
pointer kcm needs 11 ticks on the speed slider so that the middle one can 
correspond to 0.0". Still you think that it doesn't solve the bug ?
  
  
  No, I wasn't telling you to remove the text "BUG: 395681". I was telling you 
to not make it a link.
  
  > 
  > 
  >> Also, it seems that this is dependent on D13573 
. So please also add `Depends on D13573` to 
the Summary section somewhere. Then do `arc amend` locally. Thanks!
  > 
  > D13573  patch is for Touchpad KCM but 
this patch is for Mouse KCM There is a confusion  So I'm going to apply the 
same patch for Touchpad KCM too. Same issue, same solution.
  
  Ah yes, my mistake. Please do so!

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13672

To: furkantokac, ngraham, romangg, #plasma, mart
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13672: Mouse KCM Pointer Speed Slider Improvement

[Furkan Tokac]

furkantokac added a comment.


  In D13672#281774 , @ngraham wrote:
  
  > `BUG: 395681` can't be a link, I don't think. It's gotta just be plain old 
dumb text. :)
  
  
  This patch actually solves the problem specified on bug title, "libinput 
pointer kcm needs 11 ticks on the speed slider so that the middle one can 
correspond to 0.0". Still you think that it doesn't solve the bug ?
  
  > Also, it seems that this is dependent on D13573 
. So please also add `Depends on D13573` to 
the Summary section somewhere. Then do `arc amend` locally. Thanks!
  
  D13573  patch is for Touchpad KCM but 
this patch is for Mouse KCM There is a confusion  So I'm going to apply the 
same patch for Touchpad KCM too. Same issue, same solution.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13672

To: furkantokac, ngraham, romangg, #plasma, mart
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13672: Mouse KCM Pointer Speed Slider Improvement

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  `BUG: 395681` can't be a link, I don't think. It's gotta just be plain old 
dumb text. :) Also, it seems that this is dependent on D13573 
. So please also add `Depends on D13573` to 
the Summary section somewhere. Then do `arc amend` locally. Thanks!
  
  And don't push until the dependent revision is landed, obviously.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13672

To: furkantokac, ngraham, romangg, #plasma, mart
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13672: Mouse KCM Pointer Speed Slider Improvement

[Furkan Tokac]

furkantokac created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
furkantokac requested review of this revision.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13672

AFFECTED FILES
  kcms/mouse/kcm/libinput/main.qml
  kcms/mouse/kcm/libinput/main_deviceless.qml

To: furkantokac
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart