D13881: oxygen-demo : add KMessage preview

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit R113:ad3cddb5954e: Fix the KDE4 build of the oxygen-demo (authored by rjvbb). CHANGED PRIOR TO COMMIT

D13881: oxygen-demo : add KMessage preview

lbeltrame reopened this revision. lbeltrame added a comment. This breaks when building the Oxygen style for Qt4 (which is still a supported build option AFAIK): [ 73s] /home/abuild/rpmbuild/BUILD/oxygen-5.6.90git/kstyle/demo/oxygenframedemowidget.cpp:33:10: fatal error:

D13881: oxygen-demo : add KMessage preview

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R113:d299d6ebc195: add KMessage preview to the demo (authored by rjvbb). CHANGED PRIOR TO COMMIT

D13881: oxygen-demo : add KMessage preview

GB_2 added a comment. Looks fine IMO. REPOSITORY R113 Oxygen Theme REVISION DETAIL https://phabricator.kde.org/D13881 To: rjvbb, #vdg, plasma-devel Cc: GB_2, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, himcesjf,

D13881: oxygen-demo : add KMessage preview

hpereiradacosta added a comment. In D13881#286998 , @rjvbb wrote: > A couple of snapshot (with my current KMessageWidget facelift; styles and themes switched "on-the-fly"): > > Oxygen with the Oxygen theme: > F6014853: image.png

D13881: oxygen-demo : add KMessage preview

rjvbb marked 3 inline comments as done. rjvbb added a comment. Ping? REPOSITORY R113 Oxygen Theme REVISION DETAIL https://phabricator.kde.org/D13881 To: rjvbb, hpereiradacosta Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D13881: oxygen-demo : add KMessage preview

rjvbb added a comment. A couple of snapshot (with my current KMessageWidget facelift; styles and themes switched "on-the-fly"): Oxygen with the Oxygen theme: F6014853: image.png Breeze with Breeze-Dark: F6014872: image.png

D13881: oxygen-demo : add KMessage preview

rjvbb updated this revision to Diff 37155. rjvbb added a comment. Updated as (hopefully) requested. I've left the property change event filter, for builds against older than 5.48.0 (or whatever version D13884 will appear in). There is one

D13881: oxygen-demo : add KMessage preview

broulik added a comment. D13884 fixes that. It doesn't set a custom palette but a custom style sheet on the `QFrame` (where you apparently can't style the hyperlink color for labels inside :/) REPOSITORY R113 Oxygen Theme REVISION DETAIL

D13881: oxygen-demo : add KMessage preview

hpereiradacosta added a comment. In D13881#286869 , @broulik wrote: > > 1/ As far as I know, the widget style has no way to style these widgets. Correct ? > > Yes. I would have preferred if Breeze applied the new flat style to the widget

D13881: oxygen-demo : add KMessage preview

broulik added a comment. > 1/ As far as I know, the widget style has no way to style these widgets. Correct ? Yes. I would have preferred if Breeze applied the new flat style to the widget instead of changing the look in the class itself. > As such I wonder if oxygen-demo is the

D13881: oxygen-demo : add KMessage preview

broulik added inline comments. INLINE COMMENTS > rjvbb wrote in oxygenframedemowidget.cpp:90 > That's to catch the event sent to the qApp instance when the theme is changed > (to be exact: after KColorSchemeManager sets or changes the > `KDE_COLOR_SCHEME_PATH` property. > > Without this, the

D13881: oxygen-demo : add KMessage preview

hpereiradacosta added a comment. 1/ As far as I know, the widget style has no way to style these widgets. Correct ? As such I wonder if oxygen-demo is the right place for showing this. Might better have a showcase in kwidgetsaddon. (but in fact we also discussed that ultimately

D13881: oxygen-demo : add KMessage preview

rjvbb added inline comments. INLINE COMMENTS > broulik wrote in oxygenframedemowidget.cpp:90 > What do you need this for? That's to catch the event sent to the qApp instance when the theme is changed (to be exact: after KColorSchemeManager sets or changes the `KDE_COLOR_SCHEME_PATH` property.

D13881: oxygen-demo : add KMessage preview

broulik added a comment. +1 INLINE COMMENTS > oxygenframedemowidget.cpp:90 > +{ > +if (event->type() == QEvent::DynamicPropertyChange && obj == qApp) { > +QDynamicPropertyChangeEvent *e = > dynamic_cast(event); What do you need this for? REPOSITORY R113 Oxygen

D13881: oxygen-demo : add KMessage preview

rjvbb created this revision. rjvbb added a reviewer: hpereiradacosta. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. rjvbb requested review of this revision. REVISION SUMMARY A recent change to the `KMessageWidget` look has caught my