D13988: Use subseq matching for service runner

[Nathaniel Graham]

ngraham closed this revision.
ngraham added a comment.


  Manually merged because `arc land` doesn't seem to want to work anymore. You 
can see it at 
//invent.kde.org/plasma/plasma-workspace/commit/9f2abd0a54d51d9234a5a9489d1342b261429fa3.
  
  Thanks Michael!

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D13988

To: michaeleden, rthomas, #plasma_workspaces, #plasma, broulik, ngraham
Cc: meven, justinzobel, cfeck, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D13988: Use subseq matching for service runner

[Nathaniel Graham]

ngraham added a comment.


  Still applies cleanly and seems to fix the bug. Landing.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  feat/app-name-subseq

REVISION DETAIL
  https://phabricator.kde.org/D13988

To: michaeleden, rthomas, #plasma_workspaces, #plasma, broulik, ngraham
Cc: meven, justinzobel, cfeck, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D13988: Use subseq matching for service runner

[Méven Car]

meven added a comment.


  There no blockers anymore, providing there no conflict, we could land this 
as-is.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  feat/app-name-subseq

REVISION DETAIL
  https://phabricator.kde.org/D13988

To: michaeleden, rthomas, #plasma_workspaces, #plasma, broulik, ngraham
Cc: meven, justinzobel, cfeck, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D13988: Use subseq matching for service runner

[Justin Zobel]

justinzobel added a comment.


  Can we please move this to  and rebase? 
https://invent.kde.org/plasma/plasma-workspace/-/merge_requests

REPOSITORY
  R120 Plasma Workspace

BRANCH
  feat/app-name-subseq

REVISION DETAIL
  https://phabricator.kde.org/D13988

To: michaeleden, rthomas, #plasma_workspaces, #plasma, broulik, ngraham
Cc: justinzobel, cfeck, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D13988: Use subseq matching for service runner

[Kai Uwe Broulik]

broulik added a comment.


  Apparently you have to tell sysadmin two weeks in advance. [1]
  
  [1] https://mail.kde.org/pipermail/plasma-devel/2018-August/087983.html

REPOSITORY
  R120 Plasma Workspace

BRANCH
  feat/app-name-subseq

REVISION DETAIL
  https://phabricator.kde.org/D13988

To: michaeleden, rthomas, #plasma_workspaces, #plasma, broulik, ngraham
Cc: cfeck, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13988: Use subseq matching for service runner

[Michael Eden]

michaeleden added a comment.


  @broulik thanks, will do!

REPOSITORY
  R120 Plasma Workspace

BRANCH
  feat/app-name-subseq

REVISION DETAIL
  https://phabricator.kde.org/D13988

To: michaeleden, rthomas, #plasma_workspaces, #plasma, broulik, ngraham
Cc: cfeck, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13988: Use subseq matching for service runner

[Kai Uwe Broulik]

broulik added a comment.


  Please only change dependency to a released version otherwise this will break 
the build for everyone. Feel free to bump to 5.49 once it's released (next 
week?)

REPOSITORY
  R120 Plasma Workspace

BRANCH
  feat/app-name-subseq

REVISION DETAIL
  https://phabricator.kde.org/D13988

To: michaeleden, rthomas, #plasma_workspaces, #plasma, broulik, ngraham
Cc: cfeck, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13988: Use subseq matching for service runner

[Michael Eden]

michaeleden added a comment.


  @ngraham cool! So I should change the deps for KF 5.50 unless someone else 
disagrees?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  feat/app-name-subseq

REVISION DETAIL
  https://phabricator.kde.org/D13988

To: michaeleden, rthomas, #plasma_workspaces, #plasma, broulik, ngraham
Cc: cfeck, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13988: Use subseq matching for service runner

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Fantastic. This works great for me, but let's get some more opinions too.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  feat/app-name-subseq

REVISION DETAIL
  https://phabricator.kde.org/D13988

To: michaeleden, rthomas, #plasma_workspaces, #plasma, broulik, ngraham
Cc: cfeck, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13988: Use subseq matching for service runner

[Christoph Feck]

cfeck added a comment.


  According to https://community.kde.org/Schedules/Plasma_5 the Plasma 5.14 
release is planned to depend on Frameworks 5.50.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D13988

To: michaeleden, rthomas, #plasma_workspaces, #plasma, broulik
Cc: cfeck, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13988: Use subseq matching for service runner

[Nathaniel Graham]

ngraham added a comment.


  Nah, let's wait. We'll have to see what the dependency plans are for Plasma; 
I'm not sure whether or not we'll be depending on Frameworks 5.49 for Plasma 
5.14. Might wanna ask one of the #plasma 
 folks.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D13988

To: michaeleden, rthomas, #plasma_workspaces, #plasma, broulik
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13988: Use subseq matching for service runner

[Michael Eden]

michaeleden added a comment.


  @ngraham this didn't make it into 5.48 but it did make it into the commit 
after that. Should I put 5.49 even though its not tagged yet?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D13988

To: michaeleden, rthomas, #plasma_workspaces, #plasma, broulik
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13988: Use subseq matching for service runner

[Nathaniel Graham]

ngraham added a comment.


  `plasma-workspace` does compile without D13670 
 and KRunner //seems// to work, but it 
gives me a whole lotta console spew:
  
kf5.kservice.services: Parsing "exist Exec and ( (exist Keywords and 
'scover' ~subin Keywords) or (exist GenericName and 'scover' ~subseq 
GenericName) or (exist Name and 'scover' ~subseq Name) or ('scover' ~subseq 
Exec) or (exist Comment and 'scover' ~subseq Comment) )" gave: syntax error
  
  We should probably bump the KF5 version requirement in `CMakeLists.txt` here 
to require 5.48.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D13988

To: michaeleden, rthomas, #plasma_workspaces, #plasma, broulik
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13988: Use subseq matching for service runner

[Nathaniel Graham]

ngraham added reviewers: Plasma, broulik.
ngraham added a comment.


  > This fixes B262837 (how do you show this in phab?) and relies on D13670 

  
  Like so: :)
  
BUG: 262837

Depends on D13670
  
  See https://community.kde.org/Infrastructure/Phabricator#Add_special_keywords
  
  After you change the Summary section using the web interface, you'll need to 
run `arc amend` to pull down that change into your local branch.
  
  Thanks a lot for the patch, BTW! This will be a nice improvement.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D13988

To: michaeleden, rthomas, #plasma_workspaces, #plasma, broulik
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13988: Use subseq matching for service runner

[Michael Eden]

michaeleden created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
michaeleden requested review of this revision.

REVISION SUMMARY
  This changes krunner to use sub-sequence matching fixing bug 262837.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  feat/app-name-subseq

REVISION DETAIL
  https://phabricator.kde.org/D13988

AFFECTED FILES
  runners/services/servicerunner.cpp

To: michaeleden
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart