filipf added a comment.
Hi, this patch triggered a bug in icon view:
https://bugs.kde.org/show_bug.cgi?id=400876
I've confirmed the bug can't be reproduced when these lines are removed.
REPOSITORY
R124 System Settings
REVISION DETAIL
https://phabricator.kde.org/D14581
To: mart,
This revision was automatically updated to reflect the committed changes.
Closed by commit R124:a079df6a5e3f: support for multilevel kcms (authored by
mart).
REPOSITORY
R124 System Settings
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D14581?vs=40627=43281
REVISION DETAIL
mart updated this revision to Diff 40627.
mart added a comment.
- remove old remains of extra layouts
REPOSITORY
R124 System Settings
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D14581?vs=40502=40627
BRANCH
arcpatch-D14581
REVISION DETAIL
davidedmundson added inline comments.
INLINE COMMENTS
> ModuleView.cpp:178
> // Create the scroller
> +QWidget *mainWidget = new QWidget( this );
> +QVBoxLayout *layout = new QVBoxLayout( mainWidget );
why?
> ModuleView.cpp:225
> page->setIcon( QIcon::fromTheme(
mart updated this revision to Diff 40502.
mart added a comment.
- use the new api KPageWidgetItem::setHeaderVisible
REPOSITORY
R124 System Settings
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D14581?vs=39312=40502
BRANCH
arcpatch-D14581
REVISION DETAIL
abetts added a comment.
Looking great!
REPOSITORY
R124 System Settings
REVISION DETAIL
https://phabricator.kde.org/D14581
To: mart, #plasma, #vdg
Cc: abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,
jensreuterberg, sebas, apol, mart
