D14695: disable title for QML kcms

2018-08-28 Thread David Edmundson
davidedmundson requested changes to this revision. davidedmundson added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > main.cpp:309 > +if (module && module->realModule()->inherits("KCModuleQml")) { > +page->setHeaderVisible(false); > +

D14695: disable title for QML kcms

2018-08-27 Thread Marco Martin
mart updated this revision to Diff 40503. mart added a comment. - use setHeaderVisible REPOSITORY R126 KDE CLI Utilities CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14695?vs=39318=40503 BRANCH arcpatch-D14695 REVISION DETAIL https://phabricator.kde.org/D14695 AFFECTED

D14695: disable title for QML kcms

2018-08-08 Thread Marco Martin
mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY QML kcms do their own title TEST PLAN launched both qwidget and QML