D15233: Add a tooltip for the appentry in the kicker

2018-11-23 Thread Marco Martin 
mart added a comment.


  In D15233#328690 , @alexeymin 
wrote:
  
  > Why isn't repository for this review set? Which repo should it be?
  >
  > P.S. Guess it is plasma desktop
  >  P.P.S. I edited and set a repo, but still don't see it assigned in diff 
detail...
  
  
  yeah, phab kindof requires the arcanist tool to be used to have things 
correct..

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D15233

To: underwit, #plasma, hein, broulik, davidedmundson
Cc: mart, alexeymin, abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol

D15233: Add a tooltip for the appentry in the kicker

2018-09-20 Thread Alexey Min 
alexeymin added a comment.


  Why isn't repository for this review set? Which repo it should be?

REVISION DETAIL
  https://phabricator.kde.org/D15233

To: underwit, #plasma
Cc: alexeymin, abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D15233: Add a tooltip for the appentry in the kicker

2018-09-20 Thread Ivan Razzhivin 
underwit added a comment.


  Hello! There is a chance that my patch will be apply?

REVISION DETAIL
  https://phabricator.kde.org/D15233

To: underwit, #plasma
Cc: abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D15233: Add a tooltip for the appentry in the kicker

2018-09-05 Thread Andres Betts 
abetts added a comment.


  In D15233#320616 , @underwit wrote:
  
  > Screenshot with tooltip
  >  F6236529: Screenshot_20180905_105259.png 

  >
  > For tooltip i use "comment", "genericname" or "name" from .desktop file
  
  
  Thank you

REVISION DETAIL
  https://phabricator.kde.org/D15233

To: underwit, #plasma
Cc: abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D15233: Add a tooltip for the appentry in the kicker

2018-09-05 Thread Ivan Razzhivin 
underwit added a comment.


  Screenshot with tooltip
  F6236529: Screenshot_20180905_105259.png 


REVISION DETAIL
  https://phabricator.kde.org/D15233

To: underwit, #plasma
Cc: abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D15233: Add a tooltip for the appentry in the kicker

2018-09-05 Thread Ivan Razzhivin 
underwit updated this revision to Diff 41027.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15233?vs=40896=41027

REVISION DETAIL
  https://phabricator.kde.org/D15233

AFFECTED FILES
  applets/kicker/package/contents/ui/ItemListDelegate.qml
  applets/kicker/plugin/abstractentry.cpp
  applets/kicker/plugin/abstractentry.h
  applets/kicker/plugin/abstractmodel.cpp
  applets/kicker/plugin/actionlist.h
  applets/kicker/plugin/appentry.cpp
  applets/kicker/plugin/appentry.h
  applets/kicker/plugin/appsmodel.cpp

To: underwit, #plasma
Cc: abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D15233: Add a tooltip for the appentry in the kicker

2018-09-04 Thread Andres Betts 
abetts added a comment.


  What would this look like?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D15233

To: underwit, #plasma
Cc: abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D15233: Add a tooltip for the appentry in the kicker

2018-09-03 Thread Ivan Razzhivin 
underwit created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
underwit requested review of this revision.

REVISION SUMMARY
  Hello!
  My improvement shows a tooltip for applications in ther kicker menu.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D15233

AFFECTED FILES
  applets/kicker/package/contents/ui/ItemListDelegate.qml
  applets/kicker/plugin/abstractentry.cpp
  applets/kicker/plugin/abstractentry.h
  applets/kicker/plugin/abstractmodel.cpp
  applets/kicker/plugin/actionlist.h
  applets/kicker/plugin/appentry.cpp
  applets/kicker/plugin/appentry.h
  applets/kicker/plugin/appsmodel.cpp

To: underwit
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart