D15644: Bug 395349

2018-09-21 Thread Andrew Crouthamel
acrouthamel added a comment. Yeah I think that is a mistake. D42047 which precedes the current diff, makes much more sense. REVISION DETAIL https://phabricator.kde.org/D15644 To: lsartorelli, ngraham, #plasma, #frameworks Cc: acrouthamel, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, les

D15644: Bug 395349

2018-09-21 Thread Nathaniel Graham
ngraham requested changes to this revision. ngraham added reviewers: Plasma, Frameworks. ngraham added a comment. This revision now requires changes to proceed. Thank you for the patch! I see that this is your first KDE contribution, how exciting! This needs some work, so please don't get disc

D15644: Bug 395349

2018-09-21 Thread Luca Sartorelli
lsartorelli updated this revision to Diff 42048. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15644?vs=42047&id=42048 REVISION DETAIL https://phabricator.kde.org/D15644 AFFECTED FILES gui/ksysguard.cpp To: lsartorelli Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mo

D15644: Bug 395349

2018-09-21 Thread Luca Sartorelli
lsartorelli created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. lsartorelli requested review of this revision. REVISION SUMMARY Provide option to hide menu bar for Ksysguard REPOSITORY R106 KSysguard BRANCH master REVISION DETAIL https://phabr