D15696: Fix qmake build

2018-09-28 Thread Ilya Bizyaev 
IlyaBizyaev closed this revision.
IlyaBizyaev added a comment.


  Closed by 8691651c1f0d09430416ba5fe2130647554b06a9 


REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D15696

To: IlyaBizyaev, mart
Cc: alexeymin, plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D15696: Fix qmake build

2018-09-22 Thread Ilya Bizyaev 
IlyaBizyaev added a comment.


  I'm not sure... You can try building a Kirigami application that uses 
Kirigami as a qmake submodule, like Kaidan 
.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D15696

To: IlyaBizyaev, mart
Cc: alexeymin, plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D15696: Fix qmake build

2018-09-22 Thread Alexey Min 
alexeymin added a comment.


  How can I reproduce broken build? Any test plan?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D15696

To: IlyaBizyaev, mart
Cc: alexeymin, plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D15696: Fix qmake build

2018-09-22 Thread Ilya Bizyaev 
IlyaBizyaev updated this revision to Diff 42145.
IlyaBizyaev edited the summary of this revision.
IlyaBizyaev added a comment.


  Indeed, thanks @alexeymin!

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15696?vs=42142=42145

REVISION DETAIL
  https://phabricator.kde.org/D15696

AFFECTED FILES
  kirigami.pri
  kirigami.pro

To: IlyaBizyaev, mart
Cc: alexeymin, plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D15696: Fix qmake build

2018-09-22 Thread Alexey Min 
alexeymin added a comment.


  Maybe add it to .pro file too then?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D15696

To: IlyaBizyaev, mart
Cc: alexeymin, plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D15696: Fix qmake build

2018-09-22 Thread Ilya Bizyaev 
IlyaBizyaev created this revision.
IlyaBizyaev added a reviewer: mart.
IlyaBizyaev added a project: Kirigami.
Herald added a subscriber: plasma-devel.
IlyaBizyaev requested review of this revision.

REVISION SUMMARY
  Add scenepositionattached.* to the qmake project file

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D15696

AFFECTED FILES
  kirigami.pri

To: IlyaBizyaev, mart
Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein