D16988: [Kickoff] Make the visible search field unfocused by default

davidedmundson added a comment. > Seeing as this causes the latest plasmashell to lock up Can you expand on this? What locks up? I had a bug report this week of a guy who had kickoff locking up on pressing tab REPOSITORY R119 Plasma Desktop REVISION DETAIL

D16988: [Kickoff] Make the visible search field unfocused by default

rooty abandoned this revision. rooty added a comment. Seeing as this causes the latest plasmashell to lock up and I was never too enthusiastic about the change either, I'm going to close this, sorry guys. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D16988

D16988: [Kickoff] Make the visible search field unfocused by default

rooty added a comment. In D16988#367971 , @filipf wrote: > In D16988#367970 , @rooty wrote: > > > Suffice it to say, you can't use any of the other patches (except the font size / label change)

D16988: [Kickoff] Make the visible search field unfocused by default

filipf added a comment. In D16988#367970 , @rooty wrote: > Suffice it to say, you can't use any of the other patches (except the font size / label change) without this one. Separating this doesn't make sense either because there's no

D16988: [Kickoff] Make the visible search field unfocused by default

rooty added a comment. In D16988#366146 , @ngraham wrote: > D17020 , D17022 , and D17023 still include duplicated changes from this

D16988: [Kickoff] Make the visible search field unfocused by default

ngraham added a comment. D17020 , D17022 , and D17023 still include duplicated changes from this patch. The idea was to make all of your Kickoff patches independent of each

D16988: [Kickoff] Make the visible search field unfocused by default

mart added a comment. In D16988#361739 , @filipf wrote: > It also conceptually makes more sense to have the search field unfocused because searching is not necessarily the main activity done within Kickoff, so why have it in focus all the time?

D16988: [Kickoff] Make the visible search field unfocused by default

mart requested changes to this revision. mart added a comment. This revision now requires changes to proceed. this breaks the workflow open menu and just start typing REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D16988 To: rooty, #plasma, #vdg, romangg,

D16988: [Kickoff] Make the visible search field unfocused by default

rooty updated this revision to Diff 45820. rooty added a comment. - [Kickoff] Make search field unfocused but visible REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16988?vs=45757=45820 BRANCH kickoff-visible-and-unfocused (branched from master)

D16988: [Kickoff] Make the visible search field unfocused by default

rooty added a comment. Thanks! Ironically, I do like it focused too 藍 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D16988 To: rooty, #plasma, #vdg, romangg, ngraham, davidedmundson Cc: abetts, gladhorn, chempfling, filipf, plasma-devel, ragreen, Pitel,

D16988: [Kickoff] Make the visible search field unfocused by default

ngraham added a comment. Cool, I'm looking forward to most of these changes. And you may yet convince me on the visually-unfocused-search-field-by-default thing. :) Here's the documentation for creating a dependency chain of patches:

D16988: [Kickoff] Make the visible search field unfocused by default

abetts added a comment. +1 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D16988 To: rooty, #plasma, #vdg, romangg, ngraham, davidedmundson Cc: abetts, gladhorn, chempfling, filipf, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D16988: [Kickoff] Make the visible search field unfocused by default

rooty added a comment. > You can do this as you see fit. I would recommend though in this case to make a patch series where patches depend on each other since otherwise it can become difficult to keep all the independent patches consistent with each other. Excellent. > I believe in

D16988: [Kickoff] Make the visible search field unfocused by default

romangg added a comment. In D16988#362323 , @rooty wrote: > Clipboard works like this but the coding is beyond my abilities. Krunner does this too except it opens up with the search field in focus. This Kickoff patched version can't do that,

D16988: [Kickoff] Make the visible search field unfocused by default

rooty added a comment. In D16988#362281 , @romangg wrote: > I like all the changes, but they should go into separate patches: Patches that would patch this patch or patches that would each patch master separately? REPOSITORY R119

D16988: [Kickoff] Make the visible search field unfocused by default

rooty added a comment. > Why does it make it easy? Sorry I have no idea what I was thinking when I wrote that. It doesn't. (I think my point was that it works regardless of the focus being drawn away from it?) > - By default search field looks unactivated but has focus. Arrow

D16988: [Kickoff] Make the visible search field unfocused by default

romangg added a comment. In D16988#362160 , @rooty wrote: > (1) Kicker takes the focus off the search field when you go through the results by either mouse or keyboard. This makes it easy to go back to the search field by typing or using the

D16988: [Kickoff] Make the visible search field unfocused by default

romangg added a comment. I like all the changes, but they should go into separate patches: > (1) Keeps the search field visible by default but leaves it unfocused until triggered by the keyboard Patch 1 > (2) Enables the tab key to select/focus the search field just like any

D16988: [Kickoff] Make the visible search field unfocused by default

rooty added a comment. In D16988#362206 , @chempfling wrote: > In D16988#362160 , @rooty wrote: > > > Okay so from what I can tell: > > > > (1) Kicker takes the focus off the search field when

D16988: [Kickoff] Make the visible search field unfocused by default

chempfling added a comment. In D16988#362160 , @rooty wrote: > Okay so from what I can tell: > > (1) Kicker takes the focus off the search field when you go through the results by either mouse or keyboard. This makes it easy to go back to

D16988: [Kickoff] Make the visible search field unfocused by default

rooty added a comment. Okay so from what I can tell: (1) Kicker takes the focus off the search field when you go through the results by either mouse or keyboard. This makes it easy to go back to the search field by typing or using the arrow keys (to add more words etc.) (2) Krunner

D16988: [Kickoff] Make the visible search field unfocused by default

gladhorn added a comment. In D16988#362104 , @rooty wrote: > @gladhorn More food for thought by the way: in this patch (and the master) the search field is focused while searching and while navigating the search results - it still accepts input

D16988: [Kickoff] Make the visible search field unfocused by default

rooty added a comment. @gladhorn More food for though, by the way: in this patch (and the master) the search field is focused while searching and while navigating the search results - it still accepts input even though you've technically navigated away from it. Should this functionality be

D16988: [Kickoff] Make the visible search field unfocused by default

rooty added a comment. > Actually this sounds like it might help our cause. Especially when the search bar can be tabbed into, that's really nice. The problem is that we would like to focus to be on the selected item, such as the one that gets launched when pressing enter. The search should

D16988: [Kickoff] Make the visible search field unfocused by default

gladhorn added a comment. In D16988#361980 , @ngraham wrote: > There are a lot of good changes in here, like those keyboard navigation improvements! And I appreciate all the work that clearly went into this. However, the problem with huge

D16988: [Kickoff] Make the visible search field unfocused by default

rooty added a comment. > Right, I agree. In fact, that's how Kicker does it: the search field is focused by default, but if you mouse over a list item, then focus visually moves to the list. I'm supportive of doing that sort of thing here. Then the Kicker and Kickoff search fields would

D16988: [Kickoff] Make the visible search field unfocused by default

rooty added a comment. > And I'm afraid I don't think we can do #1. @chempfling and @gladhorn have been working hard to push on accessibility, and one thing I've learned in the past week weeks is how important focus is. Making sure that the active element both has and looks like it has

D16988: [Kickoff] Make the visible search field unfocused by default

ngraham added a comment. In D16988#362025 , @filipf wrote: > Hmm but it doesn't even need to be primarily argumented as a visual improvement. Can't we approach the focused/unfocused matters contextually? If I'm using Kickoff mostly to click on

D16988: [Kickoff] Make the visible search field unfocused by default

filipf added a comment. In D16988#361980 , @ngraham wrote: > And I'm afraid I don't think we can do #1. @chempfling and @gladhorn have been working hard to push on accessibility, and one thing I've learned in the past week weeks is how

D16988: [Kickoff] Make the visible search field unfocused by default

ngraham requested changes to this revision. ngraham added subscribers: chempfling, gladhorn. ngraham added a comment. This revision now requires changes to proceed. There are a lot of good changes in here, like those keyboard navigation improvements! And I appreciate all the work that clearly

D16988: [Kickoff] Make the visible search field unfocused by default

rooty updated this revision to Diff 45757. rooty added a comment. - Trim unnecessary code REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16988?vs=45753=45757 BRANCH kickoff-visible-and-unfocused (branched from master) REVISION DETAIL

D16988: [Kickoff] Make the visible search field unfocused by default

filipf added a comment. I cannot comment on the technical side of things (noob), and am perhaps a little biased since Root and I are best friends who have been working (mostly him) on Kickoff this weekend as our first real contribution to KDE, however... this change can really do wonders

D16988: [Kickoff] Make the visible search field unfocused by default

rooty updated this revision to Diff 45753. rooty added a comment. - Fix broken states and return ability to hover REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16988?vs=45751=45753 BRANCH kickoff-visible-and-unfocused (branched from master)

D16988: [Kickoff] Make the visible search field unfocused by default

rooty updated this revision to Diff 45751. rooty added a comment. - Tidy up some more REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16988?vs=45750=45751 BRANCH kickoff-visible-and-unfocused (branched from master) REVISION DETAIL

D16988: [Kickoff] Make the visible search field unfocused by default

rooty updated this revision to Diff 45750. rooty added a comment. - Remove unnecessary states, tidy things up REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16988?vs=45747=45750 BRANCH kickoff-visible-and-unfocused (branched from master)

D16988: [Kickoff] Make the visible search field unfocused by default

rooty created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. rooty requested review of this revision. REVISION SUMMARY Changes: applets/kickoff/package/contents/ui/Header.qml This patch: (1) Keeps the search field visible by default but leaves it