D17034: [Kickoff] Fix bad kerning in tab labels

filipf abandoned this revision. filipf added a comment. In D17034#363098 , @ngraham wrote: > FWIW, we already conditionally switch to using QtRendering when using a fractional scale factor throughout the PlasmaComponents library. So there is

D17034: [Kickoff] Fix bad kerning in tab labels

ngraham added a comment. FWIW, we already conditionally switch to using QtRendering when using a fractional scale factor throughout the PlasmaComponents library. So there is already a precedent for sometimes using a different renderer to work around visual bugs, and so far it has been much

D17034: [Kickoff] Fix bad kerning in tab labels

filipf added a comment. In D17034#362807 , @rooty wrote: > Also it's hardly random, it's specifically targeted at a label or a //single// portion of the UI that's affected by this gravely and consistently. Yes, I just logged in and out

D17034: [Kickoff] Fix bad kerning in tab labels

rooty added a comment. In D17034#362808 , @broulik wrote: > > The notifications widget also forces NativeRendering in one of its components rather than leave it open for discussion. > > It does because it's using a `TextEdit` directly to

D17034: [Kickoff] Fix bad kerning in tab labels

broulik added a comment. > The notifications widget also forces NativeRendering in one of its components rather than leave it open for discussion. It does because it's using a `TextEdit` directly to make text selectable rather than a full `TextArea` which would set this automatically

D17034: [Kickoff] Fix bad kerning in tab labels

rooty added a comment. In D17034#362786 , @hein wrote: > This isn't an acceptable patch, sorry - we can't just randomly sprinkle a different font rasterizer into the UI. The rasterization should be consistent throughout the system and

D17034: [Kickoff] Fix bad kerning in tab labels

hein added a comment. Thanks, that should probably be reverted, although there might have been some reason I'm unaware of in that case since it also sets the font style to outline rendering. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17034 To: filipf,

D17034: [Kickoff] Fix bad kerning in tab labels

filipf added a comment. In D17034#362786 , @hein wrote: > we can't just randomly sprinkle a different font rasterizer into the UI. Someone's already done this though. Check line 32 on the left here:

D17034: [Kickoff] Fix bad kerning in tab labels

hein requested changes to this revision. hein added a comment. This revision now requires changes to proceed. This isn't an acceptable patch, sorry - we can't just randomly sprinkle a different font rasterizer into the UI. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D17034: [Kickoff] Fix bad kerning in tab labels

broulik added a comment. Widget explorer also shows this behavior, however this is more a problem of the labels being not aligned to a pixel grid rather than `NativeRendering` REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17034 To: filipf, ngraham, #vdg,

D17034: [Kickoff] Fix bad kerning in tab labels

filipf added a comment. In D17034#362739 , @rooty wrote: > > This is actually pretty neat considering Kickoff and Notifications are the only two widgets where this is a noticeable problem. And the icons on the desktop (not a

D17034: [Kickoff] Fix bad kerning in tab labels

rooty added a comment. (LOL I accidentally removed the comment) NativeRendering really is the gift that keeps on giving. F6432908: nativerendering.png QtRendering renders a lot better. F6432910: qtrendering.png

D17034: [Kickoff] Fix bad kerning in tab labels

rooty added a comment. NativeRendering truly is the gift that keeps on giving F6432893: nativerendering.png This is what happens if I specify that JobDetailsItem.qml use QtRendering F6432899: qtrendering.png

D17034: [Kickoff] Fix bad kerning in tab labels

rooty added a comment. this has been bugging me/us for years, glad you finally decided to patch it :D REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17034 To: filipf, ngraham, #vdg, #plasma Cc: rooty, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D17034: [Kickoff] Fix bad kerning in tab labels

filipf added a comment. **Explanation:** Kerning refers to the spacing between letters in text. It's important to get it right because otherwise the UI can look unprofessional (and ugly). Currently there is a QML bug that renders all

D17034: [Kickoff] Fix bad kerning in tab labels

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY This patch explicitly sets the QML text rendering variable for Kickoff tab labels as QtRendering. The effect is that the tab labels