D17152: Hide the badge if number too big

2018-11-26 Thread Sune Vuorela
svuorela added a subscriber: mlaurent. svuorela added a comment. Let's try poke @mlaurent and see if he has any comments. I still think it is mostly a visualization issue. the mail client just tells what it knows. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D17152: Hide the badge if number too big

2018-11-26 Thread Nathaniel Graham
ngraham added a comment. FWIW after talking to some KMail developers in the #plasma IRC channel, we came up with a few bug reports that might help you: - https://bugs.kde.org/show_bug.cgi?id=401443 - https://bugs.kde.org/show_bug.cgi?id=401444

D17152: Hide the badge if number too big

2018-11-26 Thread Nathaniel Graham
ngraham added a comment. I did. My proposal is something a bit different: an option to have KMail only look at the inbox for the purpose of determining the unread count to report to Plasma. I do see how this would be only marginally useful for you if you have 5,000 unread emails in your

D17152: Hide the badge if number too big

2018-11-26 Thread Sune Vuorela
svuorela added a comment. In D17152#366536 , @ngraham wrote: > What I'm saying is that I think it makes more sense to communicate your preferred email workflow to KMail rather then to Plasma. I'm open to being convinced out of this point of

D17152: Hide the badge if number too big

2018-11-26 Thread Nathaniel Graham
ngraham added a comment. In D17152#366535 , @svuorela wrote: > In D17152#366525 , @ngraham wrote: > > > > > > > > > I feel like this patch trying to work around a problem in either your

D17152: Hide the badge if number too big

2018-11-26 Thread Sune Vuorela
svuorela added a comment. In D17152#366525 , @ngraham wrote: > > I feel like this patch trying to work around a problem in either your workflow Is plasma seriously going to try to dictate my email workflow? > Maybe 1000

D17152: Hide the badge if number too big

2018-11-26 Thread Nathaniel Graham
ngraham added a comment. In D17152#366524 , @svuorela wrote: > In D17152#366495 , @anthonyfieroni wrote: > > > So i like second one, it can still be fixed to 10K+ because it does not matter above.

D17152: Hide the badge if number too big

2018-11-26 Thread Sune Vuorela
svuorela added a comment. In D17152#366495 , @anthonyfieroni wrote: > So i like second one, it can still be fixed to 10K+ because it does not matter above. I'm still unsure what I as a user should use the number for ? It is not like

D17152: Hide the badge if number too big

2018-11-26 Thread Anthony Fieroni
anthonyfieroni added a comment. So i like second one, it can still be fixed to 10K+ because it does not matter above. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17152 To: svuorela, #plasma, hein, broulik, #vdg, ngraham Cc: anthonyfieroni, fabianr,

D17152: Hide the badge if number too big

2018-11-26 Thread Sune Vuorela
svuorela added a comment. F6442734: image.png is just with a + F6442738: image.png is around current code F6442740: image.png is this proposal I'll try with + for a

D17152: Hide the badge if number too big

2018-11-26 Thread Sune Vuorela
svuorela added a comment. @ngraham I use kmail ... but I have hundreds of thousands unread emails without counting my spam folders. (commit lists, bug lists, ...) @anthonyfieroni I think that doesn't convey any actual information. "You have a lot of unread emails and doesn't use the

D17152: Hide the badge if number too big

2018-11-26 Thread Nathaniel Graham
ngraham added a comment. +1 from me too for 9k+, 10k+, 11k+, etc REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17152 To: svuorela, #plasma, hein, broulik, #vdg, ngraham Cc: anthonyfieroni, fabianr, ndavis, ngraham, plasma-devel, ragreen, Pitel, ZrenBot,

D17152: Hide the badge if number too big

2018-11-26 Thread Anthony Fieroni
anthonyfieroni added a comment. In D17152#365975 , @ndavis wrote: > Why not abbreviate the number? Instead of using "9,999+" for 11000, use "11K". I like the idea, 10K+, 11K+, (badgeRect.number / 1000) REPOSITORY R119 Plasma Desktop

D17152: Hide the badge if number too big

2018-11-25 Thread Nathaniel Graham
ngraham added a comment. In D17152#365985 , @svuorela wrote: > I have a couple of hundred thousand unread emails + the emails in my spamfolder which is another hundred thousand. Having such an indicator in this case is just .. useless.

D17152: Hide the badge if number too big

2018-11-25 Thread Sune Vuorela
svuorela added a comment. @ngraham It might be that many notifications != no notifications in some cases, but at least in the case of emails, with many unread emails basically doesn't make a difference. I have a coulpe of hundred thousand unread emails + the emails in my spamfolder

D17152: Hide the badge if number too big

2018-11-25 Thread Noah Davis
ndavis added a comment. Why not abbreviate the number and round the abbreviated number instead? Instead of using "9,999+" for 11000, use "11K". REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17152 To: svuorela, #plasma, hein, broulik, #vdg, ngraham Cc:

D17152: Hide the badge if number too big

2018-11-25 Thread Nathaniel Graham
ngraham added a comment. Or an infinity symbol?  REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17152 To: svuorela, #plasma, hein, broulik, #vdg, ngraham Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D17152: Hide the badge if number too big

2018-11-25 Thread Kai Uwe Broulik
broulik added a comment. Maybe just show an asterisk instead? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17152 To: svuorela, #plasma, hein, broulik, #vdg, ngraham Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D17152: Hide the badge if number too big

2018-11-25 Thread Nathaniel Graham
ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Hmm, I get that "+" may not be useful, but not showing any badge at all is misleading; too many notifications != no notifications at all. Maybe we could come up with a

D17152: Hide the badge if number too big

2018-11-25 Thread Sune Vuorela
svuorela created this revision. svuorela added reviewers: Plasma, hein, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. svuorela requested review of this revision. REVISION SUMMARY A + badge on the email conveys no actual information that the user isn't