D17704: Copy to clipboard always copy English texts

2019-09-16 Thread Yunhe Guo 
guoyunhe added a comment.


  Yes, this can be closed because another approach is more useful.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D17704

To: guoyunhe, #plasma, davidedmundson
Cc: davidedmundson, ngraham, gregormi, cfeck, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17704: Copy to clipboard always copy English texts

2019-05-16 Thread David Edmundson 
davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  Am I right that this can be closed as D17773 
 obsoletes this.
  
  Please reopen this if it's still relevant.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D17704

To: guoyunhe, #plasma, davidedmundson
Cc: davidedmundson, ngraham, gregormi, cfeck, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D17704: Copy to clipboard always copy English texts

2018-12-24 Thread Nathaniel Graham 
ngraham resigned from this revision.
ngraham added a comment.
This revision now requires review to proceed.


  Oops, approved the wrong patch. Meant to approve D17773 
.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D17704

To: guoyunhe, #plasma
Cc: ngraham, gregormi, cfeck, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17704: Copy to clipboard always copy English texts

2018-12-24 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Much better. This seems sensible to me.

REPOSITORY
  R102 KInfoCenter

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17704

To: guoyunhe, #plasma, ngraham
Cc: ngraham, gregormi, cfeck, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17704: Copy to clipboard always copy English texts

2018-12-24 Thread Yunhe Guo 
guoyunhe added a comment.


  Here is another solution. https://phabricator.kde.org/D17773
  
  Don't affect current button but add a new one. Since here are only two 
buttons and enough space, I didn't use dropdown or split button.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D17704

To: guoyunhe, #plasma
Cc: ngraham, gregormi, cfeck, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17704: Copy to clipboard always copy English texts

2018-12-21 Thread Nathaniel Graham 
ngraham added a comment.


  Thanks @gregormi.
  
  I could see a split button working well here.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D17704

To: guoyunhe, #plasma
Cc: ngraham, gregormi, cfeck, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17704: Copy to clipboard always copy English texts

2018-12-21 Thread gregormi 
gregormi added a comment.


  Hi, here is the discussion around my the patch that introduced the Copy 
button: https://phabricator.kde.org/D7087
  
  Originally, I proposed the untranslated English text. Those are the reasons 
that lead to the fact that we have the translated version: 
https://phabricator.kde.org/D7087#207123. Both, the translated and untranslated 
version are useful. We just chose one of those options. To me, having both 
options (with and without translation) makes sense.
  
  My original suggestion had a generic drop down menu (burger menu icon) where 
the copy action was put. Since the menu contained only one action in the end, 
it was dropped.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D17704

To: guoyunhe, #plasma
Cc: ngraham, gregormi, cfeck, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17704: Copy to clipboard always copy English texts

2018-12-20 Thread Christoph Feck 
cfeck added a comment.


  Or make the button have a drop-down, see e.g. "Save As..." button in 
Spectacle.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D17704

To: guoyunhe, #plasma
Cc: ngraham, gregormi, cfeck, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17704: Copy to clipboard always copy English texts

2018-12-20 Thread Yunhe Guo 
guoyunhe added a comment.


  In D17704#380016 , @ngraham wrote:
  
  > I recall in the original patch that copying translated text was something 
that various folks specifically asked for. Is it really that useless? 
@gregormi, do you remember the context?
  
  
  If both translated and untranslated texts are used by some people, I can make 
another button "Copy to clipboard (English)".

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D17704

To: guoyunhe, #plasma
Cc: ngraham, gregormi, cfeck, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17704: Copy to clipboard always copy English texts

2018-12-20 Thread Nathaniel Graham 
ngraham added subscribers: gregormi, ngraham.
ngraham added a comment.


  I recall in the original patch that copying translated text was something 
that various folks specifically asked for. Is it really that useless? 
@gregormi, do you remember the context?

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D17704

To: guoyunhe, #plasma
Cc: ngraham, gregormi, cfeck, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17704: Copy to clipboard always copy English texts

2018-12-20 Thread Yunhe Guo 
guoyunhe updated this revision to Diff 47897.
guoyunhe added a comment.


  Use untranslated texts for clipboard label pairs

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17704?vs=47877&id=47897

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17704

AFFECTED FILES
  Modules/about-distro/src/Module.cpp
  Modules/about-distro/src/Module.h

To: guoyunhe, #plasma
Cc: cfeck, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17704: Copy to clipboard always copy English texts

2018-12-20 Thread Yunhe Guo 
guoyunhe added a comment.


  In D17704#379978 , @cfeck wrote:
  
  > If I understand your patch correctly, you only forbid translating the order 
of text, not the actual text labels.
  
  
  Yes, the patch doesn't do what I want to do. I will update it.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D17704

To: guoyunhe, #plasma
Cc: cfeck, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17704: Copy to clipboard always copy English texts

2018-12-20 Thread Christoph Feck 
cfeck added a comment.


  If I understand your patch correctly, you only forbid translating the order 
of text, not the actual text labels.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D17704

To: guoyunhe, #plasma
Cc: cfeck, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17704: Copy to clipboard always copy English texts

2018-12-20 Thread Yunhe Guo 
guoyunhe created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
guoyunhe requested review of this revision.

REVISION SUMMARY
  Usually users copy this info to report bugs or get help from community. 
English texts are more useful and readable.

REPOSITORY
  R102 KInfoCenter

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17704

AFFECTED FILES
  Modules/about-distro/src/Module.cpp

To: guoyunhe
Cc: plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart