D18357: [applets/mediaframe] Resize combobox to contents

[Nathaniel Graham]

ngraham added a comment.


  While you're in the mood to think about the Media Frame widget (a most 
scintillating topic, I know), would you like to review D19550: [Media Frame] 
Set sourceSize for higher quality and lower memory consumption 
? :)

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D18357

To: davidedmundson, #plasma
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18357: [applets/mediaframe] Resize combobox to contents

[Nathaniel Graham]

ngraham added a comment.


  Yep, in D19548 .

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D18357

To: davidedmundson, #plasma
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18357: [applets/mediaframe] Resize combobox to contents

[David Edmundson]

davidedmundson abandoned this revision.
davidedmundson added a comment.


  Sorry, I forgot about this. AFAIK Nate rewrote media frame to QQC2 anyway.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D18357

To: davidedmundson, #plasma
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18357: [applets/mediaframe] Resize combobox to contents

[Nathaniel Graham]

ngraham added a comment.


  Works, but feels like a workaround. Shouldn't we add a comment indicating 
what bug we're working around?

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D18357

To: davidedmundson, #plasma
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18357: [applets/mediaframe] Resize combobox to contents

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Copies the bodge currently present in plasma-workspace wallpaper config.
  
  BUG: 390571

TEST PLAN
  Looked at it

REPOSITORY
  R114 Plasma Addons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18357

AFFECTED FILES
  applets/mediaframe/package/contents/ui/ConfigGeneral.qml

To: davidedmundson, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart