This revision was automatically updated to reflect the committed changes.
Closed by commit R169:d92bd4fe02c3: Add an ActionTextField component (authored
by ognarb).
REPOSITORY
R169 Kirigami
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D18716?vs=52411=52519
REVISION DETAIL
ognarb updated this revision to Diff 52411.
ognarb added a comment.
- Fix typo in doc
- Code refactorization
REPOSITORY
R169 Kirigami
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D18716?vs=52214=52411
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D18716
ognarb updated this revision to Diff 52214.
ognarb marked 2 inline comments as done.
ognarb added a comment.
- Revert unrelated change
- Use icon.name instead of iconName
REPOSITORY
R169 Kirigami
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D18716?vs=52204=52214
BRANCH
mart added a comment.
it''s lmost perfect,
just a little point on the icon loading, then is good to go
INLINE COMMENTS
> MultipleColumnsGallery.qml:61
> Controls.Label {
> -anchors.horizontalCenter: parent.horizontalCenter
> +Layout.alignment:
ognarb updated this revision to Diff 52204.
ognarb added a comment.
- Use Kirigami.Icon instead of Controls.ToolBouton
- Fix doc
REPOSITORY
R169 Kirigami
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D18716?vs=52141=52204
BRANCH
master
REVISION DETAIL
ngraham added a comment.
Then again there's an argument to be made for consistency. I would be okay
with using clickable icons instead of toolbuttons as long as we make sure to
use a pointing hand cursor when hovered.
REPOSITORY
R169 Kirigami
REVISION DETAIL
ngraham added a comment.
Even though we use clickable icons rather than toolbuttons in the QWidgets
version, I think we should use ToolButtons if the visual style isn't too bad.
People complained about the lack of pressed and hover states when the
`SwipeListItem` used clickable icons
ognarb updated this revision to Diff 52141.
ognarb added a comment.
- Use list of actions
- Text don't go under buttons now
- Fix some warning in the testcase Sidebar.qml
@mart That do you recommand me to use for the icons instead of ToolButton? I
tried to do it with Kirigami.Icon
ognarb updated this revision to Diff 52127.
ognarb added a comment.
WIP: use repeater and list of actions
REPOSITORY
R169 Kirigami
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D18716?vs=52125=52127
BRANCH
arcpatch-D18716
REVISION DETAIL
https://phabricator.kde.org/D18716
