D18848: [Kickoff] Return Kickoff to Favorites page after running a search and closing it

This revision was automatically updated to reflect the committed changes. Closed by commit R119:82b904bce54b: [Kickoff] Return Kickoff to Favorites page after running a search (authored by rooty). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D18848: [Kickoff] Return Kickoff to Favorites page after running a search and closing it

rooty updated this revision to Diff 51197. rooty added a comment. Reorder code instead of adding property changes REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18848?vs=51176=51197 BRANCH fix-kickoff-initial-aftersearch (branched from master)

D18848: [Kickoff] Return Kickoff to Favorites page after running a search and closing it

rooty added a comment. > Doesn't that mean the code in switchToInitial just needs reordering to set the state (to Normal) first and then do the tab change? (Or alternatively the tab change could be cleaned away from the function.) You're right! That's a lot simpler than adding a

D18848: [Kickoff] Return Kickoff to Favorites page after running a search and closing it

hein added a comment. In D18848#407843 , @rooty wrote: > In D18848#407838 , @hein wrote: > > > This is a good change, but it's more worth finding out why it doesn't work already. Looking at the

D18848: [Kickoff] Return Kickoff to Favorites page after running a search and closing it

ngraham added a comment. The diff is automatically closed once Phab detects a commit associated with it, so you don't have to do that manually (most of the time at least; sometimes it's a tad buggy). REPOSITORY R119 Plasma Desktop BRANCH fix-kickoff-initial-aftersearch (branched from

D18848: [Kickoff] Return Kickoff to Favorites page after running a search and closing it

rooty added a comment. In D18848#407999 , @ngraham wrote: > The diff is automatically closed once Phab detects a commit associated with it, so you don't have to do that manually (most of the time at least; sometimes it's a tad buggy).

D18848: [Kickoff] Return Kickoff to Favorites page after running a search and closing it

rooty added a comment. In D18848#407997 , @ngraham wrote: > Nah, `arc land` is just a fancy way of saying "take the commits on this branch and commit them onto the parent branch and then push the parent branch and then delete this branch" >

D18848: [Kickoff] Return Kickoff to Favorites page after running a search and closing it

ngraham added a comment. Nah, `arc land` is just a fancy way of saying "take the commits on this branch and commit them onto the parent branch and then push the parent branch and then delete this branch" You can always just do those things yourself if you'd like, which the above

D18848: [Kickoff] Return Kickoff to Favorites page after running a search and closing it

rooty added a comment. Wow thanks! And after all is said and done, there's no need to run arc land? REPOSITORY R119 Plasma Desktop BRANCH fix-kickoff-initial-aftersearch (branched from master) REVISION DETAIL https://phabricator.kde.org/D18848 To: rooty, #vdg, #plasma, ngraham Cc:

D18848: [Kickoff] Return Kickoff to Favorites page after running a search and closing it

ngraham added a comment. Regardless, let's wait for Eike's approval before landing this. Here's how I would do it, if and when it's time to land this patch: git checkout Plasma/5.12 git cherry-pick 2c3b1ee1995692aaa68e4d3c76e9bf37565741b2 git push git checkout

D18848: [Kickoff] Return Kickoff to Favorites page after running a search and closing it

rooty added a comment. Can I use Kai's suggestion to git checkout Plasma/5.12 then commit then checkout Plasma/5.15 then merge Plasma/5.12, then checkout master then merge Plasma/5.15? Will this work if I cloned it off of anongit.kde.org (and not github.com)? REPOSITORY R119 Plasma

D18848: [Kickoff] Return Kickoff to Favorites page after running a search and closing it

rooty added a comment. In D18848#407897 , @ngraham wrote: > BTW your `FIXED-IN` tag says 5.12.x, but this patch was branched off of master. So if and when this lands, if you don't do anything special, it's currently going to master only. To

D18848: [Kickoff] Return Kickoff to Favorites page after running a search and closing it

ngraham added a comment. BTW your `FIXED-IN` tag says 5.12.x, but this patch was branched off of master. So if and when this lands, if you don't do anything special, it's currently going to master only. To land it on 5.12.8, the easiest thing is to just cherry-pick the commit hash onto

D18848: [Kickoff] Return Kickoff to Favorites page after running a search and closing it

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Nice fix, seems sensible enough to be explicit. Confirmed the bug and that this fixes it. REPOSITORY R119 Plasma Desktop BRANCH fix-kickoff-initial-aftersearch (branched from

D18848: [Kickoff] Return Kickoff to Favorites page after running a search and closing it

rooty added a comment. In D18848#407838 , @hein wrote: > This is a good change, but it's more worth finding out why it doesn't work already. Looking at the code, when `KickoffItem` is triggered it runs the `switchToInitial()` function in

D18848: [Kickoff] Return Kickoff to Favorites page after running a search and closing it

hein added a comment. This is a good change, but it's more worth finding out why it doesn't work already. Looking at the code, when `KickoffItem` is triggered it runs the `switchToInitial()` function in FullRepresentation.qml, which already switches tabs and is also what sets the state back

D18848: [Kickoff] Return Kickoff to Favorites page after running a search and closing it

filipf added a comment. Fixes the bug for me. I also reproduced it in 5.12 so you should add: FIXED-IN: 5.12.8 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18848 To: rooty, #vdg, #plasma Cc: filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot,

D18848: [Kickoff] Return Kickoff to Favorites page after running a search

rooty created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. rooty requested review of this revision. REVISION SUMMARY This patch fixes the bug that would make Kickoff retain the contents of the tab that was selected when a search was run from a tab