D18867: Remove redundant DNS field per bug 403546

2019-02-12 Thread Nathaniel Graham
ngraham added a comment. Does this fix 403546? If so, then the Summary section should have `BUG: 403546` in it so the bug automatically gets closed. Also regardless, You should remove "per bug 403546" from the title. See

D18867: Remove redundant DNS field per bug 403546

2019-02-12 Thread Jan Grulich
jgrulich accepted this revision. jgrulich added a comment. This revision is now accepted and ready to land. I wonder whether this should also go to Plasma 5.15 branch, it's an improvement and doesn't introduce new strings so should be ok to be backported. REPOSITORY R116 Plasma Network

D18867: Remove redundant DNS field per bug 403546

2019-02-09 Thread Luca Beltrame
lbeltrame added a comment. Migrating sounds like a good idea. I don't think popups are necessary for this. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D18867 To: andersonbruce, jgrulich Cc: lbeltrame, plasma-devel, jraleigh, GB_2,

D18867: Remove redundant DNS field per bug 403546

2019-02-08 Thread Bruce Anderson
andersonbruce added a comment. Any connection created by the previous version or the basic NetworkManager plugin should continue to work even though the DNS server list will not be viewable in the new interface. I did not provide an automatic conversion from a previously created

D18867: Remove redundant DNS field per bug 403546

2019-02-08 Thread Bruce Anderson
andersonbruce created this revision. andersonbruce added a reviewer: jgrulich. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added 1 blocking reviewer(s): jgrulich. andersonbruce requested review of this revision. REVISION SUMMARY A DNS field was included on