D19125: Change shadow color to 0,0,0 for KStyle

2019-02-18 Thread Noah Davis
This revision was automatically updated to reflect the committed changes. Closed by commit R31:3e78fa28585e: Change shadow color to 0,0,0 for KStyle (authored by ndavis). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19125?vs=51995=51998 REVISION DETAIL

D19125: Change shadow color to 0,0,0 for KStyle

2019-02-18 Thread Noah Davis
ndavis added a comment. In D19125#414786 , @zzag wrote: > Should we adjust opacity as well? That's the strength value, right? I don't think so. REPOSITORY R31 Breeze BRANCH black-shadow (branched from master) REVISION DETAIL

D19125: Change shadow color to 0,0,0 for KStyle

2019-02-18 Thread Noah Davis
ndavis added a comment. In D19125#414788 , @ngraham wrote: > Nah, I think that would begin to re-introduce the bug we're trying to solve (shadows not being visible in Breeze Dark). Also, worse color banding on cheap displays REPOSITORY

D19125: Change shadow color to 0,0,0 for KStyle

2019-02-18 Thread Nathaniel Graham
ngraham added a comment. Nah, I think that would begin to re-introduce the bug we're trying to solve (shadows not being visible in Breeze Dark). REPOSITORY R31 Breeze BRANCH black-shadow (branched from master) REVISION DETAIL https://phabricator.kde.org/D19125 To: ndavis, #vdg,

D19125: Change shadow color to 0,0,0 for KStyle

2019-02-18 Thread Vlad Zagorodniy
zzag added a comment. Should we adjust opacity as well? REPOSITORY R31 Breeze BRANCH black-shadow (branched from master) REVISION DETAIL https://phabricator.kde.org/D19125 To: ndavis, #vdg, #breeze, ngraham, zzag Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai,

D19125: Change shadow color to 0,0,0 for KStyle

2019-02-18 Thread Noah Davis
ndavis created this revision. ndavis added reviewers: VDG, Breeze. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ndavis requested review of this revision. REVISION SUMMARY Continuation of D19124 REPOSITORY R31 Breeze BRANCH