D19134: Multiply radius by 0.5 in calculateBlurStdDev()

[Nathaniel Graham]

ngraham added a comment.


  Sorry, we had discussed this with @zzag in the #VDG 
 room and I (perhaps erroneously?) left 
with the impression that this was set at its previous value to preserve a 
certain look-and-feel, and was therefore something we could change since we 
were adjusting that look-and-feel elsewhere. I did test it and didn't notice 
any visual regressions.
  
  Can you clarify what problems this change causes?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D19134

To: ndavis, #breeze, ngraham
Cc: zzag, davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D19134: Multiply radius by 0.5 in calculateBlurStdDev()

[Vlad Zagorodniy]

zzag added a comment.


  Please revert this change.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D19134

To: ndavis, #breeze, ngraham
Cc: zzag, davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D19134: Multiply radius by 0.5 in calculateBlurStdDev()

[David Edmundson]

davidedmundson added a comment.


  > so in order to not break existing shadow
  
  So won't this break existing shadow parameters?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D19134

To: ndavis, #breeze, ngraham
Cc: davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19134: Multiply radius by 0.5 in calculateBlurStdDev()

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R31:cd04f42432a6: Multiply radius by 0.5 in 
calculateBlurStdDev() (authored by ndavis).

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19134?vs=52016=52020

REVISION DETAIL
  https://phabricator.kde.org/D19134

AFFECTED FILES
  libbreezecommon/breezeboxshadowrenderer.cpp

To: ndavis, #breeze, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19134: Multiply radius by 0.5 in calculateBlurStdDev()

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Makes sense to do this while we're tweaking the appearance of the shadows for 
5.16 anyway.

REPOSITORY
  R31 Breeze

BRANCH
  shadow-sizes (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19134

To: ndavis, #breeze, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19134: Multiply radius by 0.5 in calculateBlurStdDev

[Noah Davis]

ndavis created this revision.
ndavis added a reviewer: Breeze.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  Fix TODO to follow w3.org standard for shadow-blur

REPOSITORY
  R31 Breeze

BRANCH
  shadow-sizes (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19134

AFFECTED FILES
  libbreezecommon/breezeboxshadowrenderer.cpp

To: ndavis, #breeze
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart