D19162: Add KAboutData

2019-02-21 Thread Aleix Pol Gonzalez 
apol added inline comments.

INLINE COMMENTS

> powerdevilapp.cpp:69
> + i18nc("@info:credit", "(c) 2015-2019 Kai Uwe 
> Broulik"));
> +aboutData.addAuthor(i18nc("@info:credit", "Kai Uwe Broulik"),
> +i18nc("@info:credit", "Maintainer"),

PRobably doesn't make sense to translate names, no?

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D19162

To: broulik, #plasma, sitter
Cc: apol, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D19162: Add KAboutData

2019-02-19 Thread Kai Uwe Broulik 
This revision was automatically updated to reflect the committed changes.
Closed by commit R122:972eb26d0558: Add KAboutData (authored by broulik).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D19162?vs=52077=52083#toc

REPOSITORY
  R122 Powerdevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19162?vs=52077=52083

REVISION DETAIL
  https://phabricator.kde.org/D19162

AFFECTED FILES
  CMakeLists.txt
  daemon/CMakeLists.txt
  daemon/powerdevilapp.cpp

To: broulik, #plasma, sitter
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19162: Add KAboutData

2019-02-19 Thread Nathaniel Graham 
ngraham added inline comments.

INLINE COMMENTS

> powerdevilapp.cpp:69
> + i18nc("@info:credit", "(c) 2015-2019 Kai Uwe 
> Broulik"));
> +aboutData.addAuthor(i18nc("@info:credit", "Kai Uwe Broulik Angelaccio"),
> +i18nc("@info:credit", "Maintainer"),

That's a funny name. :)

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D19162

To: broulik, #plasma, sitter
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19162: Add KAboutData

2019-02-19 Thread Harald Sitter 
sitter accepted this revision.
sitter added a comment.
This revision is now accepted and ready to land.


  LGTM
  
  And FWIW I agree that following PROJECT_VERSION would be nicer.

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D19162

To: broulik, #plasma, sitter
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19162: Add KAboutData

2019-02-19 Thread Kai Uwe Broulik 
broulik created this revision.
broulik added reviewers: Plasma, sitter.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Ensures correct app info is set, for example when crashing

TEST PLAN
  send a SIGSEGV, now got "KDE Power Management System" has crashed.
  Noticed that PowerDevil has its own versioning, currently 2.0.0, imho should 
just be using plasma version

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D19162

AFFECTED FILES
  CMakeLists.txt
  daemon/CMakeLists.txt
  daemon/powerdevilapp.cpp

To: broulik, #plasma, sitter
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart