D19301: Use Kirigami.ActionTextField for the SearchField

2019-03-03 Thread Nathaniel Graham 
ngraham added a comment.


  Oops, so it does!

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D19301

To: ognarb, #discover_software_store, ngraham
Cc: ngraham, apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D19301: Use Kirigami.ActionTextField for the SearchField

2019-03-02 Thread Carl Schwan 
ognarb added a comment.


  In D19301#423523 , @ngraham wrote:
  
  > Also it would be nice to port Discover itself to use this.
  
  
  I'm not sure, I understand your comment. What do you mean with this? Discover 
already implement the actionSearchField.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D19301

To: ognarb, #discover_software_store, ngraham
Cc: ngraham, apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D19301: Use Kirigami.ActionTextField for the SearchField

2019-03-02 Thread Nathaniel Graham 
ngraham added a comment.


  Also it would be nice to port Discover itself to use this.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D19301

To: ognarb, #discover_software_store, ngraham
Cc: ngraham, apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D19301: Use Kirigami.ActionTextField for the SearchField

2019-02-25 Thread Carl Schwan 
This revision was automatically updated to reflect the committed changes.
Closed by commit R134:0bb9bd345f0a: Use Kirigami.ActionTextField for the 
SearchField (authored by ognarb).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19301?vs=52533=52537

REVISION DETAIL
  https://phabricator.kde.org/D19301

AFFECTED FILES
  CMakeLists.txt
  discover/qml/SearchField.qml

To: ognarb, #discover_software_store, ngraham
Cc: ngraham, apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D19301: Use Kirigami.ActionTextField for the SearchField

2019-02-25 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Thanks! Next can you do System Settings? 
https://cgit.kde.org/systemsettings.git/tree/sidebar/package/contents/ui/CategoriesPage.qml#n53
  
  Looks like that one has some RTL handling that maybe could be upstreamed into 
`ActionToolbar` too.

REPOSITORY
  R134 Discover Software Store

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19301

To: ognarb, #discover_software_store, ngraham
Cc: ngraham, apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D19301: Use Kirigami.ActionTextField for the SearchField

2019-02-25 Thread Carl Schwan 
ognarb updated this revision to Diff 52533.
ognarb marked 2 inline comments as done.
ognarb added a comment.


  Improve code

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19301?vs=52529=52533

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19301

AFFECTED FILES
  CMakeLists.txt
  discover/qml/SearchField.qml

To: ognarb, #discover_software_store
Cc: apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D19301: Use Kirigami.ActionTextField for the SearchField

2019-02-25 Thread Aleix Pol Gonzalez 
apol added inline comments.

INLINE COMMENTS

> SearchField.qml:34
> +visible: root.text != ""
> +onTriggered: clearText()
> +}

`searchField.clearText()`

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D19301

To: ognarb, #discover_software_store
Cc: apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D19301: Use Kirigami.ActionTextField for the SearchField

2019-02-25 Thread Aleix Pol Gonzalez 
apol added inline comments.

INLINE COMMENTS

> SearchField.qml:33
> +iconName: "edit-clear"
> +visible: root.text != ""
> +onTriggered: clearText()

`visible: root.text.length !== 0`

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D19301

To: ognarb, #discover_software_store
Cc: apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D19301: Use Kirigami.ActionTextField for the SearchField

2019-02-25 Thread Carl Schwan 
ognarb created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ognarb requested review of this revision.

REVISION SUMMARY
  Need Kirigami latest version (master)

TEST PLAN
  A regression found (need D19300 )

REPOSITORY
  R134 Discover Software Store

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19301

AFFECTED FILES
  CMakeLists.txt
  discover/qml/SearchField.qml

To: ognarb
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart