D19315: Use ActionTextField to implement the searchField in system settings

2019-03-04 Thread Andres Betts 
abetts added a comment.


  +1

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D19315

To: ognarb, #plasma, ngraham
Cc: abetts, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19315: Use ActionTextField to implement the searchField in system settings

2019-03-04 Thread Carl Schwan 
This revision was automatically updated to reflect the committed changes.
Closed by commit R124:e80cbf128f77: Use ActionTextField to implement the 
searchField in system settings (authored by ognarb).

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19315?vs=52553=53115

REVISION DETAIL
  https://phabricator.kde.org/D19315

AFFECTED FILES
  CMakeLists.txt
  sidebar/package/contents/ui/CategoriesPage.qml

To: ognarb, #plasma, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19315: Use ActionTextField to implement the searchField in system settings

2019-03-03 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Nice!
  
  If you're upset about losing the animation, we could add that to the action 
buttons of the `ActionTextField` component itself.

REPOSITORY
  R124 System Settings

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19315

To: ognarb, #plasma, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart