D19372: [sddm-theme] Enlarge user avatar in focus

[Krešimir Čohar]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:458576b2b5db: [sddm-theme] Enlarge user avatar in focus 
(authored by rooty).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19372?vs=53030=53077

REVISION DETAIL
  https://phabricator.kde.org/D19372

AFFECTED FILES
  lookandfeel/contents/components/UserDelegate.qml

To: rooty, #vdg, ngraham
Cc: davidedmundson, abetts, filipf, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19372: [sddm-theme] Enlarge user avatar in focus

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Perfect. Shipit!
  
  FWIW I think being explicit is better than implicit when there's any possible 
chance of confusion or misunderstanding.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  arcpatch-D19372

REVISION DETAIL
  https://phabricator.kde.org/D19372

To: rooty, #vdg, ngraham
Cc: davidedmundson, abetts, filipf, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19372: [sddm-theme] Enlarge user avatar in focus

[Krešimir Čohar]

rooty added a comment.


  P.S. Should we use "live: true" or just delete the line? Because it's true by 
default, but this makes it clear that it shouldn't be live: false

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19372

To: rooty, #vdg, ngraham
Cc: davidedmundson, abetts, filipf, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19372: [sddm-theme] Enlarge user avatar in focus

[Krešimir Čohar]

rooty updated this revision to Diff 53030.
rooty added a comment.


  Prevent user avatar in focus from becoming blurred

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19372?vs=53028=53030

BRANCH
  arcpatch-D19372

REVISION DETAIL
  https://phabricator.kde.org/D19372

AFFECTED FILES
  lookandfeel/contents/components/UserDelegate.qml

To: rooty, #vdg, ngraham
Cc: davidedmundson, abetts, filipf, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19372: [sddm-theme] Enlarge user avatar in focus

[Krešimir Čohar]

rooty updated this revision to Diff 53028.
rooty added a comment.


  Rebase; add property animation

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19372?vs=52683=53028

BRANCH
  arcpatch-D19372

REVISION DETAIL
  https://phabricator.kde.org/D19372

AFFECTED FILES
  lookandfeel/contents/components/UserDelegate.qml

To: rooty, #vdg, ngraham
Cc: davidedmundson, abetts, filipf, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19372: [sddm-theme] Enlarge user avatar in focus

[Krešimir Čohar]

rooty added a comment.


  In D19372#421391 , @filipf wrote:
  
  > In D19372#421381 , 
@davidedmundson wrote:
  >
  > > Heh, I'm sure some old SDDM (maybe even LightDM) theme did that. There 
was a whole Carousel system.
  >
  >
  > Our old SDDM theme 

 did that as well, right?
  
  
  This seems to be how they did it
  
source: visible ? "user-identity" : undefined
visible: (face.status == Image.Error || face.status == Image.Null)
  
  Which isn't all that different from how this diff.
  It still looks fairly animated to me :D

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19372

To: rooty, #vdg, ngraham
Cc: davidedmundson, abetts, filipf, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19372: [sddm-theme] Enlarge user avatar in focus

[Krešimir Čohar]

rooty added a comment.


  Sure, but I'd like to use the bling in another patch :D
  It seems to transition fine, it doesn't just "pop" into a larger size
  
  But I'm afraid I'm going to have to rebase this too because of D19433 


REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19372

To: rooty, #vdg, ngraham
Cc: davidedmundson, abetts, filipf, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19372: [sddm-theme] Enlarge user avatar in focus

[Filip Fila]

filipf added a comment.


  In D19372#421381 , @davidedmundson 
wrote:
  
  > Heh, I'm sure some old SDDM (maybe even LightDM) theme did that. There was 
a whole Carousel system.
  
  
  Our old SDDM theme 

 did that as well, right?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19372

To: rooty, #vdg, ngraham
Cc: davidedmundson, abetts, filipf, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19372: [sddm-theme] Enlarge user avatar in focus

[Andres Betts]

abetts added a comment.


  In D19372#421386 , @rooty wrote:
  
  > In D19372#421381 , 
@davidedmundson wrote:
  >
  > > Heh, I'm sure some old SDDM (maybe even LightDM) theme did that. There 
was a whole Carousel system.
  >
  >
  > I'm not sold on this idea :D I'm just worried it'll come out tacky
  
  
  I would agree, if there is no visual work using effects to ease the 
transitions between states, then it looks pretty unrefined. Dave, is there 
anything that would help here?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19372

To: rooty, #vdg, ngraham
Cc: davidedmundson, abetts, filipf, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19372: [sddm-theme] Enlarge user avatar in focus

[Krešimir Čohar]

rooty added a comment.


  In D19372#421381 , @davidedmundson 
wrote:
  
  > Heh, I'm sure some old SDDM (maybe even LightDM) theme did that. There was 
a whole Carousel system.
  
  
  I'm not sold on this idea :D I'm just worried it'll come out tacky

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19372

To: rooty, #vdg, ngraham
Cc: davidedmundson, abetts, filipf, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19372: [sddm-theme] Enlarge user avatar in focus

[David Edmundson]

davidedmundson added a comment.


  Heh, I'm sure some old SDDM (maybe even LightDM) theme did that. There was a 
whole Carousel system.
  
  If you do animate, generally I've found that animating width won't do what 
you want, it'll cause the text to re-lay out and that looks weird.
  Using Item.scale with a correct transform origin looks smooth, but obviously 
you lose some resolution in the text.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19372

To: rooty, #vdg, ngraham
Cc: davidedmundson, abetts, filipf, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19372: [sddm-theme] Enlarge user avatar in focus

[Krešimir Čohar]

rooty added a comment.


  In D19372#421170 , @ngraham wrote:
  
  > Hmm, that's a shame. Well, regardless of implementation, I'd like to see 
//some// form of animation when the size changes. :)
  
  
  But it looks very smooth already. It's choppy in sddm-greeter but on the 
actual login screen it looks pretty good (more to the point - it looks very 
much the same as the transition from the user list screen to the prompt screen).
  
  I also think that if we're going to opt for an animation effect, I'd like to 
do it in another patch :D

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19372

To: rooty, #vdg, ngraham
Cc: abetts, filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19372: [sddm-theme] Enlarge user avatar in focus

[Nathaniel Graham]

ngraham added a comment.


  Hmm, that's a shame. Well, regardless of implementation, I'd like to see 
//some// form of animation when the size changes. :)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19372

To: rooty, #vdg, ngraham
Cc: abetts, filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19372: [sddm-theme] Enlarge user avatar in focus

[Krešimir Čohar]

rooty added a comment.


  Also, if I use the scale effect, they don't seem to anchor as well:
  
  F6641617: image.png 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19372

To: rooty, #vdg, ngraham
Cc: abetts, filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19372: [sddm-theme] Enlarge user avatar in focus

[Krešimir Čohar]

rooty added a comment.


  In D19372#420779 , @ngraham wrote:
  
  > Perfect functionality! Now we need some more bling. :) I'd like for the 
size to animate as well.
  >
  > A sane way to do this might be with a `ScaleAnimator` 
(https://doc.qt.io/qt-5/qml-qtquick-scaleanimator.html), and then do a tiny bit 
of refactoring to adjust the scale rather than changing `faceSize`.
  
  
  But wouldn't that involve arbitrary multiplication versus relying on 
standardized units?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19372

To: rooty, #vdg, ngraham
Cc: abetts, filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19372: [sddm-theme] Enlarge user avatar in focus

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Perfect functionality! Now we need some more bling. :) I'd like for the size 
to animate as well.
  
  A sane way to do this might be with a `ScaleAnimator` 
(https://doc.qt.io/qt-5/qml-qtquick-scaleanimator.html), and then do a tiny bit 
of refactoring to adjust the scale rather than changing `faceSize`.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19372

To: rooty, #vdg, ngraham
Cc: abetts, filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19372: [sddm-theme] Enlarge user avatar in focus

[Filip Fila]

filipf added a comment.


  In D19372#420739 , @rooty wrote:
  
  > In D19372#420737 , @filipf wrote:
  >
  > > As this is meant to be a replacement for `opacity: isCurrent ? 1.0 : 0.5` 
I would suggest to remove it in this patch.
  >
  >
  > Are the circles supposed to be this dark though?
  >
  > F6641183: image.png 
  
  
  We can tweak the circle color based on containsMouse, but opacity has to go 
(T9658#170319 )

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19372

To: rooty, #vdg, ngraham
Cc: abetts, filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19372: [sddm-theme] Enlarge user avatar in focus

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19372

To: rooty, #vdg, ngraham
Cc: abetts, filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19372: [sddm-theme] Enlarge user avatar in focus

[Krešimir Čohar]

rooty added a comment.


  In D19372#420737 , @filipf wrote:
  
  > As this is meant to be a replacement for `opacity: isCurrent ? 1.0 : 0.5` I 
would suggest to remove it in this patch.
  
  
  Are the circles supposed to be this dark though?
  
  F6641183: image.png 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19372

To: rooty, #vdg, ngraham
Cc: filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19372: [sddm-theme] Enlarge user avatar in focus

[Filip Fila]

filipf added a comment.


  As this is meant to be a replacement for `opacity: isCurrent ? 1.0 : 0.5` I 
would suggest to remove it in this patch.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19372

To: rooty, #vdg, ngraham
Cc: filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19372: [sddm-theme] Enlarge user avatar in focus

[Krešimir Čohar]

rooty created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
rooty requested review of this revision.

REVISION SUMMARY
  This patch makes the user avatar that is selected (in focus) larger than the 
other unselected/deselected avatars around it (provided there is more than one 
user).

REPOSITORY
  R120 Plasma Workspace

BRANCH
  enlarge-avatar-in-focus (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19372

AFFECTED FILES
  lookandfeel/contents/components/UserDelegate.qml

To: rooty
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart