D19433: [sddm-theme/lock screen] Increase username and action button font size

[Nathaniel Graham]

ngraham added a comment.


  Wow, it's amazing how much better this makes both the lock and login screen 
look and feel. I love it!
  
  Since this affects components on the Logout screen as well, we should 
probably also make the same size changes to the buttons and text present there 
in this patch.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19433

To: rooty, #vdg, #plasma, ngraham
Cc: filipf, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19433: [sddm-theme/lock screen] Increase username and action button font size

[Krešimir Čohar]

rooty updated this revision to Diff 52928.
rooty added a comment.


  Use pointSize, adjust username/password font sizes as well, adjust lock 
screen font sizes

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19433?vs=52883=52928

BRANCH
  bump-up-label-fonts (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19433

AFFECTED FILES
  lookandfeel/contents/components/ActionButton.qml
  lookandfeel/contents/components/UserDelegate.qml
  lookandfeel/contents/lockscreen/MainBlock.qml
  sddm-theme/Login.qml

To: rooty, #vdg, #plasma, ngraham
Cc: filipf, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19433: [sddm-theme/lock screen] Increase username and action button font size

[Krešimir Čohar]

rooty added a comment.


  In D19433#422564 , @ngraham wrote:
  
  > It's probably not the worst thing in the world if we use hardcoded font 
sizes here. We already do for the clock, and the login screen isn't able to 
read user-chosen font sizes anyway, so there's not much point in using a 
`Heading`, one of whose reasons for existance existence is to respect the 
user's font size. So if we use hardcoded sizes, then the login and lock screens 
will both be able to have the same font sizes for everything.
  
  
  Excellent!

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19433

To: rooty, #vdg, #plasma, ngraham
Cc: filipf, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19433: [sddm-theme/lock screen] Increase username and action button font size

[Nathaniel Graham]

ngraham added a comment.


  It's probably not the worst thing in the world if we use hardcoded font sizes 
here. We already do for the clock, and the login screen isn't able to read 
user-chosen font sizes anyway, so there's not much point in using a `Heading`, 
one of whose reasons for existance existence is to respect the user's font 
size. So if we use hardcoded sizes, then the login and lock screens will both 
be able to have the same font sizes for everything.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19433

To: rooty, #vdg, #plasma, ngraham
Cc: filipf, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19433: [sddm-theme/lock screen] Increase username and action button font size

[Krešimir Čohar]

rooty added a comment.


  The cliff-notes version of the level 4 vs level 3 problem
  
  F6646443: image.png 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19433

To: rooty, #vdg, #plasma, ngraham
Cc: filipf, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19433: [sddm-theme/lock screen] Increase username and action button font size

[Krešimir Čohar]

rooty added a comment.


  In D19433#422367 , @filipf wrote:
  
  > In any case, I'd like to have it like this:
  >
  > - no shadows with blur
  
  
  Even though the shadows are pretty, I'm inclined to agree that no shadows 
might be a better fit.
  
  > - username is 12pt (or level 3)
  
  Ditto.
  
  > - action buttons are 11pt (or level 4)
  
  This sounds good to me, and it looks good
  F6646429: VirtualBox_neon_01_03_2019_11_00_07.png 

  But we'd **have to use pointSize**. Level 4 headings simply come out too 
blurry given different antialiasing settings.
  
  > - the tool buttons at the bottom are 10 pt
  
  Ditto.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19433

To: rooty, #vdg, #plasma, ngraham
Cc: filipf, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19433: [sddm-theme/lock screen] Increase username and action button font size

[Filip Fila]

filipf added a comment.


  In any case, I'd like to have it like this:
  
  - no shadows with blur
  - username is 12pt (or level 3)
  - action buttons are 11pt (or level 4)
  - the tool buttons at the bottom are 10 pt
  
  F6646413: image.png 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19433

To: rooty, #vdg, #plasma, ngraham
Cc: filipf, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19433: [sddm-theme/lock screen] Increase username and action button font size

[Krešimir Čohar]

rooty added a comment.


  In D19433#422364 , @filipf wrote:
  
  > The difference is too jarring with level 3.
  
  
  pointSize then, because the fonts are too hazy if you use level 4. Not to 
belabor the point but take a closer look at the screenshots I posted in my 
comments.
  This neon situation is a very niche usage case that just covers up the 
problem and doesn't resolve it.
  
  That being said, level 3 looks just fine in my opinion, even better than 
level 4.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19433

To: rooty, #vdg, #plasma, ngraham
Cc: filipf, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19433: [sddm-theme/lock screen] Increase username and action button font size

[Filip Fila]

filipf added a comment.


  The difference is too jarring with level 3.
  
  F6646395: image.png 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19433

To: rooty, #vdg, #plasma, ngraham
Cc: filipf, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19433: [sddm-theme/lock screen] Increase username and action button font size

[Krešimir Čohar]

rooty added a comment.


  In D19433#422359 , @filipf wrote:
  
  > From a technical point of view I'm not sure this is the ideal solution. 
It's not hardcoding font sizes, but is changing only 2 labels (to be headings 
when they're actually not headings) while the other ones remain 10pt.
  
  
  But I didn't mean to increase the font size of the clock, the keyboard or 
session buttons, just the username and action buttons (and maybe the 
username/password fields.
  
  > The best solution would be if we had an option for configuring SDDM font 
sizes. At the very least we could adjust font size based on the screen 
resolution. #plasma  people, what do 
you think?
  
  You could change the font DPI.
  
  > If this ends up being the best we can do I would prefer to have level 4 
just so there isn't a big discrepancy between label sizes.
  
  They come out small and blurry. Take a look at my previous comment.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19433

To: rooty, #vdg, #plasma, ngraham
Cc: filipf, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19433: [sddm-theme/lock screen] Increase username and action button font size

[Filip Fila]

filipf added a comment.


  From a technical point of view I'm not sure this is the ideal solution. It's 
not hardcoding font sizes, but is changing only 2 labels (to be headings when 
they're actually not headings) while the other ones remain 10pt.
  
  The best solution would be if we had an option for configuring SDDM font 
sizes. At the very least we could adjust font size based on the screen 
resolution. #plasma  people, what do 
you think?
  
  If this ends up being the best we can do I would prefer to have level 4 just 
so there isn't a big discrepancy between label sizes.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19433

To: rooty, #vdg, #plasma, ngraham
Cc: filipf, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19433: [sddm-theme/lock screen] Increase username and action button font size

[Krešimir Čohar]

rooty updated this revision to Diff 52883.
rooty added a comment.


  Raise level to level 3

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19433?vs=52882=52883

BRANCH
  bump-up-label-fonts (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19433

AFFECTED FILES
  lookandfeel/contents/components/ActionButton.qml
  lookandfeel/contents/components/UserDelegate.qml

To: rooty, #vdg, #plasma, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19433: [sddm-theme/lock screen] Increase username and action button font size

[Krešimir Čohar]

rooty added a comment.


  There's another problem that might be hard to appreciate with neon's default 
settings (Noto Sans, slight hinting etc.)
  
  This is level 4:
  F6646230: image.png 
  This is level 3:
  F6646233: image.png 
  
  Level 4 just seems blurrier. Level 3's bigger (easier to make out) and the 
letters are sharper so I'm going to bump it up to level 3, let me know if it's 
too big.
  
  P.S. For some reason, the fonts look bigger in sddm-greeter, in case you've 
been using that to test the fonts. They look fine on the login screen.
  
  Also, on an unrelated note, I've seriously been considering dropping the 
username shadow because it makes it look so much different than the action 
button label. That said, it does look nice like you've said, and we could just 
add a shadow to the action buttons and that'd work fine too. I'm mentioning it 
again because it's really easy to appreciate in that screenshot.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19433

To: rooty, #vdg, #plasma, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19433: [sddm-theme/lock screen] Increase username and action button font size

[Krešimir Čohar]

rooty added a comment.


  How's that look? I used the anchor thing from D19372 
 just without the //embiggening//

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19433

To: rooty, #vdg, #plasma, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19433: [sddm-theme/lock screen] Increase username and action button font size

[Krešimir Čohar]

rooty updated this revision to Diff 52882.
rooty added a comment.


  Increase user avatar size

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19433?vs=52874=52882

BRANCH
  bump-up-label-fonts (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19433

AFFECTED FILES
  lookandfeel/contents/components/ActionButton.qml
  lookandfeel/contents/components/UserDelegate.qml

To: rooty, #vdg, #plasma, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19433: [sddm-theme/lock screen] Increase username and action button font size

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  I'm hugely in favor of increasing the font size by using Headings here. The 
current tiny text is difficult to read and there is no advantage to using small 
text on something like a login or lock screen where the amount of text is very 
limited.
  
  However, the avatar seems to get smaller as the text size is increased. Can 
you fix that?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19433

To: rooty, #vdg, #plasma, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19433: [sddm-theme/lock screen] Increase username and action button font size

[Krešimir Čohar]

rooty updated this revision to Diff 52874.
rooty added a comment.


  Bring back comment deleted by accident

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19433?vs=52873=52874

BRANCH
  bump-up-label-fonts (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19433

AFFECTED FILES
  lookandfeel/contents/components/ActionButton.qml
  lookandfeel/contents/components/UserDelegate.qml

To: rooty, #vdg, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19433: [sddm-theme/lock screen] Increase username and action button font size

[Krešimir Čohar]

rooty created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
rooty requested review of this revision.

REVISION SUMMARY
  This patch increases the font size of the username and action button labels 
for better readability.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  bump-up-label-fonts (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19433

AFFECTED FILES
  lookandfeel/contents/components/ActionButton.qml
  lookandfeel/contents/components/UserDelegate.qml

To: rooty
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart