D19454: Fix errors in kirigami example files

2019-03-19 Thread Carl Schwan 
This revision was automatically updated to reflect the committed changes.
Closed by commit R169:8dc09a000125: Fix errors in kirigami example files 
(authored by ognarb).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D19454?vs=54124=54354#toc

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19454?vs=54124=54354

REVISION DETAIL
  https://phabricator.kde.org/D19454

AFFECTED FILES
  examples/simpleexamples/AbstractApplicationWindow.qml
  examples/simpleexamples/FixedSidebar.qml
  examples/simpleexamples/MultipleColumnsGallery.qml
  examples/simpleexamples/Sidebar.qml
  examples/simpleexamples/simpleChatApp.qml

To: ognarb, #kirigami, mart
Cc: mart, apol, plasma-devel, domson, dkardarakos, davidedmundson, hein

D19454: Fix errors in kirigami example files

2019-03-17 Thread Carl Schwan 
ognarb updated this revision to Diff 54124.
ognarb added a comment.


  Remove goBack funtion, and I repported the bug 
https://bugs.kde.org/show_bug.cgi?id=405571 :)

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19454?vs=52927=54124

BRANCH
  arcpatch-D19454

REVISION DETAIL
  https://phabricator.kde.org/D19454

AFFECTED FILES
  examples/simpleexamples/AbstractApplicationWindow.qml
  examples/simpleexamples/FixedSidebar.qml
  examples/simpleexamples/MultipleColumnsGallery.qml
  examples/simpleexamples/Sidebar.qml
  examples/simpleexamples/simpleChatApp.qml

To: ognarb, #kirigami
Cc: mart, apol, plasma-devel, domson, dkardarakos, davidedmundson, hein

D19454: Fix errors in kirigami example files

2019-03-17 Thread Marco Martin 
mart added inline comments.

INLINE COMMENTS

> ognarb wrote in AbstractApplicationWindow.qml:105
> Without I get the errror: TypeError: Property 'goBack' of object 
> QQuickStackView_QML_91(0x55ea59443ee0) is not a function

yeah, i think it's actually a kirigmai bug, let's not do it in the examples

an you report it to bugzilla?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D19454

To: ognarb, #kirigami
Cc: mart, apol, plasma-devel, domson, dkardarakos, davidedmundson, hein

D19454: Fix errors in kirigami example files

2019-03-08 Thread Carl Schwan 
ognarb added inline comments.

INLINE COMMENTS

> apol wrote in AbstractApplicationWindow.qml:105
> Why's that?

Without I get the errror: TypeError: Property 'goBack' of object 
QQuickStackView_QML_91(0x55ea59443ee0) is not a function

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D19454

To: ognarb, #kirigami
Cc: apol, plasma-devel, domson, dkardarakos, davidedmundson, mart, hein

D19454: Fix errors in kirigami example files

2019-03-03 Thread Aleix Pol Gonzalez 
apol added a comment.


  Others look good to me.

INLINE COMMENTS

> AbstractApplicationWindow.qml:105
>  pageStack: Controls.StackView {
> +function goBack() {
> +console.log("goBack");

Why's that?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D19454

To: ognarb, #kirigami
Cc: apol, plasma-devel, domson, dkardarakos, davidedmundson, mart, hein