D19460: [powerdevil] Correct labels

2019-03-03 Thread Krešimir Čohar 
This revision was automatically updated to reflect the committed changes.
Closed by commit R122:85ae655bacbb: [powerdevil] Correct labels (authored by 
rooty).

REPOSITORY
  R122 Powerdevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19460?vs=52958=53076

REVISION DETAIL
  https://phabricator.kde.org/D19460

AFFECTED FILES
  kcmodule/activities/activityWidget.ui

To: rooty, #vdg, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19460: [powerdevil] Correct labels

2019-03-03 Thread Krešimir Čohar 
rooty marked 2 inline comments as done.
rooty added inline comments.

INLINE COMMENTS

> ngraham wrote in activityWidget.ui:72
> Eh, let's make the English teachers happy. :)

Now let's only hope they'll switch to Plasma :D

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D19460

To: rooty, #vdg, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19460: [powerdevil] Correct labels

2019-03-02 Thread Nathaniel Graham 
ngraham added inline comments.

INLINE COMMENTS

> rooty wrote in activityWidget.ui:72
> Haha I had the idea to use turn off too, because you don't really ever "shut 
> down" a screen

Eh, let's make the English teachers happy. :)

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D19460

To: rooty, #vdg, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19460: [powerdevil] Correct labels

2019-03-02 Thread Krešimir Čohar 
rooty added a comment.


  I wonder if people would notice if it ended in a preposition (ironically 
"Never turn the screen off" sounds nicer to me)

INLINE COMMENTS

> ngraham wrote in activityWidget.ui:72
> While we're touching this, I think "Never turn off the screen" would sound 
> more natural here.

Haha I had the idea to use turn off too, because you don't really ever "shut 
down" a screen

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D19460

To: rooty, #vdg, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19460: [powerdevil] Correct labels

2019-03-02 Thread Krešimir Čohar 
rooty updated this revision to Diff 52958.
rooty marked an inline comment as done.
rooty added a comment.


  Shut down --> turn off

REPOSITORY
  R122 Powerdevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19460?vs=52938=52958

BRANCH
  powerdevil-hig (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19460

AFFECTED FILES
  kcmodule/activities/activityWidget.ui

To: rooty, #vdg, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19460: [powerdevil] Correct labels

2019-03-02 Thread Nathaniel Graham 
ngraham added a comment.


  In D19460#422873 , @rooty wrote:
  
  > Should "Act like" be replaced with "Behave as?"
  
  
  Is the control associated with this string actually used anywhere? I can't 
even find it.

INLINE COMMENTS

> activityWidget.ui:72
>   
> -  Never shutdown the screen
> +  Never shut down the screen
>   

While we're touching this, I think "Never turn off the screen" would sound more 
natural here.

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D19460

To: rooty, #vdg, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19460: [powerdevil] Correct labels

2019-03-01 Thread Krešimir Čohar 
rooty added a comment.


  Should "Act like" be replaced with "Behave as?"

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D19460

To: rooty
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19460: [powerdevil] Correct labels

2019-03-01 Thread Krešimir Čohar 
rooty created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
rooty requested review of this revision.

REVISION SUMMARY
  This patch corrects the grammar in certain labels and makes others conform 
with the KDE HIG.

REPOSITORY
  R122 Powerdevil

BRANCH
  powerdevil-hig (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19460

AFFECTED FILES
  kcmodule/activities/activityWidget.ui

To: rooty
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart