D19605: Sharpen ApplicationMenu, Shade, ContextHelp icons

This revision was automatically updated to reflect the committed changes. Closed by commit R31:be9f150abe2d: Sharpen ApplicationMenu, Shade, ContextHelp icons (authored by ndavis). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19605?vs=53405=53764 REVISION

D19605: Sharpen ApplicationMenu, Shade, ContextHelp icons

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Could not find any visual regressions at multiple integer and fractional scale factors with several fonts and plausible sizes (9pt, 11pt, 12pt). I say ship it. REPOSITORY R31 Breeze

D19605: Sharpen ApplicationMenu, Shade, ContextHelp icons

ndavis added a comment. In D19605#429711 , @ngraham wrote: > I think I agree that it's much better to improve things universally if we can. But if we can't, then improving things for the default settings is good too. > > @ndavis, how well

D19605: Sharpen ApplicationMenu, Shade, ContextHelp icons

ngraham added a comment. I think I agree that it's much better to improve things universally if we can. But if we can't, then improving things for the default settings is good too. @ndavis, how well tested is this? We can't land this if it causes any regressions. I didn't spot any with

D19605: Sharpen ApplicationMenu, Shade, ContextHelp icons

zzag resigned from this revision. zzag added a comment. Just to be clear, I'm not against good defaults. I don't like that the defaults are adjusted in such way that icons look sharp only with one particular font size and one particular button size. After all, KDE Plasma is configurable. If

D19605: Sharpen ApplicationMenu, Shade, ContextHelp icons

ngraham added a comment. If it doesn't cause regressions for other fonts and sizes, what's the drawback? Especially if the sizes and fonts that this improves are the default settings (are they, @ndavis?) REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D19605 To:

D19605: Sharpen ApplicationMenu, Shade, ContextHelp icons

zzag added a comment. > What's not worth what? Making some icons sharp only for particular button size and font size. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D19605 To: ndavis, #vdg, #breeze, zzag, davidedmundson Cc: ngraham, abetts, plasma-devel,

D19605: Sharpen ApplicationMenu, Shade, ContextHelp icons

ngraham added a comment. What's not worth what? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D19605 To: ndavis, #vdg, #breeze, zzag, davidedmundson Cc: ngraham, abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D19605: Sharpen ApplicationMenu, Shade, ContextHelp icons

zzag added a comment. Not really, I still think it's not worth that. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D19605 To: ndavis, #vdg, #breeze, zzag, davidedmundson Cc: abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D19605: Sharpen ApplicationMenu, Shade, ContextHelp icons

ndavis added a comment. @zzag Is there anything you want me to change? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D19605 To: ndavis, #vdg, #breeze, zzag, davidedmundson Cc: abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D19605: Sharpen ApplicationMenu, Shade, ContextHelp icons

abetts added a comment. +1 REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D19605 To: ndavis, #vdg, #breeze, zzag, davidedmundson Cc: abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19605: Sharpen ApplicationMenu, Shade, ContextHelp icons

ndavis added a comment. In D19605#427037 , @zzag wrote: > This patch makes buttons sharp only for one particular button size and font size. You're right, but this makes it sharper at the default button+font size. Smaller sizes suffer,

D19605: Sharpen ApplicationMenu, Shade, ContextHelp icons

zzag added a comment. This patch makes buttons sharp only for one particular button size and font size. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D19605 To: ndavis, #vdg, #breeze, zzag, davidedmundson Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot,

D19605: Sharpen ApplicationMenu, Shade, ContextHelp icons

ndavis updated this revision to Diff 53405. ndavis added a comment. Fix formatting on line parameters for Shade button REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19605?vs=53403=53405 BRANCH fix-titlebar-buttons (branched from master) REVISION DETAIL

D19605: Sharpen ApplicationMenu, Shade, ContextHelp icons

ndavis created this revision. ndavis added reviewers: VDG, Breeze. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ndavis requested review of this revision. REVISION SUMMARY Parts of these icons did not line up well with the pixel grid making them seem blurry or faded.