D19606: [Task Manager] Reorganize and improve presentation of context menu

ngraham added a comment. I had a feeling that I wouldn't be able to please everyone with this diff. :) The problem is that the more things you put on the main level, the more overwhelming it looks, especially for apps that have recent docs and jump list items. I didn't think that having

D19606: [Task Manager] Reorganize and improve presentation of context menu

cfeck added a comment. Hm, is moving "Minimize" one level deeper an UX improvement? Is it worth to create a bug about this issue? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19606 To: ngraham, #plasma, #vdg, ndavis, hein Cc: cfeck, abetts, broulik,

D19606: [Task Manager] Reorganize and improve presentation of context menu

This revision was automatically updated to reflect the committed changes. Closed by commit R119:1daf42d9d734: [Task Manager] Reorganize and improve presentation of context menu (authored by ngraham). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D19606?vs=53832=53833#toc REPOSITORY

D19606: [Task Manager] Reorganize and improve presentation of context menu

ngraham updated this revision to Diff 53832. ngraham added a comment. Rebase and fix merge conflicts REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19606?vs=53804=53832 BRANCH reorganize-task-manager-context-menu (branched from master) REVISION

D19606: [Task Manager] Reorganize and improve presentation of context menu

broulik added a comment. +1! REPOSITORY R119 Plasma Desktop BRANCH reorganize-task-manager-context-menu (branched from master) REVISION DETAIL https://phabricator.kde.org/D19606 To: ngraham, #plasma, #vdg, ndavis, hein Cc: abetts, broulik, ndavis, trickyricky26, plasma-devel,

D19606: [Task Manager] Reorganize and improve presentation of context menu

ngraham added a comment. All good now, @hein? REPOSITORY R119 Plasma Desktop BRANCH reorganize-task-manager-context-menu (branched from master) REVISION DETAIL https://phabricator.kde.org/D19606 To: ngraham, #plasma, #vdg, ndavis, hein Cc: abetts, broulik, ndavis, trickyricky26,

D19606: [Task Manager] Reorganize and improve presentation of context menu

ngraham updated this revision to Diff 53804. ngraham added a comment. Put the Task-Manager-Specific actions in the "More Actions" submenu REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19606?vs=53750=53804 BRANCH

D19606: [Task Manager] Reorganize and improve presentation of context menu

hein added a comment. In D19606#429891 , @ngraham wrote: > Idea to make the menu smaller: put the Configure and Alternatives items into the sub-menu, and rename it to just More Actions...: > > F6687262: Screenshot_20190312_135407.png

D19606: [Task Manager] Reorganize and improve presentation of context menu

ngraham added a comment. Idea to make the menu smaller: put the Configure and Alternatives items into the sub-menu, and rename it to just More Actions...: F6687262: Screenshot_20190312_135407.png Thoughts? REPOSITORY R119 Plasma Desktop

D19606: [Task Manager] Reorganize and improve presentation of context menu

ngraham updated this revision to Diff 53750. ngraham added a comment. Use new `window-*` icons from D19575 REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19606?vs=53462=53750 BRANCH

D19606: [Task Manager] Reorganize and improve presentation of context menu

ngraham added a comment. In D19606#428236 , @hein wrote: > I'm concerned that having title labels on everything could be overdoing it a bit? It makes the context menu very large and have a lot of dead space, and adds to the noise. Isn't that

D19606: [Task Manager] Reorganize and improve presentation of context menu

hein added a comment. I'm concerned that having title labels on everything could be overdoing it a bit? It makes the context menu very large and have a lot of dead space, and adds to the noise. Isn't that rather a detriment to utility on repeated use? It's sometimes important to remember

D19606: [Task Manager] Reorganize and improve presentation of context menu

ngraham updated this revision to Diff 53462. ngraham marked 5 inline comments as done. ngraham added a comment. Address all review comments REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19606?vs=53409=53462 BRANCH

D19606: [Task Manager] Reorganize and improve presentation of context menu

ngraham added a comment. In D19606#426997 , @broulik wrote: > Overall I must say I'm quite a fan. > > I don't like the Settings and Alternatives entries at the top, they draw most attention to them for actions that should rather be least

D19606: [Task Manager] Reorganize and improve presentation of context menu

ngraham added a comment. In D19606#427269 , @abetts wrote: > Would it be possible for the header labels to be a bit different? Not sure what would look best, bold, italics, a lighter shade of gray > > F6674017: Screen Shot 2019-03-08 at

D19606: [Task Manager] Reorganize and improve presentation of context menu

abetts added a comment. Would it be possible for the header labels to be a bit different? Not sure what would look best, bold, italics, a lighter shade of gray F6674017: Screen Shot 2019-03-08 at 8.49.54 AM.png REPOSITORY R119 Plasma Desktop

D19606: [Task Manager] Reorganize and improve presentation of context menu

broulik added a comment. Overall I must say I'm quite a fan. I don't like the Settings and Alternatives entries at the top, they draw most attention to them for actions that should rather be least intrusive. I would prefer the jump list actions stuff at the top but grouping them with

D19606: [Task Manager] Reorganize and improve presentation of context menu

ngraham updated this revision to Diff 53409. ngraham added a comment. Actually use the correct icon REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19606?vs=53407=53409 BRANCH reorganize-task-manager-context-menu (branched from master) REVISION

D19606: [Task Manager] Reorganize and improve presentation of context menu

ngraham updated this revision to Diff 53407. ngraham marked 2 inline comments as done. ngraham added a comment. Correct erroneously-changed fullscreen icon REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19606?vs=53406=53407 BRANCH

D19606: [Task Manager] Reorganize and improve presentation of context menu

ngraham added a comment. In D19606#426946 , @ndavis wrote: > I like it overall, but some of those icons need changing. Not just here, but in breeze-icons as well. > > Resize: I don't like how busy that icon looks, but I"m not sure if it's

D19606: [Task Manager] Reorganize and improve presentation of context menu

ndavis added subscribers: trickyricky26, ndavis. ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. I like it overall, but some of those icons need changing. Not just here, but in breeze-icons as well. Resize: I don't like

D19606: [Task Manager] Reorganize and improve presentation of context menu

ngraham updated this revision to Diff 53406. ngraham added a comment. Updating per VDG comments in chat: - Move the Task Manager section to the top so the Close button is on the very bottom again - Use standard menu section headers instead of fake custom-synthesized ones REPOSITORY

D19606: [Task Manager] Reorganize and improve presentation of context menu

ngraham added a comment. One issue I have with this patch is that sometimes the Alternatives menu item doesn't appear under the right conditions anymore, and I need to do `visible: alternativesAction && !alternativesAction.visible` instead, which is obviously wrong. This doesn't happen all