D19631: [sddm-theme/lock screen] Overhaul font sizes

[Nathaniel Graham]

ngraham added a comment.


  In D19631#467171 , @filipf wrote:
  
  > We could also increase the width of each of the button's container, 
basically what this shows I guess is the Shut Down button barely fits in one 
row. I'll look into it.
  
  
  +1. I don't see any particular reason why the buttons need to be so close 
together.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19631

To: rooty, #vdg, #plasma, ngraham, filipf
Cc: rikmills, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D19631: [sddm-theme/lock screen] Overhaul font sizes

[Filip Fila]

filipf added a comment.


  In D19631#467170 , @rikmills wrote:
  
  > > ! In D19631#467167 , @filipf 
wrote:
  > > 
  > > Why does it look different than Neon?
  >
  > Seems neon have a settings tweak to force more font Noto (especially for 
sddm).
  >
  > Cherry picking that...
  
  
  We could also increase the width of each of the button's container, basically 
what this shows I guess is the Shut Down button barely fits in one row. I'll 
look into it.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19631

To: rooty, #vdg, #plasma, ngraham, filipf
Cc: rikmills, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D19631: [sddm-theme/lock screen] Overhaul font sizes

[Rik Mills]

rikmills added a comment.


  > ! In D19631#467167 , @filipf 
wrote:
  > 
  > Why does it look different than Neon?
  
  Seems neon have a settings tweak to force more font Noto (especially for 
sddm).
  
  Cherry picking that...

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19631

To: rooty, #vdg, #plasma, ngraham, filipf
Cc: rikmills, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D19631: [sddm-theme/lock screen] Overhaul font sizes

[Filip Fila]

filipf added a comment.


  In D19631#467156 , @rikmills wrote:
  
  > Not looking good.
  >
  > F6835091: c0924558f6.png 
  
  
  Why does it look different than Neon?
  
  F6835124: image.png 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19631

To: rooty, #vdg, #plasma, ngraham, filipf
Cc: rikmills, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D19631: [sddm-theme/lock screen] Overhaul font sizes

[Rik Mills]

rikmills added a comment.


  Not looking good.
  
  F6835091: c0924558f6.png 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19631

To: rooty, #vdg, #plasma, ngraham, filipf
Cc: rikmills, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D19631: [sddm-theme/lock screen] Overhaul font sizes

[Krešimir Čohar]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:d3aa8b07c168: [sddm-theme/lock screen] Overhaul font 
sizes (authored by rooty).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19631?vs=54020=54024

REVISION DETAIL
  https://phabricator.kde.org/D19631

AFFECTED FILES
  lookandfeel/contents/components/ActionButton.qml
  lookandfeel/contents/components/Battery.qml
  lookandfeel/contents/components/KeyboardLayoutButton.qml
  lookandfeel/contents/components/SessionManagementScreen.qml
  lookandfeel/contents/components/UserDelegate.qml
  lookandfeel/contents/lockscreen/LockScreenUi.qml
  lookandfeel/contents/lockscreen/MediaControls.qml
  lookandfeel/contents/logout/Logout.qml
  lookandfeel/contents/logout/LogoutButton.qml
  sddm-theme/KeyboardButton.qml
  sddm-theme/Login.qml
  sddm-theme/SessionButton.qml
  sddm-theme/theme.conf.cmake

To: rooty, #vdg, #plasma, ngraham, filipf
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19631: [sddm-theme/lock screen] Overhaul font sizes

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  I love it.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  arcpatch-D19631

REVISION DETAIL
  https://phabricator.kde.org/D19631

To: rooty, #vdg, #plasma, ngraham, filipf
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19631: [sddm-theme/lock screen] Overhaul font sizes

[Krešimir Čohar]

rooty updated this revision to Diff 54020.
rooty added a comment.


  Remove extra character

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19631?vs=54019=54020

BRANCH
  arcpatch-D19631

REVISION DETAIL
  https://phabricator.kde.org/D19631

AFFECTED FILES
  lookandfeel/contents/components/ActionButton.qml
  lookandfeel/contents/components/Battery.qml
  lookandfeel/contents/components/KeyboardLayoutButton.qml
  lookandfeel/contents/components/SessionManagementScreen.qml
  lookandfeel/contents/components/UserDelegate.qml
  lookandfeel/contents/lockscreen/LockScreenUi.qml
  lookandfeel/contents/lockscreen/MediaControls.qml
  lookandfeel/contents/logout/Logout.qml
  lookandfeel/contents/logout/LogoutButton.qml
  sddm-theme/KeyboardButton.qml
  sddm-theme/Login.qml
  sddm-theme/SessionButton.qml
  sddm-theme/theme.conf.cmake

To: rooty, #vdg, #plasma, ngraham, filipf
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19631: [sddm-theme/lock screen] Overhaul font sizes

[Krešimir Čohar]

rooty updated this revision to Diff 54019.
rooty added a comment.


  Make it work for the lock screen too

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19631?vs=54018=54019

BRANCH
  arcpatch-D19631

REVISION DETAIL
  https://phabricator.kde.org/D19631

AFFECTED FILES
  lookandfeel/contents/components/ActionButton.qml
  lookandfeel/contents/components/Battery.qml
  lookandfeel/contents/components/KeyboardLayoutButton.qml
  lookandfeel/contents/components/SessionManagementScreen.qml
  lookandfeel/contents/components/UserDelegate.qml
  lookandfeel/contents/lockscreen/LockScreenUi.qml
  lookandfeel/contents/lockscreen/MediaControls.qml
  lookandfeel/contents/logout/Logout.qml
  lookandfeel/contents/logout/LogoutButton.qml
  sddm-theme/KeyboardButton.qml
  sddm-theme/Login.qml
  sddm-theme/SessionButton.qml
  sddm-theme/theme.conf.cmake

To: rooty, #vdg, #plasma, ngraham, filipf
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19631: [sddm-theme/lock screen] Overhaul font sizes

[Krešimir Čohar]

rooty updated this revision to Diff 54018.
rooty added a comment.


  Implement changes in keyboard layout button

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19631?vs=54017=54018

BRANCH
  arcpatch-D19631

REVISION DETAIL
  https://phabricator.kde.org/D19631

AFFECTED FILES
  lookandfeel/contents/components/ActionButton.qml
  lookandfeel/contents/components/Battery.qml
  lookandfeel/contents/components/KeyboardLayoutButton.qml
  lookandfeel/contents/components/SessionManagementScreen.qml
  lookandfeel/contents/components/UserDelegate.qml
  lookandfeel/contents/lockscreen/LockScreenUi.qml
  lookandfeel/contents/lockscreen/MediaControls.qml
  lookandfeel/contents/logout/Logout.qml
  lookandfeel/contents/logout/LogoutButton.qml
  sddm-theme/KeyboardButton.qml
  sddm-theme/Login.qml
  sddm-theme/SessionButton.qml
  sddm-theme/theme.conf.cmake

To: rooty, #vdg, #plasma, ngraham, filipf
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19631: [sddm-theme/lock screen] Overhaul font sizes

[Krešimir Čohar]

rooty updated this revision to Diff 54017.
rooty added a comment.


  Add battery font size configuration

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19631?vs=54012=54017

BRANCH
  arcpatch-D19631

REVISION DETAIL
  https://phabricator.kde.org/D19631

AFFECTED FILES
  lookandfeel/contents/components/ActionButton.qml
  lookandfeel/contents/components/Battery.qml
  lookandfeel/contents/components/SessionManagementScreen.qml
  lookandfeel/contents/components/UserDelegate.qml
  lookandfeel/contents/lockscreen/LockScreenUi.qml
  lookandfeel/contents/lockscreen/MediaControls.qml
  lookandfeel/contents/logout/Logout.qml
  lookandfeel/contents/logout/LogoutButton.qml
  sddm-theme/KeyboardButton.qml
  sddm-theme/Login.qml
  sddm-theme/SessionButton.qml
  sddm-theme/theme.conf.cmake

To: rooty, #vdg, #plasma, ngraham, filipf
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19631: [sddm-theme/lock screen] Overhaul font sizes

[Krešimir Čohar]

rooty updated this revision to Diff 54012.
rooty marked an inline comment as done.
rooty added a comment.


  Make property less restricted

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19631?vs=54005=54012

BRANCH
  arcpatch-D19631

REVISION DETAIL
  https://phabricator.kde.org/D19631

AFFECTED FILES
  lookandfeel/contents/components/ActionButton.qml
  lookandfeel/contents/components/SessionManagementScreen.qml
  lookandfeel/contents/components/UserDelegate.qml
  lookandfeel/contents/lockscreen/LockScreenUi.qml
  lookandfeel/contents/lockscreen/MediaControls.qml
  lookandfeel/contents/logout/Logout.qml
  lookandfeel/contents/logout/LogoutButton.qml
  sddm-theme/KeyboardButton.qml
  sddm-theme/Login.qml
  sddm-theme/SessionButton.qml
  sddm-theme/theme.conf.cmake

To: rooty, #vdg, #plasma, ngraham, filipf
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19631: [sddm-theme/lock screen] Overhaul font sizes

[Krešimir Čohar]

rooty marked an inline comment as done.
rooty added inline comments.

INLINE COMMENTS

> ngraham wrote in MediaControls.qml:126
> These changes will worsen the problem of the song/artist name getting cut off 
> when they're even marginally long. I would be in favor of fixing that (in 
> another patch :) ).

Yes it was huge, sorry

REPOSITORY
  R120 Plasma Workspace

BRANCH
  arcpatch-D19631

REVISION DETAIL
  https://phabricator.kde.org/D19631

To: rooty, #vdg, #plasma, ngraham, filipf
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19631: [sddm-theme/lock screen] Overhaul font sizes

[Krešimir Čohar]

rooty updated this revision to Diff 54005.
rooty added a comment.


  Use track and artist style from D17073 

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19631?vs=53632=54005

BRANCH
  arcpatch-D19631

REVISION DETAIL
  https://phabricator.kde.org/D19631

AFFECTED FILES
  lookandfeel/contents/components/ActionButton.qml
  lookandfeel/contents/components/SessionManagementScreen.qml
  lookandfeel/contents/components/UserDelegate.qml
  lookandfeel/contents/lockscreen/LockScreenUi.qml
  lookandfeel/contents/lockscreen/MediaControls.qml
  lookandfeel/contents/logout/Logout.qml
  lookandfeel/contents/logout/LogoutButton.qml
  sddm-theme/KeyboardButton.qml
  sddm-theme/Login.qml
  sddm-theme/SessionButton.qml
  sddm-theme/theme.conf.cmake

To: rooty, #vdg, #plasma, ngraham, filipf
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19631: [sddm-theme/lock screen] Overhaul font sizes

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Yeah, I think this is sane enough now. :)

INLINE COMMENTS

> MediaControls.qml:126
>  Layout.fillWidth: true
> -level: 5
> +level: 4
>  wrapMode: Text.NoWrap

These changes will worsen the problem of the song/artist name getting cut off 
when they're even marginally long. I would be in favor of fixing that (in 
another patch :) ).

REPOSITORY
  R120 Plasma Workspace

BRANCH
  arcpatch-D19631

REVISION DETAIL
  https://phabricator.kde.org/D19631

To: rooty, #vdg, #plasma, ngraham, filipf
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19631: [sddm-theme/lock screen] Overhaul font sizes

[Filip Fila]

filipf accepted this revision as: filipf.
filipf added a comment.


  If we're not going to be able to change SDDM's default font, this is the 
second best solution.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19631

To: rooty, #vdg, #plasma, ngraham, filipf
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19631: [sddm-theme/lock screen] Overhaul font sizes

[Krešimir Čohar]

rooty updated this revision to Diff 53632.
rooty added a comment.


  Use Math.max instead of OR (works with other distros now)

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19631?vs=53577=53632

BRANCH
  arcpatch-D19631

REVISION DETAIL
  https://phabricator.kde.org/D19631

AFFECTED FILES
  lookandfeel/contents/components/ActionButton.qml
  lookandfeel/contents/components/SessionManagementScreen.qml
  lookandfeel/contents/components/UserDelegate.qml
  lookandfeel/contents/lockscreen/LockScreenUi.qml
  lookandfeel/contents/lockscreen/MediaControls.qml
  lookandfeel/contents/logout/Logout.qml
  lookandfeel/contents/logout/LogoutButton.qml
  sddm-theme/KeyboardButton.qml
  sddm-theme/Login.qml
  sddm-theme/SessionButton.qml
  sddm-theme/theme.conf.cmake

To: rooty, #vdg, #plasma, ngraham, filipf
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19631: [sddm-theme/lock screen] Overhaul font sizes

[Filip Fila]

filipf added a comment.


  Looks good now, but let's see if we could simply change SDDM to default to 
10pt like the desktop instead of 9pt. @davidedmundson do you perhaps know where 
we could change this setting?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19631

To: rooty, #vdg, #plasma, ngraham, filipf
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19631: [sddm-theme/lock screen] Overhaul font sizes

[Krešimir Čohar]

rooty updated this revision to Diff 53577.
rooty added a comment.


  Missed one

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19631?vs=53576=53577

BRANCH
  revert-more (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19631

AFFECTED FILES
  lookandfeel/contents/components/ActionButton.qml
  lookandfeel/contents/components/SessionManagementScreen.qml
  lookandfeel/contents/components/UserDelegate.qml
  lookandfeel/contents/lockscreen/LockScreenUi.qml
  lookandfeel/contents/lockscreen/MediaControls.qml
  lookandfeel/contents/logout/Logout.qml
  lookandfeel/contents/logout/LogoutButton.qml
  sddm-theme/KeyboardButton.qml
  sddm-theme/Login.qml
  sddm-theme/SessionButton.qml
  sddm-theme/theme.conf.cmake

To: rooty, #vdg, #plasma, ngraham, filipf
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19631: [sddm-theme/lock screen] Overhaul font sizes

[Krešimir Čohar]

rooty updated this revision to Diff 53576.
rooty added a comment.


  Simplify

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19631?vs=53561=53576

BRANCH
  revert-more (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19631

AFFECTED FILES
  lookandfeel/contents/components/ActionButton.qml
  lookandfeel/contents/components/SessionManagementScreen.qml
  lookandfeel/contents/components/UserDelegate.qml
  lookandfeel/contents/lockscreen/LockScreenUi.qml
  lookandfeel/contents/lockscreen/MediaControls.qml
  lookandfeel/contents/logout/Logout.qml
  lookandfeel/contents/logout/LogoutButton.qml
  sddm-theme/KeyboardButton.qml
  sddm-theme/Login.qml
  sddm-theme/SessionButton.qml
  sddm-theme/theme.conf.cmake

To: rooty, #vdg, #plasma, ngraham, filipf
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19631: [sddm-theme/lock screen] Overhaul font sizes

[Krešimir Čohar]

rooty updated this revision to Diff 53561.
rooty edited the summary of this revision.
rooty added a comment.


  Make the logout screen work too

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19631?vs=53557=53561

BRANCH
  revert-more (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19631

AFFECTED FILES
  lookandfeel/contents/components/ActionButton.qml
  lookandfeel/contents/components/SessionManagementScreen.qml
  lookandfeel/contents/components/UserDelegate.qml
  lookandfeel/contents/lockscreen/LockScreenUi.qml
  lookandfeel/contents/lockscreen/MediaControls.qml
  lookandfeel/contents/logout/Logout.qml
  lookandfeel/contents/logout/LogoutButton.qml
  sddm-theme/KeyboardButton.qml
  sddm-theme/Login.qml
  sddm-theme/SessionButton.qml
  sddm-theme/theme.conf.cmake

To: rooty, #vdg, #plasma, ngraham, filipf
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19631: [sddm-theme/lock screen] Overhaul font sizes

[Krešimir Čohar]

rooty added a comment.


  Can anyone please help - how do I tell Main.qml to set the integer 
"nameFontSize" to 12 pt? My knowledge here is very limited and nothing I've 
tried has worked :/

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19631

To: rooty, #vdg, #plasma, ngraham, filipf
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19631: [sddm-theme/lock screen] Overhaul font sizes

[Krešimir Čohar]

rooty updated this revision to Diff 53518.
rooty edited the summary of this revision.
rooty added a comment.


  (WIP) Switch back to the default theme font + 1 (or 2) for the lock screen

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19631?vs=53498=53518

BRANCH
  revert-more (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19631

AFFECTED FILES
  lookandfeel/contents/components/ActionButton.qml
  lookandfeel/contents/components/UserDelegate.qml
  lookandfeel/contents/components/UserList.qml
  lookandfeel/contents/lockscreen/LockScreenUi.qml
  lookandfeel/contents/lockscreen/MediaControls.qml
  lookandfeel/contents/logout/LogoutButton.qml
  sddm-theme/KeyboardButton.qml
  sddm-theme/Login.qml
  sddm-theme/Main.qml
  sddm-theme/SessionButton.qml

To: rooty, #vdg, #plasma, ngraham, filipf
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19631: [sddm-theme/lock screen] Overhaul font sizes

[Krešimir Čohar]

rooty added a comment.


  > What hardcoding font sizes gives us are 2 places in Plasma losing their 
flexibility and not taking the user's preferences into consideration = SDDM-ing 
it.
  
  Then the solution is obvious - we should make the sddm theme (SDDM itself) 
more customizable (theme.conf?).
  
  > The core reason isn't strong enough either, especially given that SDDM is 
not a pre-requisite for using Plasma.
  
  What do you mean? I never said it was.
  
  > Frankly I'd rather have inconsistency than hardcoded font sizes in Plasma.
  
  I would rather not.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19631

To: rooty, #vdg, #plasma, ngraham, filipf
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19631: [sddm-theme/lock screen] Overhaul font sizes

[Filip Fila]

filipf added a comment.


  In D19631#427731 , @rooty wrote:
  
  > In D19631#427726 , @filipf wrote:
  >
  > > There has to be a better solution. We're dragging the quality of Plasma 
down simply because SDDM isn't on par with it. If there's no other way, 
hardcoded font sizes should only be present in SDDM.
  >
  >
  > I'm actually not really sure about this being a bad solution
  >  Hardcoding font sizes gives us total control over our environment, which 
might not be a bad thing in the long run (in case we want to hard-code settings 
that point to a .conf file, for greater versatility).
  
  
  What hardcoding font sizes gives us are 2 places in Plasma losing their 
flexibility and not taking the user's preferences into consideration = SDDM-ing 
it. The core reason isn't strong enough either, especially given that SDDM is 
not a pre-requisite for using Plasma.
  
  > As far as the lock screen goes, if you separate the SDDM font sizes from 
the lock screen font sizes, there's a glaring inconsistency between them.
  
  Frankly I'd rather have inconsistency than hardcoded font sizes in Plasma.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19631

To: rooty, #vdg, #plasma, ngraham, filipf
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19631: [sddm-theme/lock screen] Overhaul font sizes

[Krešimir Čohar]

rooty added a comment.


  In D19631#427726 , @filipf wrote:
  
  > There has to be a better solution. We're dragging the quality of Plasma 
down simply because SDDM isn't on par with it. If there's no other way, 
hardcoded font sizes should only be present in SDDM.
  
  
  I'm actually not really sure about this being a bad solution.
  Hardcoding font sizes gives us total control over our environment, which 
might not be a bad thing in the long run (in case we want to hard-code settings 
that point to a .conf file, for greater versatility).
  As far as the lock screen goes, if you separate the SDDM font sizes from the 
lock screen font sizes, there's a glaring inconsistency between them.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19631

To: rooty, #vdg, #plasma, ngraham, filipf
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19631: [sddm-theme/lock screen] Overhaul font sizes

[Krešimir Čohar]

rooty added a subscriber: davidedmundson.
rooty added a comment.


  @davidedmundson thoughts?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19631

To: rooty, #vdg, #plasma, ngraham, filipf
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19631: [sddm-theme/lock screen] Overhaul font sizes

[Filip Fila]

filipf requested changes to this revision.
filipf added a comment.
This revision now requires changes to proceed.


  There has to be a better solution. We're dragging the quality of Plasma down 
simply because SDDM isn't on par with it. If there's no other way, hardcoded 
font sizes should only be present in SDDM.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19631

To: rooty, #vdg, #plasma, ngraham, filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19631: [sddm-theme/lock screen] Overhaul font sizes

[Krešimir Čohar]

rooty created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
rooty requested review of this revision.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  revert-more (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19631

AFFECTED FILES
  lookandfeel/contents/components/ActionButton.qml
  lookandfeel/contents/components/KeyboardLayoutButton.qml
  lookandfeel/contents/components/SessionManagementScreen.qml
  lookandfeel/contents/components/UserDelegate.qml
  lookandfeel/contents/lockscreen/LockScreenUi.qml
  lookandfeel/contents/lockscreen/MainBlock.qml
  lookandfeel/contents/lockscreen/MediaControls.qml
  sddm-theme/KeyboardButton.qml
  sddm-theme/Login.qml
  sddm-theme/SessionButton.qml

To: rooty
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart