D19662: Fix Qmake based build

2019-03-11 Thread Carl Schwan 
This revision was automatically updated to reflect the committed changes.
Closed by commit R169:f7100e2c9ca6: Fix Qmake based build (authored by ognarb).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19662?vs=53621=53664

REVISION DETAIL
  https://phabricator.kde.org/D19662

AFFECTED FILES
  kirigami.qrc

To: ognarb, #kirigami, mart
Cc: mart, plasma-devel, domson, dkardarakos, apol, davidedmundson, hein

D19662: Fix Qmake based build

2019-03-11 Thread Marco Martin 
mart requested changes to this revision.
mart added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kirigami.qrc:21
>   alias="ActionTextField.qml">src/controls/ActionTextField.qml
> - alias="private/PrivateActionToolButton.qml">src/controls/private/PrivateActionToolButton.qml
>   alias="private/GlobalDrawerActionItem.qml">src/controls/private/GlobalDrawerActionItem.qml

this file still exists

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D19662

To: ognarb, #kirigami, mart
Cc: mart, plasma-devel, domson, dkardarakos, apol, davidedmundson, hein

D19662: Fix Qmake based build

2019-03-10 Thread Carl Schwan 
ognarb created this revision.
ognarb added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
ognarb requested review of this revision.

REVISION SUMMARY
  This patch should resolve 
https://www.reddit.com/r/kde/comments/azgfbj/cant_compile_kirigami_for_android/
  
  Also fix a warning duplicate entry in qrc

TEST PLAN
  Build with cmake and qmake works

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19662

AFFECTED FILES
  kirigami.qrc

To: ognarb, #kirigami
Cc: plasma-devel, domson, dkardarakos, apol, davidedmundson, mart, hein