D19669: [binary-clock] Port configuration window to QQC2 and Kirigami.FormLayout

[Filip Fila]

This revision was automatically updated to reflect the committed changes.
Closed by commit R114:7437b39cf8d0: [binary-clock] Port configuration window to 
QQC2 and Kirigami.FormLayout (authored by filipf).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19669?vs=53821=53842

REVISION DETAIL
  https://phabricator.kde.org/D19669

AFFECTED FILES
  applets/binary-clock/package/contents/ui/configGeneral.qml

To: filipf, #vdg, #plasma, ngraham
Cc: abetts, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19669: [binary-clock] Port configuration window to QQC2 and Kirigami.FormLayout

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  LGTM!

REPOSITORY
  R114 Plasma Addons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19669

To: filipf, #vdg, #plasma, ngraham
Cc: abetts, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19669: [binary-clock] Port configuration window to QQC2 and Kirigami.FormLayout

[Filip Fila]

filipf updated this revision to Diff 53821.
filipf added a comment.


  fix anchors & imports

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19669?vs=53760=53821

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19669

AFFECTED FILES
  applets/binary-clock/package/contents/ui/configGeneral.qml

To: filipf, #vdg, #plasma, ngraham
Cc: abetts, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19669: [binary-clock] Port configuration window to QQC2 and Kirigami.FormLayout

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D19669

To: filipf, #vdg, #plasma, ngraham
Cc: abetts, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19669: [binary-clock] Port configuration window to QQC2 and Kirigami.FormLayout

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> configGeneral.qml:23
>  
> -import QtQuick 2.0
> -import QtQuick.Controls 1.0 as QtControls
> -import QtQuick.Layouts 1.1
> +import QtQuick 2.12
> +import QtQuick.Controls 2.5 as QtControls

Is this actually necessary for anything in the diff? If not, I would recommend 
against changing it.

> configGeneral.qml:31
>  id: generalConfigPage
> +anchors.horizontalCenter: parent.horizontalCenter
>  

Anchor left and right to the parent's left and right, or else if we ever decide 
to make the formlayout not horizontally centered, this layout won't get that 
change automatically.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D19669

To: filipf, #vdg, #plasma, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19669: [binary-clock] Port configuration window to QQC2 and Kirigami.FormLayout

[Filip Fila]

filipf updated this revision to Diff 53760.
filipf added a comment.


  color pickers in the same row as their option; drop top-level Item

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19669?vs=53628=53760

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19669

AFFECTED FILES
  applets/binary-clock/package/contents/ui/configGeneral.qml

To: filipf, #vdg, #plasma
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19669: [binary-clock] Port configuration window to QQC2 and Kirigami.FormLayout

[Nathaniel Graham]

ngraham added a comment.


  In D19669#428757 , @filipf wrote:
  
  > F6682649: Screenshot_20190311_011501.png 

  
  
  I vote for this one, or else for putting the color wells below their text and 
slightly indented.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D19669

To: filipf, #vdg, #plasma
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19669: [binary-clock] Port configuration window to QQC2 and Kirigami.FormLayout

[Filip Fila]

filipf added a comment.


  Alternative looks:
  
  F6682650: Screenshot_20190311_012333.png 

  
  F6682649: Screenshot_20190311_011501.png 


REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D19669

To: filipf, #vdg, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19669: [binary-clock] Port configuration window to QQC2 and Kirigami.FormLayout

[Filip Fila]

filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REPOSITORY
  R114 Plasma Addons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19669

AFFECTED FILES
  applets/binary-clock/package/contents/ui/configGeneral.qml

To: filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart