D19675: Do not use SYSTEM when including header paths
hannahk added a comment. I don't have commit access Plz push this with: Hannah Kiekens hannahkiek...@gmail.com REPOSITORY R97 Bluedevil REVISION DETAIL https://phabricator.kde.org/D19675 To: hannahk, #plasma, drosca, apol Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D19675: Do not use SYSTEM when including header paths
This revision was automatically updated to reflect the committed changes. Closed by commit R97:9ee6488290a8: Do not use SYSTEM when including header paths (authored by hannahk, committed by nicolasfella). REPOSITORY R97 Bluedevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19675?vs=53641=53649 REVISION DETAIL https://phabricator.kde.org/D19675 AFFECTED FILES src/kio/bluetooth/CMakeLists.txt To: hannahk, #plasma, drosca, apol Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D19675: Do not use SYSTEM when including header paths
hannahk created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. hannahk requested review of this revision. REVISION SUMMARY Using SYSTEM here forces CMake to pass -isystem to gcc. This breaks crosscompiling on multiple occasions This incorrectly tells gcc that BluezQt include dir is of system inportance TEST PLAN Crosscompiling with KDE Yocto project to raspberrypi3 REPOSITORY R97 Bluedevil REVISION DETAIL https://phabricator.kde.org/D19675 AFFECTED FILES src/kio/bluetooth/CMakeLists.txt To: hannahk Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
