D19873: [image-wallpaper] WIP: Port to Kirigami.FormLayout and use twinFormLayouts

[Filip Fila]

filipf updated this revision to Diff 54484.
filipf added a comment.


  port everything

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19873?vs=54460=54484

BRANCH
  fix-hor-alignment (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19873

AFFECTED FILES
  wallpapers/image/imagepackage/contents/ui/config.qml

To: filipf, #plasma, ngraham, mart
Cc: davidre, mart, abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D19873: [image-wallpaper] WIP: Port to Kirigami.FormLayout and use twinFormLayouts

[David Redondo]

davidre added a comment.


  Great! I see that also  fixes the issue that the label vanished when the 
window got to narrow.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19873

To: filipf, #plasma, ngraham, mart
Cc: davidre, mart, abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D19873: [image-wallpaper] WIP: Port to Kirigami.FormLayout and use twinFormLayouts

[Filip Fila]

filipf added a comment.


  In D19873#434949 , @mart wrote:
  
  > So,
  >  FormLayout has api to align two or more of them with each other, which is 
the list property FormLayout.twinFormLayouts
  >
  > I wonder if there is a way to make the parent and child formlayouts visible 
ot each other to use such property.
  >
  > the parent is in 
plasma-desktop/desktoppackage/contents/configuration/ConfigurationContainmentAppearance.qml,
 loading the individual wallpapers config in the stackview at line 162.
  >
  > so, we could try something like:
  >  the wallpaper configs will expose a formLayout property.
  >  the main formLayout has something like
  >  twinFormLayouts: stack.item && stack.item.formLayout ? 
[stack.item.formLayout] : []
  >
  > then the parent layout may be i guess injected at instantiation as a 
property of the wallpaper plugin, so the child formlayout can set 
twinformlayouts as well
  >
  > this is all untested, so is a bit of R project, but if you would like to 
give a try it may be finally the properfix(tm)
  
  
  This works!!! Thank you :D
  
  For tonight I can only offer a sneak peak: the port for this "Positioning:" 
row, as well as the groundwork in D19932 . 
But if the code is right we could port all of the wallpaper plugins pretty fast.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19873

To: filipf, #plasma, ngraham
Cc: davidre, mart, abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol