D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Fabian Vogt]

fvogt added a comment.


  In D20186#465586 , @ngraham wrote:
  
  > Also keep in mind that it's possible to have global config files in 
`/etc/X11/xorg.conf.d/` I have one such file there myself that I made to work 
around the lack of this feature being implemented yet:
  >
  >   $  cat /etc/X11/xorg.conf.d/99-libinput.conf
  >   Section "InputClass"
  >   Identifier "libinput touchpad catchall"
  >   MatchIsTouchpad "on"
  >   MatchDevicePath "/dev/input/event*"
  >   Driver "libinput"
  >   Option "ClickMethod" "clickfinger" # other option is "buttonareas"
  >   Option "DisableWhileTyping" "false"
  >   Option "AccelSpeed" "0.2"
  >   #Option "MiddleEmulation" "true" # Only use this with the 
"buttonareas" clickmethod
  >   EndSection
  >
  >
  > Others may have similar settings. If possible, it might be nice to read 
these config files to determine the default option state in the KCM. Then once 
the user modifies anything, a new user-specific config file gets written that 
takes priority.
  
  
  AFAIK those options are what
  
  In D20186#465670 , @atulbi wrote:
  
  > In D20186#465586 , @ngraham 
wrote:
  >
  > > Also keep in mind that it's possible to have global config files in 
`/etc/X11/xorg.conf.d/` I have one such file there myself that I made to work 
around the lack of this feature being implemented yet:
  > >
  > >   $  cat /etc/X11/xorg.conf.d/99-libinput.conf
  > >   Section "InputClass"
  > >   Identifier "libinput touchpad catchall"
  > >   MatchIsTouchpad "on"
  > >   MatchDevicePath "/dev/input/event*"
  > >   Driver "libinput"
  > >   Option "ClickMethod" "clickfinger" # other option is 
"buttonareas"
  > >   Option "DisableWhileTyping" "false"
  > >   Option "AccelSpeed" "0.2"
  > >   #Option "MiddleEmulation" "true" # Only use this with the 
"buttonareas" clickmethod
  > >   EndSection
  > >
  > >
  > > Others may have similar settings. If possible, it might be nice to read 
these config files to determine the default option state in the KCM. Then once 
the user modifies anything, a new user-specific config file gets written that 
takes priority.
  >
  >
  > Is there any specific library which could read these files ??
  
  
  AFAIK this is not necessary. The configuration here simply specifies the 
default values for the properties used until overwritten during runtime.
  So storing it in whatever format and applying them on device discovery is 
fine.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20186

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: fvogt, GB_2, jriddell, knambiar, plasma-devel, jraleigh, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Atul Bisht]

atulbi added a comment.


  In D20186#465586 , @ngraham wrote:
  
  > Also keep in mind that it's possible to have global config files in 
`/etc/X11/xorg.conf.d/` I have one such file there myself that I made to work 
around the lack of this feature being implemented yet:
  >
  >   $  cat /etc/X11/xorg.conf.d/99-libinput.conf
  >   Section "InputClass"
  >   Identifier "libinput touchpad catchall"
  >   MatchIsTouchpad "on"
  >   MatchDevicePath "/dev/input/event*"
  >   Driver "libinput"
  >   Option "ClickMethod" "clickfinger" # other option is "buttonareas"
  >   Option "DisableWhileTyping" "false"
  >   Option "AccelSpeed" "0.2"
  >   #Option "MiddleEmulation" "true" # Only use this with the 
"buttonareas" clickmethod
  >   EndSection
  >
  >
  > Others may have similar settings. If possible, it might be nice to read 
these config files to determine the default option state in the KCM. Then once 
the user modifies anything, a new user-specific config file gets written that 
takes priority.
  
  
  Is there any specific library which could read these files ??

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20186

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: fvogt, GB_2, jriddell, knambiar, plasma-devel, jraleigh, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Nathaniel Graham]

ngraham added a comment.


  Also keep in mind that it's possible to have global config files in 
`/etc/X11/xorg.conf.d/` I have one such file there myself that I made to work 
around the lack of this feature being implemented yet:
  
$  cat /etc/X11/xorg.conf.d/99-libinput.conf
Section "InputClass"
Identifier "libinput touchpad catchall"
MatchIsTouchpad "on"
MatchDevicePath "/dev/input/event*"
Driver "libinput"
Option "ClickMethod" "clickfinger" # other option is "buttonareas"
Option "DisableWhileTyping" "false"
Option "AccelSpeed" "0.2"
#Option "MiddleEmulation" "true" # Only use this with the 
"buttonareas" clickmethod
EndSection
  
  Others may have similar settings. If possible, it might be nice to read these 
config files to determine the default option state in the KCM. Then once the 
user modifies anything, a new user-specific config file gets written that takes 
priority.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20186

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: fvogt, GB_2, jriddell, knambiar, plasma-devel, jraleigh, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Atul Bisht]

atulbi added a comment.


  > In D20186#465395 , @romangg 
wrote:
  > 
  >> I found a grave issue now when testing though: Saved values are not 
restored on Reboot. Are they saved at all to a config file?
  >>
  >> EDIT: No, they are not. In X11 + evdev the KCM does this, not the backend. 
We need to:
  >>
  >> 1. add config file write and load functions to the X11-libinput backend
  >> 2. add a hook to kcm_init such that the load function is called on startup.
  >>
  >>   @atulbi: Do you have time to try this tomorrow?
  
  Yeah just starting to work on it. I'll try to complete it by today.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20186

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: fvogt, GB_2, jriddell, knambiar, plasma-devel, jraleigh, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Roman Gilg]

romangg added a comment.


  In D20186#465502 , @atulbi wrote:
  
  > In D20186#465361 , @ngraham 
wrote:
  >
  > > @atulbi This has caused a failure in the CI:
  > >  [...]
  > >
  > > Looks like we need to make the libinput xorg dev package a mandatory dep 
(boo) or else not build the x11 Libinput KCM if it isn't found (preferred). I 
know it's short notice but we branch in two days; do you think you could fix 
this? Thanks!
  >
  >
  > Whoops...
  >  If it's just because of "libinput-properties.h", then we could replace all 
macros with their property name, then there is no need for 
libinput-properties.h .
  
  
  This was already fixed in 8b1c894ef 
. 
What still needs to be done is:
  
  In D20186#465395 , @romangg wrote:
  
  > I found a grave issue now when testing though: Saved values are not 
restored on Reboot. Are they saved at all to a config file?
  >
  > EDIT: No, they are not. In X11 + evdev the KCM does this, not the backend. 
We need to:
  >
  > 1. add config file write and load functions to the X11-libinput backend
  > 2. add a hook to kcm_init such that the load function is called on startup.
  >
  >   @atulbi: Do you have time to try this tomorrow?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20186

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: fvogt, GB_2, jriddell, knambiar, plasma-devel, jraleigh, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Atul Bisht]

atulbi added a comment.


  In D20186#465361 , @ngraham wrote:
  
  > @atulbi This has caused a failure in the CI:
  >
  > 
https://build.kde.org/view/Failing/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/204/console
  >
  >   09:12:41  /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 
SUSEQt5.12/kcms/touchpad/src/backends/x11/libinputtouchpad.cpp:28:10: fatal 
error: libinput-properties.h: No such file or directory
  >   09:12:41   #include 
  >   09:12:41^~~
  >   09:12:41  compilation terminated.
  >
  >
  > Looks like we need to make the libinput xorg dev package a mandatory dep 
(boo) or else not build the x11 Libinput KCM if it isn't found (preferred). I 
know it's short notice but we branch in two days; do you think you could fix 
this? Thanks!
  
  
  Whoops...
  If it's just because of "libinput-properties.h", then we could replace all 
macros with their property name, then there is no need for 
libinput-properties.h .

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20186

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: fvogt, GB_2, jriddell, knambiar, plasma-devel, jraleigh, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Roman Gilg]

romangg added a comment.


  In D20186#465361 , @ngraham wrote:
  
  > @atulbi This has caused a failure in the CI:
  >
  > 
https://build.kde.org/view/Failing/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/204/console
  >
  >   09:12:41  /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 
SUSEQt5.12/kcms/touchpad/src/backends/x11/libinputtouchpad.cpp:28:10: fatal 
error: libinput-properties.h: No such file or directory
  >   09:12:41   #include 
  >   09:12:41^~~
  >   09:12:41  compilation terminated.
  >
  >
  > Looks like we need to make the libinput xorg dev package a mandatory dep 
(boo) or else not build the x11 Libinput KCM if it isn't found (preferred). I 
know it's short notice but we branch in two days; do you think you could fix 
this? Thanks!
  
  
  Of course we miss out again on these compilation corner cases... For that see 
D21220 .
  
  I found a grave issue now when testing though: Saved values are not restored 
on Reboot. Are they saved at all to a config file?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20186

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: fvogt, GB_2, jriddell, knambiar, plasma-devel, jraleigh, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Nathaniel Graham]

ngraham added a subscriber: fvogt.
ngraham added a comment.


  @atulbi This has caused a failure in the CI:
  
  
https://build.kde.org/view/Failing/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/204/console
  
09:12:41  /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 
SUSEQt5.12/kcms/touchpad/src/backends/x11/libinputtouchpad.cpp:28:10: fatal 
error: libinput-properties.h: No such file or directory
09:12:41   #include 
09:12:41^~~
09:12:41  compilation terminated.
  
  Looks like we need to make the libinput xorg package a mandatory dep (boo) or 
else not build the libinput module if it isn't found (preferred). I know it's 
short notice but we branch in two days; do you think you could fix this? Thanks!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20186

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: fvogt, GB_2, jriddell, knambiar, plasma-devel, jraleigh, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:ce84d6ab4bab: [libinput-touchpad-kcm] Use wayland 
specific touchpad KCM UI when libinput is… (authored by atulbi, committed by 
ngraham).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20186?vs=58083=58084

REVISION DETAIL
  https://phabricator.kde.org/D20186

AFFECTED FILES
  kcms/touchpad/src/backends/kwin_wayland.cmake
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandbackend.cpp
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandtouchpad.cpp
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandtouchpad.h
  kcms/touchpad/src/backends/libinputcommon.cpp
  kcms/touchpad/src/backends/libinputcommon.h
  kcms/touchpad/src/backends/x11.cmake
  kcms/touchpad/src/backends/x11/libinputtouchpad.cpp
  kcms/touchpad/src/backends/x11/libinputtouchpad.h
  kcms/touchpad/src/backends/x11/synapticstouchpad.h
  kcms/touchpad/src/backends/x11/xlibbackend.cpp
  kcms/touchpad/src/backends/x11/xlibbackend.h
  kcms/touchpad/src/backends/x11/xlibtouchpad.h
  kcms/touchpad/src/kcm/libinput/main.qml
  kcms/touchpad/src/kcm/libinput/touchpadconfiglibinput.cpp
  kcms/touchpad/src/kcm/libinput/touchpadconfiglibinput.h
  kcms/touchpad/src/kcm/touchpadconfigcontainer.cpp
  kcms/touchpad/src/kcm/touchpadconfigplugin.cpp
  kcms/touchpad/src/kcm/touchpadconfigplugin.h
  kcms/touchpad/src/kcm/xlib/touchpadconfigxlib.cpp
  kcms/touchpad/src/kcm/xlib/touchpadconfigxlib.h
  kcms/touchpad/src/touchpadbackend.cpp
  kcms/touchpad/src/touchpadbackend.h

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: GB_2, jriddell, knambiar, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Atul Bisht]

atulbi added a comment.


  In D20186#465278 , @ngraham wrote:
  
  > Are you ready for me to land this?
  
  
  Yeah \o/
  I'll take that for the next patch.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arcpatch-D20186

REVISION DETAIL
  https://phabricator.kde.org/D20186

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: GB_2, jriddell, knambiar, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  Are you ready for me to land this?

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arcpatch-D20186

REVISION DETAIL
  https://phabricator.kde.org/D20186

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: GB_2, jriddell, knambiar, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Atul Bisht]

atulbi updated this revision to Diff 58083.
atulbi added a comment.


  Set visible to false, until accel profiles are not supported.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20186?vs=58082=58083

BRANCH
  arcpatch-D20186

REVISION DETAIL
  https://phabricator.kde.org/D20186

AFFECTED FILES
  kcms/touchpad/src/backends/kwin_wayland.cmake
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandbackend.cpp
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandtouchpad.cpp
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandtouchpad.h
  kcms/touchpad/src/backends/libinputcommon.cpp
  kcms/touchpad/src/backends/libinputcommon.h
  kcms/touchpad/src/backends/x11.cmake
  kcms/touchpad/src/backends/x11/libinputtouchpad.cpp
  kcms/touchpad/src/backends/x11/libinputtouchpad.h
  kcms/touchpad/src/backends/x11/synapticstouchpad.h
  kcms/touchpad/src/backends/x11/xlibbackend.cpp
  kcms/touchpad/src/backends/x11/xlibbackend.h
  kcms/touchpad/src/backends/x11/xlibtouchpad.h
  kcms/touchpad/src/kcm/libinput/main.qml
  kcms/touchpad/src/kcm/libinput/touchpadconfiglibinput.cpp
  kcms/touchpad/src/kcm/libinput/touchpadconfiglibinput.h
  kcms/touchpad/src/kcm/touchpadconfigcontainer.cpp
  kcms/touchpad/src/kcm/touchpadconfigplugin.cpp
  kcms/touchpad/src/kcm/touchpadconfigplugin.h
  kcms/touchpad/src/kcm/xlib/touchpadconfigxlib.cpp
  kcms/touchpad/src/kcm/xlib/touchpadconfigxlib.h
  kcms/touchpad/src/touchpadbackend.cpp
  kcms/touchpad/src/touchpadbackend.h

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: GB_2, jriddell, knambiar, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Nathaniel Graham]

ngraham added a comment.


  In D20186#465267 , @atulbi wrote:
  
  > Regarding acceleration profile, maybe we should set visible to false for 
now.
  
  
  +1, let's do that in this patch
  
  > If no touchpad is connected, we could also show a large icon in middle  
with "No touchpad Detected" written below it.
  
  +1, though maybe material for a follow-up patch if you don't think you can 
get that in today. I'd really like to get this landed today or tomorrow before 
Plasma 5.16 branches so it's in for the beta.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arcpatch-D20186

REVISION DETAIL
  https://phabricator.kde.org/D20186

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: GB_2, jriddell, knambiar, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Atul Bisht]

atulbi updated this revision to Diff 58082.
atulbi added a comment.


  Finally no more greyed settings there \o/
  
  Work I've planned for future releases :
  
  - Adding support to disable horizontal scrolling on wayland.
  - Provide settings to Disable touchpad on external mouse.
  
  Regarding acceleration profile, maybe we should set visible to false for now.
  
  If no touchpad is connected, we could also show a large icon in middle  with 
"No touchpad Detected" written below it.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20186?vs=57933=58082

BRANCH
  arcpatch-D20186

REVISION DETAIL
  https://phabricator.kde.org/D20186

AFFECTED FILES
  kcms/touchpad/src/backends/kwin_wayland.cmake
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandbackend.cpp
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandtouchpad.cpp
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandtouchpad.h
  kcms/touchpad/src/backends/libinputcommon.cpp
  kcms/touchpad/src/backends/libinputcommon.h
  kcms/touchpad/src/backends/x11.cmake
  kcms/touchpad/src/backends/x11/libinputtouchpad.cpp
  kcms/touchpad/src/backends/x11/libinputtouchpad.h
  kcms/touchpad/src/backends/x11/synapticstouchpad.h
  kcms/touchpad/src/backends/x11/xlibbackend.cpp
  kcms/touchpad/src/backends/x11/xlibbackend.h
  kcms/touchpad/src/backends/x11/xlibtouchpad.h
  kcms/touchpad/src/kcm/libinput/main.qml
  kcms/touchpad/src/kcm/libinput/touchpadconfiglibinput.cpp
  kcms/touchpad/src/kcm/libinput/touchpadconfiglibinput.h
  kcms/touchpad/src/kcm/touchpadconfigcontainer.cpp
  kcms/touchpad/src/kcm/touchpadconfigplugin.cpp
  kcms/touchpad/src/kcm/touchpadconfigplugin.h
  kcms/touchpad/src/kcm/xlib/touchpadconfigxlib.cpp
  kcms/touchpad/src/kcm/xlib/touchpadconfigxlib.h
  kcms/touchpad/src/touchpadbackend.cpp
  kcms/touchpad/src/touchpadbackend.h

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: GB_2, jriddell, knambiar, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Nathaniel Graham]

ngraham added a comment.


  In D20186#464906 , @romangg wrote:
  
  > For the next release some pointers where still work could be done:
  >
  > - Touchpads do never feature acceleration profiles I believe.
  
  
  That's true for the moment, but this is planned for a future Libinput 
release. So maybe keep support in the backend just in case it ever materializes.
  
  > But for now let's celebrate finally shipping a fitting libinput KCM on X as 
well! Great job Atul! Thank you for your hard work and for being patient in the 
review process.
  
  Indeed. Party time for sure!!! Also @atulbi if you don't already have commit 
access you should seriously consider applying--especially given that you're now 
the maintainer of the touchpad KCM. See 
https://techbase.kde.org/Contribute/Get_a_Contributor_Account
  
  For now I can land this for you once you've adderssed the last of Roman's 
inline comments.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arcpatch-D20186

REVISION DETAIL
  https://phabricator.kde.org/D20186

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: GB_2, jriddell, knambiar, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Roman Gilg]

romangg accepted this revision.
romangg added a comment.
This revision is now accepted and ready to land.


  I tested it now. I think it's working robustly and should still go in the 
upcoming release. We have the beta phase to further test then.
  
  For the next release some pointers where still work could be done:
  
  - Touchpads do never feature acceleration profiles I believe. Just never show 
the all the time disabled controls. Same holds for scroll button. The 
respective backend interfaces can then be cleaned out as well.
  - There is some weirdness going on if no touchpad is connected and one opens 
the touchpad KCM. Normally all controls should be greyed out. But at least on 
Wayland they are not but instead some of them are not shown.
  
  But for now let's celebrate finally shipping a fitting libinput KCM on X as 
well! Great job Atul! Thank you for your hard work and for being patient in the 
review process.

INLINE COMMENTS

> libinputcommon.h:2
>  /*
> - * Copyright 2017 Roman Gilg 
> + * Copyright 2019 Atul Bisht 
>   *

Most of the code in this file was written by me and is now copy-pasted. Please 
keep in my copyright and add your own above/below.

> libinputcommon.h:54
>  // general
> -Q_PROPERTY(QString name READ name CONSTANT)
> -Q_PROPERTY(bool supportsDisableEvents READ supportsDisableEvents 
> CONSTANT)
> -Q_PROPERTY(bool enabled READ isEnabled WRITE setEnabled NOTIFY 
> enabledChanged)
> +Q_PROPERTY(QString name READ name CONSTANT)//
> +Q_PROPERTY(bool supportsDisableEvents READ supportsDisableEvents 
> CONSTANT)//

rm these comment markers

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arcpatch-D20186

REVISION DETAIL
  https://phabricator.kde.org/D20186

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: GB_2, jriddell, knambiar, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Atul Bisht]

atulbi updated this revision to Diff 57933.
atulbi added a comment.


  - lmr mapping working now

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20186?vs=57923=57933

BRANCH
  arcpatch-D20186

REVISION DETAIL
  https://phabricator.kde.org/D20186

AFFECTED FILES
  kcms/touchpad/src/backends/kwin_wayland.cmake
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandbackend.cpp
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandtouchpad.cpp
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandtouchpad.h
  kcms/touchpad/src/backends/libinputcommon.cpp
  kcms/touchpad/src/backends/libinputcommon.h
  kcms/touchpad/src/backends/x11.cmake
  kcms/touchpad/src/backends/x11/libinputtouchpad.cpp
  kcms/touchpad/src/backends/x11/libinputtouchpad.h
  kcms/touchpad/src/backends/x11/synapticstouchpad.h
  kcms/touchpad/src/backends/x11/xlibbackend.cpp
  kcms/touchpad/src/backends/x11/xlibbackend.h
  kcms/touchpad/src/backends/x11/xlibtouchpad.h
  kcms/touchpad/src/kcm/libinput/main.qml
  kcms/touchpad/src/kcm/libinput/touchpadconfiglibinput.cpp
  kcms/touchpad/src/kcm/libinput/touchpadconfiglibinput.h
  kcms/touchpad/src/kcm/touchpadconfigcontainer.cpp
  kcms/touchpad/src/kcm/touchpadconfigplugin.cpp
  kcms/touchpad/src/kcm/touchpadconfigplugin.h
  kcms/touchpad/src/kcm/xlib/touchpadconfigxlib.cpp
  kcms/touchpad/src/kcm/xlib/touchpadconfigxlib.h
  kcms/touchpad/src/touchpadbackend.cpp
  kcms/touchpad/src/touchpadbackend.h

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: GB_2, jriddell, knambiar, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Atul Bisht]

atulbi updated this revision to Diff 57923.
atulbi added a comment.


  - Added Copyright notice
  - Corrected asterisk placement

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20186?vs=57521=57923

BRANCH
  arcpatch-D20186

REVISION DETAIL
  https://phabricator.kde.org/D20186

AFFECTED FILES
  kcms/touchpad/src/backends/kwin_wayland.cmake
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandbackend.cpp
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandtouchpad.cpp
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandtouchpad.h
  kcms/touchpad/src/backends/libinputcommon.cpp
  kcms/touchpad/src/backends/libinputcommon.h
  kcms/touchpad/src/backends/x11.cmake
  kcms/touchpad/src/backends/x11/libinputtouchpad.cpp
  kcms/touchpad/src/backends/x11/libinputtouchpad.h
  kcms/touchpad/src/backends/x11/synapticstouchpad.h
  kcms/touchpad/src/backends/x11/xlibbackend.cpp
  kcms/touchpad/src/backends/x11/xlibbackend.h
  kcms/touchpad/src/backends/x11/xlibtouchpad.h
  kcms/touchpad/src/kcm/libinput/main.qml
  kcms/touchpad/src/kcm/libinput/touchpadconfiglibinput.cpp
  kcms/touchpad/src/kcm/libinput/touchpadconfiglibinput.h
  kcms/touchpad/src/kcm/touchpadconfigcontainer.cpp
  kcms/touchpad/src/kcm/touchpadconfigplugin.cpp
  kcms/touchpad/src/kcm/touchpadconfigplugin.h
  kcms/touchpad/src/kcm/xlib/touchpadconfigxlib.cpp
  kcms/touchpad/src/kcm/xlib/touchpadconfigxlib.h
  kcms/touchpad/src/touchpadbackend.cpp
  kcms/touchpad/src/touchpadbackend.h

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: GB_2, jriddell, knambiar, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Atul Bisht]

atulbi added inline comments.

INLINE COMMENTS

> romangg wrote in libinputtouchpad.h:57
> Why is there the negation? Put the Enabled-related function in the parent 
> class.

X provides property for the disabled, while Wayland provides property for 
enabled.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20186

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: GB_2, jriddell, knambiar, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Roman Gilg]

romangg requested changes to this revision.
romangg added a comment.
This revision now requires changes to proceed.


  Looks really nice. I have yet to try it out, but following a code review.
  
  In general it is good practice to make class member variables private and 
have protected getters/setters if child classes need to interact with them. For 
example `TouchpadBackend::m_mode`. Other cases of that are all the properties 
in the child classes of LibinputCommon. Fixing that might be difficult though 
because of the template usage. And it might induce regressions in Wayland case, 
so I would wait with that for after next release. Some more ideas I wrote in 
the inline comments for that. But the m_mode thing can be changed already in 
this diff.

INLINE COMMENTS

> libinputcommon.h:1
> -/*
> - * Copyright 2017 Roman Gilg 
> - *
> - * This program is free software; you can redistribute it and/or modify
> - * it under the terms of the GNU General Public License as published by
> - * the Free Software Foundation; either version 2 of the License, or
> - * (at your option) any later version.
> - *
> - * This program is distributed in the hope that it will be useful,
> - * but WITHOUT ANY WARRANTY; without even the implied warranty of
> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> - * GNU General Public License for more details.
> - *
> - * You should have received a copy of the GNU General Public License
> - * along with this program; if not, write to the Free Software
> - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, 
> USA.
> - */
> -
> -#ifndef KWINWAYLANDTOUCHPAD_H
> -#define KWINWAYLANDTOUCHPAD_H
> +#ifndef LIBINPUTCOMMON_H
> +#define LIBINPUTCOMMON_H

Needs copyright notice (you should of course add yourself to the notice for 
files with non-marginal changes).

> libinputtouchpad.h:54
> +bool supportsDisableEvents() const override {
> +return m_supportsDisableEvents.avail ? m_supportsDisableEvents.val : 
> false;
> +}

Equivalent and more concise is:
`return m_supportsDisableEvents.avail && m_supportsDisableEvents.val ;`
For other getters below as well.

Long term try to not access the member variables from child class though. You 
could just have these functions in the parent class and just always check if 
avail is true before accessing the value. This will change the behavior on 
Wayland backend as well, but it should be fine (let's do this after release 
though to not risk regressions).

> libinputtouchpad.h:57
> +bool isEnabled() const override {
> +return !m_enabled.val;
> +}

Why is there the negation? Put the Enabled-related function in the parent class.

> libinputtouchpad.h:65
> +bool supportsLeftHanded() const override {
> +return m_leftHanded.avail;
> +}

I get why you query the avail field of this and other properties in the X case 
and not the special property as on Wayland, but maybe there is a way to find a 
common approach for both?

Anyways stuff for after the release. It's fine this way at the moment.

> xlibtouchpad.h:48
>  {
> +Q_GADGET
> +

Necessary?

> touchpadconfiglibinput.h:35
>  explicit TouchpadConfigLibinput(TouchpadConfigContainer *parent,
> +TouchpadBackend* backend,
>  const QVariantList  = QVariantList());

Pointer asterisk goes to the right.

> touchpadconfigplugin.h:32
>  public:
> -explicit TouchpadConfigPlugin(QWidget *parent);
> +explicit TouchpadConfigPlugin(QWidget *parent, TouchpadBackend* backend);
>  virtual ~TouchpadConfigPlugin() {}

No need for explicit anymore.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20186

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: GB_2, jriddell, knambiar, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Nathaniel Graham]

ngraham added a comment.


  I'm afraid I don't think I have the technical chops to adequately review 
this, but hopefully @romangg does! :) Or any of the other #plasma 
 people.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20186

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: GB_2, jriddell, knambiar, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Atul Bisht]

atulbi added a comment.


  In D20186#462883 , @GB_2 wrote:
  
  > Ping
  
  
  Hey... Have you tried this patch ?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20186

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: GB_2, jriddell, knambiar, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Björn Feber]

GB_2 added a comment.


  Ping

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20186

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: GB_2, jriddell, knambiar, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Atul Bisht]

atulbi updated this revision to Diff 57521.
atulbi added a comment.


  - Remove CMakeLists.txt.user

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20186?vs=57520=57521

BRANCH
  arcpatch-D20186

REVISION DETAIL
  https://phabricator.kde.org/D20186

AFFECTED FILES
  kcms/touchpad/src/backends/kwin_wayland.cmake
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandbackend.cpp
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandtouchpad.cpp
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandtouchpad.h
  kcms/touchpad/src/backends/libinputcommon.cpp
  kcms/touchpad/src/backends/libinputcommon.h
  kcms/touchpad/src/backends/x11.cmake
  kcms/touchpad/src/backends/x11/libinputtouchpad.cpp
  kcms/touchpad/src/backends/x11/libinputtouchpad.h
  kcms/touchpad/src/backends/x11/synapticstouchpad.h
  kcms/touchpad/src/backends/x11/xlibbackend.cpp
  kcms/touchpad/src/backends/x11/xlibbackend.h
  kcms/touchpad/src/backends/x11/xlibtouchpad.cpp
  kcms/touchpad/src/backends/x11/xlibtouchpad.h
  kcms/touchpad/src/kcm/libinput/main.qml
  kcms/touchpad/src/kcm/libinput/touchpadconfiglibinput.cpp
  kcms/touchpad/src/kcm/libinput/touchpadconfiglibinput.h
  kcms/touchpad/src/kcm/touchpadconfigcontainer.cpp
  kcms/touchpad/src/kcm/touchpadconfigplugin.cpp
  kcms/touchpad/src/kcm/touchpadconfigplugin.h
  kcms/touchpad/src/kcm/xlib/touchpadconfigxlib.cpp
  kcms/touchpad/src/kcm/xlib/touchpadconfigxlib.h
  kcms/touchpad/src/touchpadbackend.h

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: jriddell, knambiar, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Atul Bisht]

atulbi updated this revision to Diff 57520.
atulbi added a comment.


- Changes Made :
  1. Added abstract class LibinputCommon.
  2. All the Q_PROPERTY are in LibinputCommon.
  3. Added Disable Horizontal Support on X11 on Libinput.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20186?vs=57519=57520

BRANCH
  arcpatch-D20186

REVISION DETAIL
  https://phabricator.kde.org/D20186

AFFECTED FILES
  CMakeLists.txt.user
  kcms/touchpad/src/backends/kwin_wayland.cmake
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandbackend.cpp
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandtouchpad.cpp
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandtouchpad.h
  kcms/touchpad/src/backends/libinputcommon.cpp
  kcms/touchpad/src/backends/libinputcommon.h
  kcms/touchpad/src/backends/x11.cmake
  kcms/touchpad/src/backends/x11/libinputtouchpad.cpp
  kcms/touchpad/src/backends/x11/libinputtouchpad.h
  kcms/touchpad/src/backends/x11/synapticstouchpad.h
  kcms/touchpad/src/backends/x11/xlibbackend.cpp
  kcms/touchpad/src/backends/x11/xlibbackend.h
  kcms/touchpad/src/backends/x11/xlibtouchpad.cpp
  kcms/touchpad/src/backends/x11/xlibtouchpad.h
  kcms/touchpad/src/kcm/libinput/main.qml
  kcms/touchpad/src/kcm/libinput/touchpadconfiglibinput.cpp
  kcms/touchpad/src/kcm/libinput/touchpadconfiglibinput.h
  kcms/touchpad/src/kcm/touchpadconfigcontainer.cpp
  kcms/touchpad/src/kcm/touchpadconfigplugin.cpp
  kcms/touchpad/src/kcm/touchpadconfigplugin.h
  kcms/touchpad/src/kcm/xlib/touchpadconfigxlib.cpp
  kcms/touchpad/src/kcm/xlib/touchpadconfigxlib.h
  kcms/touchpad/src/touchpadbackend.h

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: jriddell, knambiar, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Atul Bisht]

atulbi updated this revision to Diff 57519.
atulbi added a comment.


  - Removed last commit

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20186?vs=57508=57519

BRANCH
  arcpatch-D20186

REVISION DETAIL
  https://phabricator.kde.org/D20186

AFFECTED FILES
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandbackend.cpp
  kcms/touchpad/src/backends/x11/libinputtouchpad.cpp
  kcms/touchpad/src/backends/x11/libinputtouchpad.h
  kcms/touchpad/src/backends/x11/synapticstouchpad.cpp
  kcms/touchpad/src/backends/x11/synapticstouchpad.h
  kcms/touchpad/src/backends/x11/xlibbackend.cpp
  kcms/touchpad/src/backends/x11/xlibbackend.h
  kcms/touchpad/src/backends/x11/xlibtouchpad.cpp
  kcms/touchpad/src/backends/x11/xlibtouchpad.h
  kcms/touchpad/src/kcm/libinput/touchpadconfiglibinput.cpp
  kcms/touchpad/src/kcm/libinput/touchpadconfiglibinput.h
  kcms/touchpad/src/kcm/touchpadconfigcontainer.cpp
  kcms/touchpad/src/kcm/touchpadconfigplugin.cpp
  kcms/touchpad/src/kcm/touchpadconfigplugin.h
  kcms/touchpad/src/kcm/xlib/touchpadconfigxlib.cpp
  kcms/touchpad/src/kcm/xlib/touchpadconfigxlib.h
  kcms/touchpad/src/touchpadbackend.h

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: jriddell, knambiar, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Atul Bisht]

atulbi updated this revision to Diff 57508.
atulbi added a comment.


  - Added new abstract class LibinputCommon
  - Add overriding destructor
  - Added support for disable horizontal scrolling on Libinput On X11.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20186?vs=55532=57508

BRANCH
  X11Libinput

REVISION DETAIL
  https://phabricator.kde.org/D20186

AFFECTED FILES
  kcms/touchpad/src/backends/kwin_wayland.cmake
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandtouchpad.cpp
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandtouchpad.h
  kcms/touchpad/src/backends/libinputcommon.cpp
  kcms/touchpad/src/backends/libinputcommon.h
  kcms/touchpad/src/backends/x11.cmake
  kcms/touchpad/src/backends/x11/libinputtouchpad.cpp
  kcms/touchpad/src/backends/x11/libinputtouchpad.h
  kcms/touchpad/src/backends/x11/synapticstouchpad.cpp
  kcms/touchpad/src/backends/x11/synapticstouchpad.h
  kcms/touchpad/src/backends/x11/xlibbackend.cpp
  kcms/touchpad/src/backends/x11/xlibbackend.h
  kcms/touchpad/src/backends/x11/xlibtouchpad.cpp
  kcms/touchpad/src/backends/x11/xlibtouchpad.h
  kcms/touchpad/src/kcm/libinput/main.qml
  kcms/touchpad/src/kcm/touchpadconfigcontainer.cpp

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: jriddell, knambiar, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Nathaniel Graham]

ngraham added a comment.


  Wonderful! I'll stop bugging you now. :)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20186

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: jriddell, knambiar, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Atul Bisht]

atulbi added a comment.


  In D20186#458259 , @ngraham wrote:
  
  > @atulbi were you able to get in touch with @romangg? Can I help in any way?
  >
  > The feature freeze for Plasma 5.16 is in a little over two weeks 
(https://community.kde.org/Schedules/Plasma_5) and it would really nice to 
finally have full Libinput support in our KCM in that release. Right now we'd 
still have enough time for testing because of the beta period, but we'll need 
to get it in within the next two weeks.
  
  
  Sorry for the delay. My pre-university exams will end in just 2 days. I'll 
continue the work as soon as exams are over. I'm already halfway through.
  I've found the solution to the problem though  . Now it should not take much 
time to complete.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20186

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: jriddell, knambiar, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Nathaniel Graham]

ngraham added a comment.


  @atulbi were you able to get in touch with @romangg? Can I help in any way?
  
  The feature freeze for Plasma 5.16 is in a little over two weeks 
(https://community.kde.org/Schedules/Plasma_5) and it would really nice to 
finally have full Libinput support in our KCM in that release. Right now we'd 
still have enough time for testing because of the beta period, but we'll need 
to get it in within the next two weeks.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20186

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: jriddell, knambiar, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Roman Gilg]

romangg added a comment.


  In D20186#454584 , @atulbi wrote:
  
  > In D20186#454420 , @ngraham 
wrote:
  >
  > > @atulbi ping! Does Roman's request make sense? In general I think it does 
make sense to do code clean-up in a separate patch first.
  >
  >
  > Totally!! I'm working on it... Currently facing some error. I'll contact 
Roman for help
  
  
  You can ping me on IRC. Handle/nick there same as here.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20186

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: jriddell, knambiar, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Atul Bisht]

atulbi added a comment.


  In D20186#454420 , @ngraham wrote:
  
  > @atulbi ping! Does Roman's request make sense? In general I think it does 
make sense to do code clean-up in a separate patch first.
  
  
  Totally!! I'm working on it... Currently facing some error. I'll contact 
Roman for help

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20186

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: jriddell, knambiar, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Nathaniel Graham]

ngraham added a comment.


  @atulbi ping! Does Roman's request make sense? In general I think it does 
make sense to do code clean-up in a separate patch first.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20186

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: jriddell, knambiar, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Roman Gilg]

romangg added a comment.


  In D20186#31 , @atulbi wrote:
  
  > In D20186#443596 , @romangg 
wrote:
  >
  > > Nice work. Most of the stuff in libinputtouchpad.cpp and its header file 
are copy-paste from the Wayland backend. It would make sense to have a new 
abstract parent class such that the code is shared.
  >
  >
  > Initially, I also wanted to implement it that way, but it'll mess up 
existing code, and especially because LibinputTouchpad class already extends 
XlibTouchpad class. Or split out the common parts into a helper-class.
  
  
  Can it multi-inherit?
  
  > I wanted to have minimal changes to existing code.
  
  Make a two patch series: first patch would be creating the parent class and 
let current Wayland backend inherit it. Second patch would be creating 
X11/libinput child class.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20186

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: jriddell, knambiar, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Atul Bisht]

atulbi added a comment.


  In D20186#443596 , @romangg wrote:
  
  > Nice work. Most of the stuff in libinputtouchpad.cpp and its header file 
are copy-paste from the Wayland backend. It would make sense to have a new 
abstract parent class such that the code is shared.
  
  
  Initially, I also wanted to implement it that way, but it'll mess up existing 
code, and especially because LibinputTouchpad class already extends 
XlibTouchpad class. I wanted to have minimal changes to existing code.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20186

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: jriddell, knambiar, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Atul Bisht]

atulbi updated this revision to Diff 55532.
atulbi added a comment.


  - Resolved issues

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20186?vs=55277=55532

BRANCH
  X11Libinput

REVISION DETAIL
  https://phabricator.kde.org/D20186

AFFECTED FILES
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandbackend.cpp
  kcms/touchpad/src/backends/x11/libinputtouchpad.cpp
  kcms/touchpad/src/backends/x11/libinputtouchpad.h
  kcms/touchpad/src/backends/x11/synapticstouchpad.cpp
  kcms/touchpad/src/backends/x11/synapticstouchpad.h
  kcms/touchpad/src/backends/x11/xlibbackend.cpp
  kcms/touchpad/src/backends/x11/xlibbackend.h
  kcms/touchpad/src/backends/x11/xlibtouchpad.cpp
  kcms/touchpad/src/backends/x11/xlibtouchpad.h
  kcms/touchpad/src/kcm/libinput/touchpadconfiglibinput.cpp
  kcms/touchpad/src/kcm/libinput/touchpadconfiglibinput.h
  kcms/touchpad/src/kcm/touchpadconfigcontainer.cpp
  kcms/touchpad/src/kcm/touchpadconfigplugin.cpp
  kcms/touchpad/src/kcm/touchpadconfigplugin.h
  kcms/touchpad/src/kcm/xlib/touchpadconfigxlib.cpp
  kcms/touchpad/src/kcm/xlib/touchpadconfigxlib.h
  kcms/touchpad/src/touchpadbackend.h

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: jriddell, knambiar, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Atul Bisht]

atulbi added a comment.


  In D20186#443723 , @knambiar wrote:
  
  > > Wherever you're currently listed, remove your name and replace it with 
Atul's. :) The only place I can find it on Bugzilla. I've gone ahead and made 
@atulbi the default assignee for bugs to the Touchpad-KCM product.
  >
  > @atulbi  Congratulations, you’re now the maintainer of Touchpad KCM. In 
certain countries, there’s something called “inheritance tax” and you just 
inherited a few dozen bugs. Don’t despair, many of them should be fixed by now 
and some will be fixed by this commit.
  
  
  Many of the bugs were created during my school days XD

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20186

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: jriddell, knambiar, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Atul Bisht]

atulbi added a comment.


  In D20186#443554 , @ngraham wrote:
  
  > In D20186#443262 , @knambiar 
wrote:
  >
  > > >> I happen to be the ‘accidental’ maintainer of the Touchpad KCM. I’d be 
more than happy to hand that hat over if you wish to maintain this code. :-D
  > > > 
  > > > Hey, I would be happy to take that responsibility.
  > >
  > > Fantastic.
  > >
  > > @ngraham @jriddell Would you let me know the technicalities to make Atul 
maintainer of Touchpad KCM? I couldn't find a guideline in the wiki/techbase.
  >
  >
  > Wherever you're currently listed, remove your name and replace it with 
Atul's. :) The only place I can find it on Bugzilla. I've gone ahead and made 
@atulbi the default assignee for bugs to the Touchpad-KCM product.
  >
  > @atulbi is anything special needed to compile the KCM? After compiling 
plasma-desktop with your patch, no touchpad shared library was produced.
  
  
  I've only made changes to the existing files.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20186

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: jriddell, knambiar, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Rajeesh K Nambiar]

knambiar added a comment.


  > Wherever you're currently listed, remove your name and replace it with 
Atul's. :) The only place I can find it on Bugzilla. I've gone ahead and made 
@atulbi the default assignee for bugs to the Touchpad-KCM product.
  
  @atulbi  Congratulations, you’re now the maintainer of Touchpad KCM. In 
certain countries, there’s something called “inheritance tax” and you just 
inherited a few dozen bugs. Don’t despair, many of them should be fixed by now 
and some will be fixed by this commit.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20186

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: jriddell, knambiar, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Roman Gilg]

romangg requested changes to this revision.
romangg added a comment.
This revision now requires changes to proceed.


  Nice work. Most of the stuff in libinputtouchpad.cpp and its header file are 
copy-paste from the Wayland backend. It would make sense to have a new abstract 
parent class such that the code is shared.

INLINE COMMENTS

> xlibbackend.h:74
>  QStringList listMouses(const QStringList ) override;
> +QVector getDevices() const override { return m_device ? 
> QVector { m_device.data()} : QVector(); }
>  

Put the definition in the cpp file.

> touchpadconfiglibinput.cpp:55
>  
> -m_backend = TouchpadBackend::implementation();
> +m_backend = backend;
>  m_initError = !m_backend->errorString().isNull();

Put it in the constructor initializer list.

> touchpadbackend.h:43
>  
> +TouchpadInputBackendMode m_mode;
> +

Such a member varialbe shouldn't be public.

> touchpadbackend.h:51
> +virtual bool getDefaultConfig() { return false; }
> +virtual bool isChangedConfig() const { return false; }
>  

Unnecessary changes. Revert these pls to keep the diff size in check.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20186

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: jriddell, knambiar, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Nathaniel Graham]

ngraham added a comment.


  In D20186#443262 , @knambiar wrote:
  
  > >> I happen to be the ‘accidental’ maintainer of the Touchpad KCM. I’d be 
more than happy to hand that hat over if you wish to maintain this code. :-D
  > > 
  > > Hey, I would be happy to take that responsibility.
  >
  > Fantastic.
  >
  > @ngraham @jriddell Would you let me know the technicalities to make Atul 
maintainer of Touchpad KCM? I couldn't find a guideline in the wiki/techbase.
  
  
  Wherever you're currently listed, remove your name and replace it with 
Atul's. :) The only place I can find it on Bugzilla. I've gone ahead and made 
@atulbi the default assignee for bugs to the Touchpad-KCM product.
  
  @atulbi is anything special needed to compile the KCM? After compiling 
plasma-desktop with your patch, no touchpad shared library was produced.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20186

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: jriddell, knambiar, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Rajeesh K Nambiar]

knambiar added a subscriber: jriddell.
knambiar added a comment.


  >> I happen to be the ‘accidental’ maintainer of the Touchpad KCM. I’d be 
more than happy to hand that hat over if you wish to maintain this code. :-D
  > 
  > Hey, I would be happy to take that responsibility.
  
  Fantastic.
  
  @ngraham @jriddell Would you let me know the technicalities to make Atul 
maintainer of Touchpad KCM? I couldn't find a guideline in the wiki/techbase.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20186

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: jriddell, knambiar, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Atul Bisht]

atulbi added a comment.


  In D20186#442088 , @knambiar wrote:
  
  > > Got to Know a lot about how X works with input handling. XD
  >
  > I happen to be the ‘accidental’ maintainer of the Touchpad KCM. I’d be more 
than happy to hand that hat over if you wish to maintain this code. :-D
  
  
  Hey, I would be happy to take that responsibility.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20186

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: knambiar, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Atul Bisht]

atulbi updated this revision to Diff 55277.
atulbi added a comment.


  - Code Cleanup and resolved unexpected behaviour

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20186?vs=55251=55277

BRANCH
  X11Libinput

REVISION DETAIL
  https://phabricator.kde.org/D20186

AFFECTED FILES
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandbackend.cpp
  kcms/touchpad/src/backends/x11/libinputtouchpad.cpp
  kcms/touchpad/src/backends/x11/libinputtouchpad.h
  kcms/touchpad/src/backends/x11/synapticstouchpad.cpp
  kcms/touchpad/src/backends/x11/synapticstouchpad.h
  kcms/touchpad/src/backends/x11/xlibbackend.cpp
  kcms/touchpad/src/backends/x11/xlibbackend.h
  kcms/touchpad/src/backends/x11/xlibtouchpad.cpp
  kcms/touchpad/src/backends/x11/xlibtouchpad.h
  kcms/touchpad/src/kcm/libinput/touchpadconfiglibinput.cpp
  kcms/touchpad/src/kcm/libinput/touchpadconfiglibinput.h
  kcms/touchpad/src/kcm/touchpadconfigcontainer.cpp
  kcms/touchpad/src/kcm/xlib/touchpadconfigxlib.cpp
  kcms/touchpad/src/kcm/xlib/touchpadconfigxlib.h
  kcms/touchpad/src/touchpadbackend.h

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: knambiar, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Rajeesh K Nambiar]

knambiar added a comment.


  > Got to Know a lot about how X works with input handling. XD
  
  I happen to be the ‘accidental’ maintainer of the Touchpad KCM. I’d be more 
than happy to hand that hat over if you wish to maintain this code. :-D

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20186

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: knambiar, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Atul Bisht]

atulbi updated this revision to Diff 55251.
atulbi added a comment.


  - Avoid Setup Backend two times

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20186?vs=55234=55251

BRANCH
  X11Libinput

REVISION DETAIL
  https://phabricator.kde.org/D20186

AFFECTED FILES
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandbackend.cpp
  kcms/touchpad/src/backends/x11/libinputtouchpad.cpp
  kcms/touchpad/src/backends/x11/libinputtouchpad.h
  kcms/touchpad/src/backends/x11/synapticstouchpad.cpp
  kcms/touchpad/src/backends/x11/synapticstouchpad.h
  kcms/touchpad/src/backends/x11/xlibbackend.cpp
  kcms/touchpad/src/backends/x11/xlibbackend.h
  kcms/touchpad/src/backends/x11/xlibtouchpad.cpp
  kcms/touchpad/src/backends/x11/xlibtouchpad.h
  kcms/touchpad/src/kcm/libinput/touchpadconfiglibinput.cpp
  kcms/touchpad/src/kcm/libinput/touchpadconfiglibinput.h
  kcms/touchpad/src/kcm/touchpadconfigcontainer.cpp
  kcms/touchpad/src/kcm/xlib/touchpadconfigxlib.cpp
  kcms/touchpad/src/kcm/xlib/touchpadconfigxlib.h
  kcms/touchpad/src/touchpadbackend.h

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Atul Bisht]

atulbi added a comment.


  In D20186#441892 , @ngraham wrote:
  
  > Thanks so much for this!
  
  
  Got to Know a lot about how X works with input handling. XD

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20186

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Nathaniel Graham]

ngraham added reviewers: romangg, davidedmundson, Plasma.
ngraham added a comment.


  Thanks so much for this!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20186

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Atul Bisht]

atulbi updated this revision to Diff 55234.
atulbi added a comment.


  - Minor changes to optimise code

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20186?vs=55230=55234

BRANCH
  X11Libinput

REVISION DETAIL
  https://phabricator.kde.org/D20186

AFFECTED FILES
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandbackend.cpp
  kcms/touchpad/src/backends/x11/libinputtouchpad.cpp
  kcms/touchpad/src/backends/x11/libinputtouchpad.h
  kcms/touchpad/src/backends/x11/synapticstouchpad.cpp
  kcms/touchpad/src/backends/x11/synapticstouchpad.h
  kcms/touchpad/src/backends/x11/xlibbackend.cpp
  kcms/touchpad/src/backends/x11/xlibbackend.h
  kcms/touchpad/src/backends/x11/xlibtouchpad.cpp
  kcms/touchpad/src/backends/x11/xlibtouchpad.h
  kcms/touchpad/src/kcm/touchpadconfigcontainer.cpp
  kcms/touchpad/src/touchpadbackend.h

To: atulbi, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Atul Bisht]

atulbi created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
atulbi requested review of this revision.

REVISION SUMMARY
  Earlier when libinput was used on X11, XInput specific UI was shown, due to 
which most of the options were grayed out.
  Now we show libinput specific UI that is already used on wayland if libinput 
driver is used on X11.
  
  - loaded all libinput properties that are available on X11.
  - exposed all Q_PROPERTY to Libinput specific UI.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  X11Libinput

REVISION DETAIL
  https://phabricator.kde.org/D20186

AFFECTED FILES
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandbackend.cpp
  kcms/touchpad/src/backends/x11/libinputtouchpad.cpp
  kcms/touchpad/src/backends/x11/libinputtouchpad.h
  kcms/touchpad/src/backends/x11/synapticstouchpad.cpp
  kcms/touchpad/src/backends/x11/synapticstouchpad.h
  kcms/touchpad/src/backends/x11/xlibbackend.cpp
  kcms/touchpad/src/backends/x11/xlibbackend.h
  kcms/touchpad/src/backends/x11/xlibtouchpad.cpp
  kcms/touchpad/src/backends/x11/xlibtouchpad.h
  kcms/touchpad/src/kcm/touchpadconfigcontainer.cpp
  kcms/touchpad/src/touchpadbackend.h

To: atulbi
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart