D20598: [WIP] Port kcm energy info to kirigami 2, fix colors issues

meven updated this revision to Diff 60206. meven added a comment. Add some padding around the inline message when history is not available REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20598?vs=60205=60206 BRANCH arcpatch-D20598_1 REVISION DETAIL

D20598: [WIP] Port kcm energy info to kirigami 2, fix colors issues

meven updated this revision to Diff 60205. meven added a comment. Use KCM.SimpleKCM as root item, fix padding issues, increment kcm version, clean up old now unnecssary workaround REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20598?vs=60193=60205

D20598: [WIP] Port kcm energy info to kirigami 2, fix colors issues

meven updated this revision to Diff 60193. meven added a comment. Rebase code, apply Filip's patch, fix right padding of graph REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20598?vs=56376=60193 BRANCH arcpatch-D20598_1 REVISION DETAIL

D20598: [WIP] Port kcm energy info to kirigami 2, fix colors issues

filipf added a comment. That's what I thought, but it doesn't work :/ What we know is the gap was there before. Since we've now got a Kirigami.ScrollablePage, we can scroll all the content up by holding the mouse. And we can also just make the ScrollablePage the top item. Regardless of

D20598: [WIP] Port kcm energy info to kirigami 2, fix colors issues

ngraham added a comment. Hey that looks pretty good! To fix the top gap, I wonder if it would suffice to add `anchors.fill: parent` or some other positioning mechanism to the top-most `ColumnLayout` inside the `Kirigami.ScrollablePage`. REPOSITORY R102 KInfoCenter REVISION DETAIL

D20598: [WIP] Port kcm energy info to kirigami 2, fix colors issues

filipf added a comment. What I've got right now is: F6918999: image.png F6919002: main.qml The most notable UI change is probably the fact that I added an inline message to waste less space. So

D20598: [WIP] Port kcm energy info to kirigami 2, fix colors issues

filipf added a comment. In D20598#471150 , @meven wrote: > In D20598#471149 , @filipf wrote: > > > In D20598#455424 , @ngraham wrote: > > > > > This

D20598: [WIP] Port kcm energy info to kirigami 2, fix colors issues

meven added a comment. In D20598#471149 , @filipf wrote: > In D20598#455424 , @ngraham wrote: > > > This doesn't actually work for me. Upon opening, the following is printed to the console: > >

D20598: [WIP] Port kcm energy info to kirigami 2, fix colors issues

filipf added a comment. In D20598#455424 , @ngraham wrote: > This doesn't actually work for me. Upon opening, the following is printed to the console: > > org.kde.kcoreaddons: Error loading plugin "kcm_energyinfo" "The shared library was

D20598: [WIP] Port kcm energy info to kirigami 2, fix colors issues

filipf added a comment. In D20598#456330 , @meven wrote: > I don't see those buttons, I guess you need a remote mouse or something similar to have them. Yeah you would need 2 devices I guess. I have my laptop's battery and the wireless

D20598: [WIP] Port kcm energy info to kirigami 2, fix colors issues

ngraham added inline comments. INLINE COMMENTS > meven wrote in main.qml:21 > I might be too aggressive here, what would be the best version to set here ? 2.5 is always a safe bet. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D20598 To: meven, ngraham, broulik,

D20598: [WIP] Port kcm energy info to kirigami 2, fix colors issues

meven added a comment. In D20598#456309 , @filipf wrote: > Works for me, nice work with aligning the layouts. > > I'm a bit conflicted, but I think visually the issue is how these buttons look like with the port, as well as their icons

D20598: [WIP] Port kcm energy info to kirigami 2, fix colors issues

filipf added a comment. Works for me, nice work with aligning the layouts. I'm a bit conflicted, but I think visually the issue is how these buttons look like with the port, as well as their icons (but that was a problem before as well): F6793389: image.png

D20598: [WIP] Port kcm energy info to kirigami 2, fix colors issues

ngraham added a comment. This doesn't actually work for me. Upon opening, the following is printed to the console: org.kde.kcoreaddons: Error loading plugin "kcm_energyinfo" "The shared library was not found." Plugin search paths are ("/usr/lib/x86_64-linux-gnu/qt5/plugins",

D20598: [WIP] Port kcm energy info to kirigami 2, fix colors issues

meven added a comment. After last patch : F6776301: energy-information-after-3.png REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D20598 To: meven, ngraham, broulik, filipf Cc: filipf, davidre, broulik, plasma-devel,

D20598: [WIP] Port kcm energy info to kirigami 2, fix colors issues

meven updated this revision to Diff 56376. meven added a comment. Fix FormLayout alignment REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20598?vs=56369=56376 BRANCH arcpatch-D20598 REVISION DETAIL https://phabricator.kde.org/D20598 AFFECTED

D20598: [WIP] Port kcm energy info to kirigami 2, fix colors issues

meven added a comment. New State: F6776169: energy-information-after-2.png QtControls port is not done. It is just a step. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D20598 To: meven, ngraham, broulik, filipf

D20598: [WIP] Port kcm energy info to kirigami 2, fix colors issues

meven updated this revision to Diff 56369. meven added a comment. Port to QtQuickControls 2 and proper FormLayout REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20598?vs=56359=56369 BRANCH arcpatch-D20598 REVISION DETAIL

D20598: [WIP] Port kcm energy info to kirigami 2, fix colors issues

filipf requested changes to this revision. filipf added a comment. This revision now requires changes to proceed. Here's what works: Repeater { id: helloThere // I'll leave the naming up to you :) model: root.details Kirigami.FormLayout {

D20598: [WIP] Port kcm energy info to kirigami 2, fix colors issues

filipf added a comment. Looks like you'll need to use twinFormLayouts. One unfortunate thing is you can go "ha, I'll have all the layouts adjust to this specific one (with the longest label)". You'll need to have them all interlinked with one another because label length can change based on

D20598: [WIP] Port kcm energy info to kirigami 2, fix colors issues

meven added inline comments. INLINE COMMENTS > broulik wrote in main.qml:459 > Shouldn't be neccessary as it's `QQC2.Label` For breeze dark this makes the label, dark gray on a dark background. See before screenshot. Could it be a breeze dark bug ? REPOSITORY R102 KInfoCenter REVISION

D20598: [WIP] Port kcm energy info to kirigami 2, fix colors issues

davidre added a comment. > I haven't found a way to align Kirigami.FormLayout together in a repeater. Maybe you could use twinFormLayouts like in D19873 and D19932 ? REPOSITORY R102 KInfoCenter REVISION DETAIL

D20598: [WIP] Port kcm energy info to kirigami 2, fix colors issues

broulik added a comment. > way to align Kirigami.FormLayout together in a repeater. Check out the `twinFormLayouts` property where you can have it manage multiple different `FormLayout` instances as a single layout INLINE COMMENTS > main.qml:21 > +import QtQuick 2.5 > import

D20598: [WIP] Port kcm energy info to kirigami 2, fix colors issues

meven created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY Just a beginning. I haven't found a way to align Kirigami.FormLayout together in a repeater. There is still room for improvement.