D20867: Add Property to disable drawing of menu arrow indicators

[Nathaniel Graham]

ngraham added a comment.


  Sorry for the delayed response! Let me block out some time to give it a 
whirl. I am left wondering if there's any simpler way we can do it though. 
KWidgetsAddons, Breeze, and Dolphin each have different release cycles, so 
making sure everything gets in at the right time and things work without other 
bits already present may be challenging.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D20867

To: hallas, ngraham
Cc: mart, davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D20867: Add Property to disable drawing of menu arrow indicators

[David Hallas]

hallas added a comment.


  In D20867#482950 , @ngraham wrote:
  
  > Actually maybe it just needs a rebase on master...
  
  
  Let me give it a rebase then :D

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D20867

To: hallas, ngraham
Cc: mart, davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D20867: Add Property to disable drawing of menu arrow indicators

[Nathaniel Graham]

ngraham added a comment.


  Actually maybe it just needs a rebase on master...

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D20867

To: hallas, ngraham
Cc: mart, davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D20867: Add Property to disable drawing of menu arrow indicators

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  This patch doesn't seem to make the back and forward buttons lose their 
arrows once I've applied D19311 , and it 
also makes all KDE apps crash like so:
  
(gdb) bt
#0  QObject::property (this=0x0, 
name=0x7fffe0ab28d0  
"_kde_toolButton_noMenuArrow") at kernel/qobject.cpp:3961
#1  0x7fffe0a8cd3f in BreezePrivate::hasInlineIndicator (
toolButtonOption=0x55c2e9e0, toolButton=)
at /home/dev/kde/src/breeze/kstyle/breezestyle.cpp:160
#2  0x7fffe0a8df30 in Breeze::Style::toolButtonSizeFromContents (
this=, option=, contentsSize=..., 
widget=) at 
/home/dev/kde/src/breeze/kstyle/breezestyle.cpp:2739

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D20867

To: hallas, ngraham
Cc: mart, davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D20867: Add Property to disable drawing of menu arrow indicators

[David Hallas]

hallas added a comment.


  Hi @ngraham  - any update on this one? Should we move forward with this 
approach or should we do something else?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D20867

To: hallas, ngraham
Cc: mart, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D20867: Add Property to disable drawing of menu arrow indicators

[David Hallas]

hallas added a comment.


  In D20867#461499 , @mart wrote:
  
  > In D20867#457580 , @hallas wrote:
  >
  > > In D20867#457575 , 
@davidedmundson wrote:
  > >
  > > > QToolButton::setArrowType?
  > >
  > >
  > > I just tried that, but it doesn't seem like Breeze honors this property - 
at least not for the `QToolButton` produced by `KToolBarPopupAction`. So adding
  >
  >
  > That's probably a breeze bug and that's where it should be addressed.
  >  an application can't link to breeze, especially if is private api. (and 
would explode dependencies in distros package managers)
  
  
  @mart  - I am not sure I follow? I think the QToolButton::ArrowType is 
intended for something else then what we are trying to do here. I am not trying 
to make any application depend directly on breeze. Instead these properties are 
loosely coupled, so an application setting a property doesn't impose that the 
application needs to link with breeze. It is simply a hint to the style.
  
  With that being said, I am certainly open to other ways of solving this 
problem, so feel free to pinch in ;)

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D20867

To: hallas, ngraham
Cc: mart, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D20867: Add Property to disable drawing of menu arrow indicators

[Marco Martin]

mart added a comment.


  In D20867#457580 , @hallas wrote:
  
  > In D20867#457575 , 
@davidedmundson wrote:
  >
  > > QToolButton::setArrowType?
  >
  >
  > I just tried that, but it doesn't seem like Breeze honors this property - 
at least not for the `QToolButton` produced by `KToolBarPopupAction`. So adding
  
  
  That's probably a breeze bug and that's where it should be addressed.
  an application can't link to breeze, especially if is private api. (and would 
explode dependencies in distros package managers)

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D20867

To: hallas, ngraham
Cc: mart, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D20867: Add Property to disable drawing of menu arrow indicators

[David Hallas]

hallas added a comment.


  In D20867#457575 , @davidedmundson 
wrote:
  
  > QToolButton::setArrowType?
  
  
  After reading the documents and experimenting a bit, I think that this 
property is not what we are looking for. The Arrow Type property is to display 
the Tool Button as an arrow instead of an icon and this is not what we use to 
draw the down arrow indicator on Tool Buttons with a popup menu, instead this 
is drawn "directly" by Breeze.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D20867

To: hallas, ngraham
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20867: Add Property to disable drawing of menu arrow indicators

[David Hallas]

hallas added a comment.


  In D20867#457575 , @davidedmundson 
wrote:
  
  > QToolButton::setArrowType?
  
  
  I just tried that, but it doesn't seem like Breeze honors this property - at 
least not for the `QToolButton` produced by `KToolBarPopupAction`. So adding
  
button->setArrowType(Qt::ArrowType::NoArrow);
  
  to
  
QWidget *KToolBarPopupAction::createWidget(QWidget *_parent)
  
  still display the arrows :/ Or am I doing something wrong?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D20867

To: hallas, ngraham
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20867: Add Property to disable drawing of menu arrow indicators

[David Edmundson]

davidedmundson added a comment.


  QToolButton::setArrowType?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D20867

To: hallas, ngraham
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20867: Add Property to disable drawing of menu arrow indicators

[David Edmundson]

davidedmundson added a comment.


  There shouldn't be any Breeze specific code in client apps. It's a sign of 
something being wrong.
  
  What's a navigation style toolbutton and where do you want to use this?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D20867

To: hallas, ngraham
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20867: Add Property to disable drawing of menu arrow indicators

[David Hallas]

hallas added a comment.


  In D20867#457570 , @davidedmundson 
wrote:
  
  > There shouldn't be any Breeze specific code in client apps. It's a sign of 
something being wrong.
  >
  > What's a navigation style toolbutton and where do you want to use this?
  
  
  It is this patch D19311  that has been 
driving this change. If you have suggestions for a better way to solve this it 
would be more than welcome :D

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D20867

To: hallas, ngraham
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20867: Add Property to disable drawing of menu arrow indicators

[David Hallas]

hallas created this revision.
hallas added a reviewer: ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
hallas requested review of this revision.

REVISION SUMMARY
  Add Property to disable drawing of menu arrow indicators. This is useful
  for navigation type Tool Buttons.

REPOSITORY
  R31 Breeze

BRANCH
  add_property_to_disable_drawing_of_menu_arrow_indicator (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20867

AFFECTED FILES
  kstyle/breezepropertynames.cpp
  kstyle/breezepropertynames.h
  kstyle/breezestyle.cpp

To: hallas, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart